From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E919EC02181 for ; Fri, 24 Jan 2025 18:29:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tPqRKtOeDHuWWGpDNIuLjFDNsd0B6a4tibzcHC11jHA=; b=HfEhFNRdjWjJnB mbr0eanwHq/vPXRIxFh6LtK6uuKzZKtqmfwZ0i8NvNsmdBT0mGnf/3duXNtRyQcX0jWiDvWSkMWvA y+0++nxDa1hncY5pxEkKZWfzo9JbCHS0xBT08L5lO+weseiG5wxNzCkrkc7QdVC5t7V0uQz/aEood qE+zeL/EmrYNCDT4sSsZcGmr3gyhneIh6oKPnhmsSfWUryk2SIdYf7zQxDBcx/my/zmDjoCk/nriD M9yQDUdWAN8z96oNLE/4jn/v2Yfof/MVVBRYetwRETUESdJ/VAT8pYlKWGH9TjTIeTo+j/mfuKas0 O6c0bMM/4S33FX3gbKhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tbOQK-0000000FIBv-2mA9; Fri, 24 Jan 2025 18:28:56 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tbOQI-0000000FIAb-0faf for linux-riscv@lists.infradead.org; Fri, 24 Jan 2025 18:28:55 +0000 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2f78a4ca5deso3433656a91.0 for ; Fri, 24 Jan 2025 10:28:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1737743333; x=1738348133; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=8mi8VPKnc/rijmPRv6U/IJSuAJ48E0dl7KypEOb/XOU=; b=bsxIDm9xDn23d9LAuN76TLKgu8t4onR2mkO/KufaonBFIomJQmDE1uuXxlGJ3bj0IZ aTEUI91gb8fNrVYioVjJyPjx21DPYuX8xGeGqP5giu1LuQypeXXRsg0X02iPmq9d/f3T LEa+HWNg+c7pFAUZh45uPomfrrDj9rKcZ4vGzr7E05iLDVLG9/fsTjbgPjxzSgPxlqdf mxMOrXChIss5OpTQ2g8TNNJ1dM72Lzxapo4RBtp4B+3OX7uHUCa6lBKcRuwf9o4gnwNy 15/dLBxZel7rzB8DCFEkiKQ44ZqZO/xZQ1X3ILxhNen5Tj6B0b6DViqPfS7A/vXJlfJj kIfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737743333; x=1738348133; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8mi8VPKnc/rijmPRv6U/IJSuAJ48E0dl7KypEOb/XOU=; b=jg6iLkL0KHiREG7m9qDe/P16cxxnqF5zN19AzoPXUGJiUkl+TCK+4Rih2DPN0FLBfq 08Lp0KA26WWBbRrLuMP72eAi5JgMlax6btejJnT8fTIoPH6EqTtfBxvKotEm7BHkf8SR uQtnMVdvHRDBsBvj5pOBJPqwlNYMXS6SJ2xICl9PQkjYQHT4f7FFEfsRlZlTsjPeTqnn 49FOoQ2UTSXLzFuh0dGNSeW+M7Hj600BOYFqvFKMiqTfognyAygabzDexzUxVBXsKmzc hvnwzgv7xYyIfxoPS88WE7W6kPz5GXAVg1ty7bgdpLAr61MMVdX6A1kSEPvv/ekW6lsG bgWA== X-Forwarded-Encrypted: i=1; AJvYcCUkbgLme9t14f6q/HHswjx6HLdfNjl1+N5EiuaixH09dm5d3rDfd4JEz0sTPYEz2rj/8rPC3wSdoh1DHg==@lists.infradead.org X-Gm-Message-State: AOJu0YxfMEn/PnTPn046lP6xKpvmd1PdAi+cLzwnsuosiSlYFZDABwuD VnOnAi6Ddq0KGeCFCQipPzjn3MNVOlqE62rfvrS2eRymVS7kPjsHs3gn7PAXRlg= X-Gm-Gg: ASbGnctpBhb69qZDXj9t7w0x2EQGunlcz4k9RqbOxnzIHECQpOxWFu6bwE71JIQMKas Wbabw3QIZDVUlQVWI4/AceIYdgvz0v4+ez1qs0f8tQqwXCLwlQXFSnkyjjOyv/5EiosXD5QdCQ6 UICePDwpatbKAsNzTG42jck72g0HQE39BmnliDHbkBjLvCgVNeA/N+thXb2hAtijdrPW/lmqqi0 uZNpZudQTIHkFGu++NYEmzHtVBGjvsOK+Tuc6E0d8QMthvVQtF4OBIk9Toy2/hQ3dGS4RCvLXs= X-Google-Smtp-Source: AGHT+IHA4N16HWh6D6ociCzA4jkBLKWzl7eCVyJWgy/BQ7/q5B7t82MMNw4lNH/Bv7YLi+Hi+jI30g== X-Received: by 2002:a17:90a:c888:b0:2f4:f7f8:fc8a with SMTP id 98e67ed59e1d1-2f782d8cd4emr49337076a91.33.1737743333401; Fri, 24 Jan 2025 10:28:53 -0800 (PST) Received: from ghost ([2601:647:6700:64d0:63b:8ac9:503a:b81d]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f7ffa76d1csm2055339a91.32.2025.01.24.10.28.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 10:28:52 -0800 (PST) Date: Fri, 24 Jan 2025 10:28:50 -0800 From: Charlie Jenkins To: Huacai Chen Cc: Paul Walmsley , Palmer Dabbelt , WANG Xuerui , Thomas Gleixner , Peter Zijlstra , Andy Lutomirski , Alexandre Ghiti , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev Subject: Re: [PATCH v2 3/4] loongarch: entry: Migrate ret_from_fork() to C Message-ID: References: <20250123-riscv_optimize_entry-v2-0-7c259492d508@rivosinc.com> <20250123-riscv_optimize_entry-v2-3-7c259492d508@rivosinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250124_102854_208075_A642C422 X-CRM114-Status: GOOD ( 24.88 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKYW4gMjQsIDIwMjUgYXQgMDU6MDU6MjFQTSArMDgwMCwgSHVhY2FpIENoZW4gd3Jv dGU6Cj4gSGksIENoYXJsaWUsCj4gCj4gT24gRnJpLCBKYW4gMjQsIDIwMjUgYXQgMzoxNeKAr0FN IENoYXJsaWUgSmVua2lucyA8Y2hhcmxpZUByaXZvc2luYy5jb20+IHdyb3RlOgo+ID4KPiA+IExv b25nYXJjaCBpcyB0aGUgb25seSBhcmNoaXRlY3R1cmUgdGhhdCBjYWxscwo+IFdlIHVzdWFsbHkg dXNlICJMb29uZ0FyY2giIGluc3RlYWQgb2YgImxvb25nYXJjaCIgb3IgIkxvb25nYXJjaCIuCj4g Cj4gPiBzeXNjYWxsX2V4aXRfdG9fdXNlcl9tb2RlKCkgZnJvbSBhc20uIE1vdmUgdGhlIGNhbGwg aW50byBDIHNvIHRoYXQgdGhpcwo+ID4gZnVuY3Rpb24gY2FuIGJlIGlubGluZWQgYWNyb3NzIGFs bCBhcmNoaXRlY3R1cmVzLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IENoYXJsaWUgSmVua2lucyA8 Y2hhcmxpZUByaXZvc2luYy5jb20+Cj4gPiAtLS0KPiA+ICBhcmNoL2xvb25nYXJjaC9pbmNsdWRl L2FzbS9hc20tcHJvdG90eXBlcy5oIHwgIDUgKysrKysKPiA+ICBhcmNoL2xvb25nYXJjaC9pbmNs dWRlL2FzbS9zd2l0Y2hfdG8uaCAgICAgIHwgIDggKysrKysrKwo+ID4gIGFyY2gvbG9vbmdhcmNo L2tlcm5lbC9lbnRyeS5TICAgICAgICAgICAgICAgfCAyMiArKysrKysrKystLS0tLS0tLS0tCj4g PiAgYXJjaC9sb29uZ2FyY2gva2VybmVsL3Byb2Nlc3MuYyAgICAgICAgICAgICB8IDM0ICsrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tCj4gPiAgNCBmaWxlcyBjaGFuZ2VkLCA1MSBpbnNlcnRp b25zKCspLCAxOCBkZWxldGlvbnMoLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9sb29uZ2Fy Y2gvaW5jbHVkZS9hc20vYXNtLXByb3RvdHlwZXMuaCBiL2FyY2gvbG9vbmdhcmNoL2luY2x1ZGUv YXNtL2FzbS1wcm90b3R5cGVzLmgKPiA+IGluZGV4IDUxZjIyNGJjZmM2NTQyMjhhZTQyM2U5YTA2 NmIyNWIzNTEwMmE1YjkuLjAxOTVkNDMwOWZkMjlmOTQ2NjRkNWYzNDI0NzE5OGM3NjkwMzNiMWIg MTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL2xvb25nYXJjaC9pbmNsdWRlL2FzbS9hc20tcHJvdG90eXBl cy5oCj4gPiArKysgYi9hcmNoL2xvb25nYXJjaC9pbmNsdWRlL2FzbS9hc20tcHJvdG90eXBlcy5o Cj4gPiBAQCAtMTIsMyArMTIsOCBAQCBfX2ludDEyOF90IF9fYXNobHRpMyhfX2ludDEyOF90IGEs IGludCBiKTsKPiA+ICBfX2ludDEyOF90IF9fYXNocnRpMyhfX2ludDEyOF90IGEsIGludCBiKTsK PiA+ICBfX2ludDEyOF90IF9fbHNocnRpMyhfX2ludDEyOF90IGEsIGludCBiKTsKPiA+ICAjZW5k aWYKPiA+ICsKPiA+ICthc21saW5rYWdlIHZvaWQgbm9pbnN0ciBfX25vX3N0YWNrX3Byb3RlY3Rv ciByZXRfZnJvbV9rZXJuZWxfdGhyZWFkKHN0cnVjdCB0YXNrX3N0cnVjdCAqcHJldiwKPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgc3RydWN0IHB0X3JlZ3MgKnJlZ3MsCj4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCAoKmZuKSh2 b2lkICopLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB2b2lkICpmbl9hcmcpOwo+IEl0IGlzIGEgbGl0dGxlIHN0 cmFuZ2UgdGhhdCB3ZSBvbmx5IG5lZWQgdG8gZGVjbGFyZQo+IHJldF9mcm9tX2tlcm5lbF90aHJl YWQoKSBidXQgbm90IHJldF9mcm9tX2ZvcmsoKS4KCkp1c3QgYW4gb3ZlcnNpZ2h0IGJ5IG1lLCB0 aGFuayB5b3UgZm9yIHBvaW50aW5nIHRoYXQgb3V0LgoKPiAKPiA+IGRpZmYgLS1naXQgYS9hcmNo L2xvb25nYXJjaC9pbmNsdWRlL2FzbS9zd2l0Y2hfdG8uaCBiL2FyY2gvbG9vbmdhcmNoL2luY2x1 ZGUvYXNtL3N3aXRjaF90by5oCj4gPiBpbmRleCA1YjIyNWFmZjNiYTIxYWEwNmQwNzEzYmM4ZTcz ZTFiOTQxMzg5NjMwLi5hMWM1NTc2ZjFmZDE0NTY3MGUxMzAzOGJlYzZkZDM5MDQ4NjA5OWFiIDEw MDY0NAo+ID4gLS0tIGEvYXJjaC9sb29uZ2FyY2gvaW5jbHVkZS9hc20vc3dpdGNoX3RvLmgKPiA+ ICsrKyBiL2FyY2gvbG9vbmdhcmNoL2luY2x1ZGUvYXNtL3N3aXRjaF90by5oCj4gPiBAQCAtMjYs NiArMjYsMTQgQEAgZXh0ZXJuIGFzbWxpbmthZ2Ugc3RydWN0IHRhc2tfc3RydWN0ICpfX3N3aXRj aF90byhzdHJ1Y3QgdGFza19zdHJ1Y3QgKnByZXYsCj4gPiAgICAgICAgICAgICAgICAgICAgICAg ICBzdHJ1Y3QgdGFza19zdHJ1Y3QgKm5leHQsIHN0cnVjdCB0aHJlYWRfaW5mbyAqbmV4dF90aSwK PiA+ICAgICAgICAgICAgICAgICAgICAgICAgIHZvaWQgKnNjaGVkX3JhLCB2b2lkICpzY2hlZF9j ZmEpOwo+ID4KPiA+ICt2b2lkIG5vaW5zdHIgX19ub19zdGFja19wcm90ZWN0b3IgcmV0X2Zyb21f a2VybmVsX3RocmVhZChzdHJ1Y3QgdGFza19zdHJ1Y3QgKnByZXYsCj4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgcHRfcmVn cyAqcmVncywKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGludCAoKmZuKSh2b2lkICopLAo+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdm9pZCAqZm5fYXJnKTsKPiA+ICsK PiA+ICt2b2lkIG5vaW5zdHIgX19ub19zdGFja19wcm90ZWN0b3IgcmV0X2Zyb21fZm9yayhzdHJ1 Y3QgdGFza19zdHJ1Y3QgKnByZXYsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzdHJ1Y3QgcHRfcmVncyAqcmVncyk7Cj4gPiArCj4gSSBwcmVmZXIg YWxwaGEtYmV0aWNhbCBvcmRlciwgd2hpY2ggbWVhbnMgcHV0IHJldF9mcm9tX2ZvcmsoKSBiZWZv cmUKPiByZXRfZnJvbV9rZXJuZWxfdGhyZWFkKCkuCgpNYWtlcyBzZW5zZSEKCj4gCj4gPiAgLyoK PiA+ICAgKiBGb3IgbmV3bHkgY3JlYXRlZCBrZXJuZWwgdGhyZWFkcyBzd2l0Y2hfdG8oKSB3aWxs IHJldHVybiB0bwo+ID4gICAqIHJldF9mcm9tX2tlcm5lbF90aHJlYWQsIG5ld2x5IGNyZWF0ZWQg dXNlciB0aHJlYWRzIHRvIHJldF9mcm9tX2ZvcmsuCj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9sb29u Z2FyY2gva2VybmVsL2VudHJ5LlMgYi9hcmNoL2xvb25nYXJjaC9rZXJuZWwvZW50cnkuUwo+ID4g aW5kZXggNDhlN2UzNGUzNTVlODNlYWU4MTY1OTU3YmEyZWFjMDVhOGJmMTdkZi4uMmFiYzI5ZTU3 MzgxMGUwMDBmMmZlZjQ2NDZkZGNhMGRiYjgwZWFiZSAxMDA2NDQKPiA+IC0tLSBhL2FyY2gvbG9v bmdhcmNoL2tlcm5lbC9lbnRyeS5TCj4gPiArKysgYi9hcmNoL2xvb25nYXJjaC9rZXJuZWwvZW50 cnkuUwo+ID4gQEAgLTc3LDI0ICs3NywyMiBAQCBTWU1fQ09ERV9TVEFSVChoYW5kbGVfc3lzY2Fs bCkKPiA+ICBTWU1fQ09ERV9FTkQoaGFuZGxlX3N5c2NhbGwpCj4gPiAgX0FTTV9OT0tQUk9CRSho YW5kbGVfc3lzY2FsbCkKPiA+Cj4gPiAtU1lNX0NPREVfU1RBUlQocmV0X2Zyb21fZm9yaykKPiA+ ICtTWU1fQ09ERV9TVEFSVChyZXRfZnJvbV9mb3JrX2FzbSkKPiA+ICAgICAgICAgVU5XSU5EX0hJ TlRfUkVHUwo+ID4gLSAgICAgICBibCAgICAgICAgICAgICAgc2NoZWR1bGVfdGFpbCAgICAgICAg ICAgIyBhMCA9IHN0cnVjdCB0YXNrX3N0cnVjdCAqcHJldgo+ID4gLSAgICAgICBtb3ZlICAgICAg ICAgICAgYTAsIHNwCj4gPiAtICAgICAgIGJsICAgICAgICAgICAgICBzeXNjYWxsX2V4aXRfdG9f dXNlcl9tb2RlCj4gPiArICAgICAgIG1vdmUgICAgICAgICAgICBhMSwgc3AKPiA+ICsgICAgICAg YmwgICAgICAgICAgICAgIHJldF9mcm9tX2ZvcmsKPiA+ICAgICAgICAgUkVTVE9SRV9TVEFUSUMK PiA+ICAgICAgICAgUkVTVE9SRV9TT01FCj4gPiAgICAgICAgIFJFU1RPUkVfU1BfQU5EX1JFVAo+ ID4gLVNZTV9DT0RFX0VORChyZXRfZnJvbV9mb3JrKQo+ID4gK1NZTV9DT0RFX0VORChyZXRfZnJv bV9mb3JrX2FzbSkKPiA+Cj4gPiAtU1lNX0NPREVfU1RBUlQocmV0X2Zyb21fa2VybmVsX3RocmVh ZCkKPiA+ICtTWU1fQ09ERV9TVEFSVChyZXRfZnJvbV9rZXJuZWxfdGhyZWFkX2FzbSkKPiA+ICAg ICAgICAgVU5XSU5EX0hJTlRfUkVHUwo+ID4gLSAgICAgICBibCAgICAgICAgICAgICAgc2NoZWR1 bGVfdGFpbCAgICAgICAgICAgIyBhMCA9IHN0cnVjdCB0YXNrX3N0cnVjdCAqcHJldgo+ID4gLSAg ICAgICBtb3ZlICAgICAgICAgICAgYTAsIHMxCj4gPiAtICAgICAgIGppcmwgICAgICAgICAgICBy YSwgczAsIDAKPiA+IC0gICAgICAgbW92ZSAgICAgICAgICAgIGEwLCBzcAo+ID4gLSAgICAgICBi bCAgICAgICAgICAgICAgc3lzY2FsbF9leGl0X3RvX3VzZXJfbW9kZQo+ID4gKyAgICAgICBtb3Zl ICAgICAgICAgICAgYTEsIHNwCj4gPiArICAgICAgIG1vdmUgICAgICAgICAgICBhMiwgczAKPiA+ ICsgICAgICAgbW92ZSAgICAgICAgICAgIGEzLCBzMQo+ID4gKyAgICAgICBibCAgICAgICAgICAg ICAgcmV0X2Zyb21fa2VybmVsX3RocmVhZAo+ID4gICAgICAgICBSRVNUT1JFX1NUQVRJQwo+ID4g ICAgICAgICBSRVNUT1JFX1NPTUUKPiA+ICAgICAgICAgUkVTVE9SRV9TUF9BTkRfUkVUCj4gPiAt U1lNX0NPREVfRU5EKHJldF9mcm9tX2tlcm5lbF90aHJlYWQpCj4gPiArU1lNX0NPREVfRU5EKHJl dF9mcm9tX2tlcm5lbF90aHJlYWRfYXNtKQo+ID4gZGlmZiAtLWdpdCBhL2FyY2gvbG9vbmdhcmNo L2tlcm5lbC9wcm9jZXNzLmMgYi9hcmNoL2xvb25nYXJjaC9rZXJuZWwvcHJvY2Vzcy5jCj4gPiBp bmRleCA2ZTU4ZjY1NDU1YzdjYTNlYWUyZTg4ZWQ4NTJjODY1NWE2NzAxZTVjLi4xNmNjOTQ5ZmU0 MzQ0M2Q3MGYxZDg2NWNlMDQ1OTVjMmQ4YzE2MTViIDEwMDY0NAo+ID4gLS0tIGEvYXJjaC9sb29u Z2FyY2gva2VybmVsL3Byb2Nlc3MuYwo+ID4gKysrIGIvYXJjaC9sb29uZ2FyY2gva2VybmVsL3By b2Nlc3MuYwo+ID4gQEAgLTE0LDYgKzE0LDcgQEAKPiA+ICAjaW5jbHVkZSA8bGludXgvaW5pdC5o Pgo+ID4gICNpbmNsdWRlIDxsaW51eC9rZXJuZWwuaD4KPiA+ICAjaW5jbHVkZSA8bGludXgvZXJy bm8uaD4KPiA+ICsjaW5jbHVkZSA8bGludXgvZW50cnktY29tbW9uLmg+Cj4gPiAgI2luY2x1ZGUg PGxpbnV4L3NjaGVkLmg+Cj4gPiAgI2luY2x1ZGUgPGxpbnV4L3NjaGVkL2RlYnVnLmg+Cj4gPiAg I2luY2x1ZGUgPGxpbnV4L3NjaGVkL3Rhc2suaD4KPiA+IEBAIC0zMyw2ICszNCw3IEBACj4gPiAg I2luY2x1ZGUgPGxpbnV4L3ByY3RsLmg+Cj4gPiAgI2luY2x1ZGUgPGxpbnV4L25taS5oPgo+ID4K PiA+ICsjaW5jbHVkZSA8YXNtL2FzbS1wcm90b3R5cGVzLmg+Cj4gPiAgI2luY2x1ZGUgPGFzbS9h c20uaD4KPiA+ICAjaW5jbHVkZSA8YXNtL2Jvb3RpbmZvLmg+Cj4gPiAgI2luY2x1ZGUgPGFzbS9j cHUuaD4KPiA+IEBAIC00Nyw2ICs0OSw3IEBACj4gPiAgI2luY2x1ZGUgPGFzbS9wZ3RhYmxlLmg+ Cj4gPiAgI2luY2x1ZGUgPGFzbS9wcm9jZXNzb3IuaD4KPiA+ICAjaW5jbHVkZSA8YXNtL3JlZy5o Pgo+ID4gKyNpbmNsdWRlIDxhc20vc3dpdGNoX3RvLmg+Cj4gPiAgI2luY2x1ZGUgPGFzbS91bndp bmQuaD4KPiA+ICAjaW5jbHVkZSA8YXNtL3Zkc28uaD4KPiA+Cj4gPiBAQCAtNjMsOCArNjYsOSBA QCBFWFBPUlRfU1lNQk9MKF9fc3RhY2tfY2hrX2d1YXJkKTsKPiA+ICB1bnNpZ25lZCBsb25nIGJv b3Rfb3B0aW9uX2lkbGVfb3ZlcnJpZGUgPSBJRExFX05PX09WRVJSSURFOwo+ID4gIEVYUE9SVF9T WU1CT0woYm9vdF9vcHRpb25faWRsZV9vdmVycmlkZSk7Cj4gPgo+ID4gLWFzbWxpbmthZ2Ugdm9p ZCByZXRfZnJvbV9mb3JrKHZvaWQpOwo+ID4gLWFzbWxpbmthZ2Ugdm9pZCByZXRfZnJvbV9rZXJu ZWxfdGhyZWFkKHZvaWQpOwo+ID4gK2FzbWxpbmthZ2Ugdm9pZCByZXN0b3JlX2FuZF9yZXQodm9p ZCk7Cj4gPiArYXNtbGlua2FnZSB2b2lkIHJldF9mcm9tX2ZvcmtfYXNtKHZvaWQpOwo+ID4gK2Fz bWxpbmthZ2Ugdm9pZCByZXRfZnJvbV9rZXJuZWxfdGhyZWFkX2FzbSh2b2lkKTsKPiA+Cj4gPiAg dm9pZCBzdGFydF90aHJlYWQoc3RydWN0IHB0X3JlZ3MgKnJlZ3MsIHVuc2lnbmVkIGxvbmcgcGMs IHVuc2lnbmVkIGxvbmcgc3ApCj4gPiAgewo+ID4gQEAgLTEzOCw2ICsxNDIsMjQgQEAgaW50IGFy Y2hfZHVwX3Rhc2tfc3RydWN0KHN0cnVjdCB0YXNrX3N0cnVjdCAqZHN0LCBzdHJ1Y3QgdGFza19z dHJ1Y3QgKnNyYykKPiA+ICAgICAgICAgcmV0dXJuIDA7Cj4gPiAgfQo+ID4KPiA+ICthc21saW5r YWdlIHZvaWQgbm9pbnN0ciBfX25vX3N0YWNrX3Byb3RlY3RvciByZXRfZnJvbV9rZXJuZWxfdGhy ZWFkKHN0cnVjdCB0YXNrX3N0cnVjdCAqcHJldiwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHB0X3Jl Z3MgKnJlZ3MsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGludCAoKmZuKSh2b2lkICopLAo+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB2b2lkICpmbl9hcmcpCj4gPiArewo+ID4gKyAgICAgICBzY2hlZHVsZV90YWlsKHByZXYpOwo+ ID4gKwo+ID4gKyAgICAgICBmbihmbl9hcmcpOwo+ID4gKwo+IFRoZSB0d28gYmxhbmsgbGluZXMg Y2FuIGJlIHJlbW92ZWQsIGFuZCBhZ2FpbiwgSSBwcmVmZXIgYWxwaGEtYmV0aWNhbAo+IG9yZGVy LCB3aGljaCBtZWFucyBwdXQgcmV0X2Zyb21fZm9yaygpIGJlZm9yZQo+IHJldF9mcm9tX2tlcm5l bF90aHJlYWQoKS4KCldpbGwgdXBkYXRlIGluIHRoZSBuZXh0IHZlcnNpb24uCgotIENoYXJsaWUK Cj4gCj4gSHVhY2FpCj4gCj4gPiArICAgICAgIHN5c2NhbGxfZXhpdF90b191c2VyX21vZGUocmVn cyk7Cj4gPiArfQo+ID4gKwo+ID4gK3ZvaWQgbm9pbnN0ciBfX25vX3N0YWNrX3Byb3RlY3RvciBy ZXRfZnJvbV9mb3JrKHN0cnVjdCB0YXNrX3N0cnVjdCAqcHJldiwgc3RydWN0IHB0X3JlZ3MgKnJl Z3MpCj4gPiArewo+ID4gKyAgICAgICBzY2hlZHVsZV90YWlsKHByZXYpOwo+ID4gKyAgICAgICBz eXNjYWxsX2V4aXRfdG9fdXNlcl9tb2RlKHJlZ3MpOwo+ID4gK30KPiA+ICsKPiA+ICAvKgo+ID4g ICAqIENvcHkgYXJjaGl0ZWN0dXJlLXNwZWNpZmljIHRocmVhZCBzdGF0ZQo+ID4gICAqLwo+ID4g QEAgLTE2NSw4ICsxODcsOCBAQCBpbnQgY29weV90aHJlYWQoc3RydWN0IHRhc2tfc3RydWN0ICpw LCBjb25zdCBzdHJ1Y3Qga2VybmVsX2Nsb25lX2FyZ3MgKmFyZ3MpCj4gPiAgICAgICAgICAgICAg ICAgcC0+dGhyZWFkLnJlZzAzID0gY2hpbGRrc3A7Cj4gPiAgICAgICAgICAgICAgICAgcC0+dGhy ZWFkLnJlZzIzID0gKHVuc2lnbmVkIGxvbmcpYXJncy0+Zm47Cj4gPiAgICAgICAgICAgICAgICAg cC0+dGhyZWFkLnJlZzI0ID0gKHVuc2lnbmVkIGxvbmcpYXJncy0+Zm5fYXJnOwo+ID4gLSAgICAg ICAgICAgICAgIHAtPnRocmVhZC5yZWcwMSA9ICh1bnNpZ25lZCBsb25nKXJldF9mcm9tX2tlcm5l bF90aHJlYWQ7Cj4gPiAtICAgICAgICAgICAgICAgcC0+dGhyZWFkLnNjaGVkX3JhID0gKHVuc2ln bmVkIGxvbmcpcmV0X2Zyb21fa2VybmVsX3RocmVhZDsKPiA+ICsgICAgICAgICAgICAgICBwLT50 aHJlYWQucmVnMDEgPSAodW5zaWduZWQgbG9uZylyZXRfZnJvbV9rZXJuZWxfdGhyZWFkX2FzbTsK PiA+ICsgICAgICAgICAgICAgICBwLT50aHJlYWQuc2NoZWRfcmEgPSAodW5zaWduZWQgbG9uZyly ZXRfZnJvbV9rZXJuZWxfdGhyZWFkX2FzbTsKPiA+ICAgICAgICAgICAgICAgICBtZW1zZXQoY2hp bGRyZWdzLCAwLCBzaXplb2Yoc3RydWN0IHB0X3JlZ3MpKTsKPiA+ICAgICAgICAgICAgICAgICBj aGlsZHJlZ3MtPmNzcl9ldWVuID0gcC0+dGhyZWFkLmNzcl9ldWVuOwo+ID4gICAgICAgICAgICAg ICAgIGNoaWxkcmVncy0+Y3NyX2NybWQgPSBwLT50aHJlYWQuY3NyX2NybWQ7Cj4gPiBAQCAtMTgy LDggKzIwNCw4IEBAIGludCBjb3B5X3RocmVhZChzdHJ1Y3QgdGFza19zdHJ1Y3QgKnAsIGNvbnN0 IHN0cnVjdCBrZXJuZWxfY2xvbmVfYXJncyAqYXJncykKPiA+ICAgICAgICAgICAgICAgICBjaGls ZHJlZ3MtPnJlZ3NbM10gPSB1c3A7Cj4gPgo+ID4gICAgICAgICBwLT50aHJlYWQucmVnMDMgPSAo dW5zaWduZWQgbG9uZykgY2hpbGRyZWdzOwo+ID4gLSAgICAgICBwLT50aHJlYWQucmVnMDEgPSAo dW5zaWduZWQgbG9uZykgcmV0X2Zyb21fZm9yazsKPiA+IC0gICAgICAgcC0+dGhyZWFkLnNjaGVk X3JhID0gKHVuc2lnbmVkIGxvbmcpIHJldF9mcm9tX2Zvcms7Cj4gPiArICAgICAgIHAtPnRocmVh ZC5yZWcwMSA9ICh1bnNpZ25lZCBsb25nKSByZXRfZnJvbV9mb3JrX2FzbTsKPiA+ICsgICAgICAg cC0+dGhyZWFkLnNjaGVkX3JhID0gKHVuc2lnbmVkIGxvbmcpIHJldF9mcm9tX2ZvcmtfYXNtOwo+ ID4KPiA+ICAgICAgICAgLyoKPiA+ICAgICAgICAgICogTmV3IHRhc2tzIGxvc2UgcGVybWlzc2lv biB0byB1c2UgdGhlIGZwdS4gVGhpcyBhY2NlbGVyYXRlcyBjb250ZXh0Cj4gPgo+ID4gLS0KPiA+ IDIuNDMuMAo+ID4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlz Y3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 240E121B8F2 for ; Fri, 24 Jan 2025 18:28:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737743335; cv=none; b=d3Icj/Txqi3r5E/dJXV5gBQP6zmnVzQTQz7KszfZvEFjT6yuk+TQp/fpQI4/AmNod8BHasFkfIYUWY0+DMRaNNG3KqleL5PEkNl+IHdkRDBfCvoBaISGx9b8kUkbrJiQKdzAEYQez0ioV5DVInCHwlS8McsunRSC+VK8bF5Bt+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737743335; c=relaxed/simple; bh=e7novaT/1nBh0GJFAywGIHyXlsgrNo1ecH1o9NzCRss=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f41djMU9fy0qsGs0Qi5st2GL8t05DfvdJZJ+tcsRueWdCzkWWMuQmpV8IAmeMGPsKcjgB2BrGpqh+eGfQ2OC2jDrxVbiCDkgZeoNE+rLQOt9c9IcJqzSF9+sLexd+dLJ2iZPN4a/pjb2iTSftHo9H0cKQ4JigQrCQfItN0LP7L0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=rFW0VuxW; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="rFW0VuxW" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2ef6c56032eso3400318a91.2 for ; Fri, 24 Jan 2025 10:28:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1737743333; x=1738348133; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=8mi8VPKnc/rijmPRv6U/IJSuAJ48E0dl7KypEOb/XOU=; b=rFW0VuxWaH+Pb//zMEvCQIl1zpuFlYaaP2IC84sp99TAV5ZkcaWzQLjDF45JAlPYeU 4hreVUty2D80gQADhOEeqbrXs/iWpnUVroPl/uXOVaXAtfEaSjZd79EN7w2mL2NTYJ5S rrkbtV9o4/s0CiclZkz+nzY+ySvHUQubcuT2NGyz7v2CPxEDYhXiF3J5PxP+liO9O3tH gGbjLR015PbdyhxRNuQigR2QDz6lCkYqfVoXU7pWHkHtWwsi2dTVZbi3nsgahV3015/N FeDZjPux16AaFv8N69VFMhGjz/Hf6SJC+HIhYFyHYx1SbCwUBMnQvhqxIHdYRTRxa7XV D2KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737743333; x=1738348133; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8mi8VPKnc/rijmPRv6U/IJSuAJ48E0dl7KypEOb/XOU=; b=AwGepvEq2mlnV6xuD8iUSYQT2rQR8wQiznxyWibPZTvqqR3/plFtO2EU+Aolt9EyHW AJbPlihXAHPam+ZUEyv68dRgK+o/lyt/jOSOhUo+7cym45yoRz48w0rAk5UVsEZ2zmLp y1faBCn+9lumpoCANG9dYDbTFFTuwA4nCGu/1oEiU6RCG5fwCqM2EqFAved5HrsA5WOG NTshQ89E0JYnmzIpKGZZJPbLrAZO0RZ00KU80HJLgQcoRuLwbkHNw7/nufFH+7KG8mFK azaoU9KJabiAJmRiGpyHLu4JtKUIDvKOv+ih7zuf12rB0wHAF34r8OYqZtha117SguJW ItGQ== X-Forwarded-Encrypted: i=1; AJvYcCV0fqOOi/KSHwf27V6MX33y66s1sK/jYjiGz0KEwf3eYrM5mzuYhlPPjFBe1Qo3bXiibEFijzHcZOE=@lists.linux.dev X-Gm-Message-State: AOJu0YwMOpuX+3DARet9pHa+nFgNa1DSF5sIcKz09SbE9nn62LM6V4/L XEeteu+szTbJSSNba27hvF6hAATxgjRAguDCX/Ldg+3IvRkS/I2u2CNKuvWluvY= X-Gm-Gg: ASbGncvdMGItDQX+ZQpsXBMeL62TkV8ClcR5NHfiDFHgrRgGev6/vo8hicB46pPrvVh rIyPfBDq6vRS9XcUsMsV+p9YwRHxE0MqtJDGPHSqP4fBjJCPnnPUOTv47PuMzxTWXLNJpSiV2i3 foTchwEljrIo1m9q7QCahFAn9A0aWCuPzVNtwT4qUBUffUibLMK5srSPXQiPAJIxhgXc8QGw1CX vVXDKF9zaW4/FF9KfbLIH97zfGMxCg9Zrj5pOvxiPAdXXwtwe1S5/1/CxDKX72V07NVm1eXqDA= X-Google-Smtp-Source: AGHT+IHA4N16HWh6D6ociCzA4jkBLKWzl7eCVyJWgy/BQ7/q5B7t82MMNw4lNH/Bv7YLi+Hi+jI30g== X-Received: by 2002:a17:90a:c888:b0:2f4:f7f8:fc8a with SMTP id 98e67ed59e1d1-2f782d8cd4emr49337076a91.33.1737743333401; Fri, 24 Jan 2025 10:28:53 -0800 (PST) Received: from ghost ([2601:647:6700:64d0:63b:8ac9:503a:b81d]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f7ffa76d1csm2055339a91.32.2025.01.24.10.28.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 10:28:52 -0800 (PST) Date: Fri, 24 Jan 2025 10:28:50 -0800 From: Charlie Jenkins To: Huacai Chen Cc: Paul Walmsley , Palmer Dabbelt , WANG Xuerui , Thomas Gleixner , Peter Zijlstra , Andy Lutomirski , Alexandre Ghiti , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev Subject: Re: [PATCH v2 3/4] loongarch: entry: Migrate ret_from_fork() to C Message-ID: References: <20250123-riscv_optimize_entry-v2-0-7c259492d508@rivosinc.com> <20250123-riscv_optimize_entry-v2-3-7c259492d508@rivosinc.com> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jan 24, 2025 at 05:05:21PM +0800, Huacai Chen wrote: > Hi, Charlie, > > On Fri, Jan 24, 2025 at 3:15 AM Charlie Jenkins wrote: > > > > Loongarch is the only architecture that calls > We usually use "LoongArch" instead of "loongarch" or "Loongarch". > > > syscall_exit_to_user_mode() from asm. Move the call into C so that this > > function can be inlined across all architectures. > > > > Signed-off-by: Charlie Jenkins > > --- > > arch/loongarch/include/asm/asm-prototypes.h | 5 +++++ > > arch/loongarch/include/asm/switch_to.h | 8 +++++++ > > arch/loongarch/kernel/entry.S | 22 +++++++++---------- > > arch/loongarch/kernel/process.c | 34 ++++++++++++++++++++++++----- > > 4 files changed, 51 insertions(+), 18 deletions(-) > > > > diff --git a/arch/loongarch/include/asm/asm-prototypes.h b/arch/loongarch/include/asm/asm-prototypes.h > > index 51f224bcfc654228ae423e9a066b25b35102a5b9..0195d4309fd29f94664d5f34247198c769033b1b 100644 > > --- a/arch/loongarch/include/asm/asm-prototypes.h > > +++ b/arch/loongarch/include/asm/asm-prototypes.h > > @@ -12,3 +12,8 @@ __int128_t __ashlti3(__int128_t a, int b); > > __int128_t __ashrti3(__int128_t a, int b); > > __int128_t __lshrti3(__int128_t a, int b); > > #endif > > + > > +asmlinkage void noinstr __no_stack_protector ret_from_kernel_thread(struct task_struct *prev, > > + struct pt_regs *regs, > > + int (*fn)(void *), > > + void *fn_arg); > It is a little strange that we only need to declare > ret_from_kernel_thread() but not ret_from_fork(). Just an oversight by me, thank you for pointing that out. > > > diff --git a/arch/loongarch/include/asm/switch_to.h b/arch/loongarch/include/asm/switch_to.h > > index 5b225aff3ba21aa06d0713bc8e73e1b941389630..a1c5576f1fd145670e13038bec6dd390486099ab 100644 > > --- a/arch/loongarch/include/asm/switch_to.h > > +++ b/arch/loongarch/include/asm/switch_to.h > > @@ -26,6 +26,14 @@ extern asmlinkage struct task_struct *__switch_to(struct task_struct *prev, > > struct task_struct *next, struct thread_info *next_ti, > > void *sched_ra, void *sched_cfa); > > > > +void noinstr __no_stack_protector ret_from_kernel_thread(struct task_struct *prev, > > + struct pt_regs *regs, > > + int (*fn)(void *), > > + void *fn_arg); > > + > > +void noinstr __no_stack_protector ret_from_fork(struct task_struct *prev, > > + struct pt_regs *regs); > > + > I prefer alpha-betical order, which means put ret_from_fork() before > ret_from_kernel_thread(). Makes sense! > > > /* > > * For newly created kernel threads switch_to() will return to > > * ret_from_kernel_thread, newly created user threads to ret_from_fork. > > diff --git a/arch/loongarch/kernel/entry.S b/arch/loongarch/kernel/entry.S > > index 48e7e34e355e83eae8165957ba2eac05a8bf17df..2abc29e573810e000f2fef4646ddca0dbb80eabe 100644 > > --- a/arch/loongarch/kernel/entry.S > > +++ b/arch/loongarch/kernel/entry.S > > @@ -77,24 +77,22 @@ SYM_CODE_START(handle_syscall) > > SYM_CODE_END(handle_syscall) > > _ASM_NOKPROBE(handle_syscall) > > > > -SYM_CODE_START(ret_from_fork) > > +SYM_CODE_START(ret_from_fork_asm) > > UNWIND_HINT_REGS > > - bl schedule_tail # a0 = struct task_struct *prev > > - move a0, sp > > - bl syscall_exit_to_user_mode > > + move a1, sp > > + bl ret_from_fork > > RESTORE_STATIC > > RESTORE_SOME > > RESTORE_SP_AND_RET > > -SYM_CODE_END(ret_from_fork) > > +SYM_CODE_END(ret_from_fork_asm) > > > > -SYM_CODE_START(ret_from_kernel_thread) > > +SYM_CODE_START(ret_from_kernel_thread_asm) > > UNWIND_HINT_REGS > > - bl schedule_tail # a0 = struct task_struct *prev > > - move a0, s1 > > - jirl ra, s0, 0 > > - move a0, sp > > - bl syscall_exit_to_user_mode > > + move a1, sp > > + move a2, s0 > > + move a3, s1 > > + bl ret_from_kernel_thread > > RESTORE_STATIC > > RESTORE_SOME > > RESTORE_SP_AND_RET > > -SYM_CODE_END(ret_from_kernel_thread) > > +SYM_CODE_END(ret_from_kernel_thread_asm) > > diff --git a/arch/loongarch/kernel/process.c b/arch/loongarch/kernel/process.c > > index 6e58f65455c7ca3eae2e88ed852c8655a6701e5c..16cc949fe43443d70f1d865ce04595c2d8c1615b 100644 > > --- a/arch/loongarch/kernel/process.c > > +++ b/arch/loongarch/kernel/process.c > > @@ -14,6 +14,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -33,6 +34,7 @@ > > #include > > #include > > > > +#include > > #include > > #include > > #include > > @@ -47,6 +49,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > > > @@ -63,8 +66,9 @@ EXPORT_SYMBOL(__stack_chk_guard); > > unsigned long boot_option_idle_override = IDLE_NO_OVERRIDE; > > EXPORT_SYMBOL(boot_option_idle_override); > > > > -asmlinkage void ret_from_fork(void); > > -asmlinkage void ret_from_kernel_thread(void); > > +asmlinkage void restore_and_ret(void); > > +asmlinkage void ret_from_fork_asm(void); > > +asmlinkage void ret_from_kernel_thread_asm(void); > > > > void start_thread(struct pt_regs *regs, unsigned long pc, unsigned long sp) > > { > > @@ -138,6 +142,24 @@ int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src) > > return 0; > > } > > > > +asmlinkage void noinstr __no_stack_protector ret_from_kernel_thread(struct task_struct *prev, > > + struct pt_regs *regs, > > + int (*fn)(void *), > > + void *fn_arg) > > +{ > > + schedule_tail(prev); > > + > > + fn(fn_arg); > > + > The two blank lines can be removed, and again, I prefer alpha-betical > order, which means put ret_from_fork() before > ret_from_kernel_thread(). Will update in the next version. - Charlie > > Huacai > > > + syscall_exit_to_user_mode(regs); > > +} > > + > > +void noinstr __no_stack_protector ret_from_fork(struct task_struct *prev, struct pt_regs *regs) > > +{ > > + schedule_tail(prev); > > + syscall_exit_to_user_mode(regs); > > +} > > + > > /* > > * Copy architecture-specific thread state > > */ > > @@ -165,8 +187,8 @@ int copy_thread(struct task_struct *p, const struct kernel_clone_args *args) > > p->thread.reg03 = childksp; > > p->thread.reg23 = (unsigned long)args->fn; > > p->thread.reg24 = (unsigned long)args->fn_arg; > > - p->thread.reg01 = (unsigned long)ret_from_kernel_thread; > > - p->thread.sched_ra = (unsigned long)ret_from_kernel_thread; > > + p->thread.reg01 = (unsigned long)ret_from_kernel_thread_asm; > > + p->thread.sched_ra = (unsigned long)ret_from_kernel_thread_asm; > > memset(childregs, 0, sizeof(struct pt_regs)); > > childregs->csr_euen = p->thread.csr_euen; > > childregs->csr_crmd = p->thread.csr_crmd; > > @@ -182,8 +204,8 @@ int copy_thread(struct task_struct *p, const struct kernel_clone_args *args) > > childregs->regs[3] = usp; > > > > p->thread.reg03 = (unsigned long) childregs; > > - p->thread.reg01 = (unsigned long) ret_from_fork; > > - p->thread.sched_ra = (unsigned long) ret_from_fork; > > + p->thread.reg01 = (unsigned long) ret_from_fork_asm; > > + p->thread.sched_ra = (unsigned long) ret_from_fork_asm; > > > > /* > > * New tasks lose permission to use the fpu. This accelerates context > > > > -- > > 2.43.0 > >