Re: [PATCH -v4 next 1/4] memcg: use OFP_PEAK_UNSET instead of -1

[Roman Gushchin <roman.gushchin@linux.dev>]

On Fri, Jan 24, 2025 at 07:35:11AM +0000, Chen Ridong wrote:
> From: Chen Ridong <chenridong@huawei.com>
> 
> The 'OFP_PEAK_UNSET' has been defined, use it instead of '-1'.
> 
> Signed-off-by: Chen Ridong <chenridong@huawei.com>
> Reviewed-by: Michal Koutný <mkoutny@suse.com>
> Acked-by: David Finkel <davidf@vimeo.com>
> Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>

I think I acked it previously?

Anyway,

Acked-by: Roman Gushchin <roman.gushchin@linux.dev>

Thanks!

> ---
>  mm/memcontrol.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 46f8b372d212..05a32c860554 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -4004,7 +4004,7 @@ static ssize_t peak_write(struct kernfs_open_file *of, char *buf, size_t nbytes,
>  			WRITE_ONCE(peer_ctx->value, usage);
>  
>  	/* initial write, register watcher */
> -	if (ofp->value == -1)
> +	if (ofp->value == OFP_PEAK_UNSET)
>  		list_add(&ofp->list, watchers);
>  
>  	WRITE_ONCE(ofp->value, usage);
> -- 
> 2.34.1
>