From: "Dr. David Alan Gilbert" <dave@treblig.org>
To: Charlene.Liu@amd.com, alexander.deucher@amd.com
Cc: amd-gfx@lists.freedesktop.org
Subject: hubbub/hubp, Missing struct assignments???
Date: Sun, 2 Feb 2025 22:07:36 +0000 [thread overview]
Message-ID: <Z5_sqHaGBPIqvWk1@gallifrey> (raw)
Hi Charlene, Alex,
My scripts spotted that all 3 functions added by the commit
dbc2309cac2a ("drm/amd/display: add hubbub_init related")
are uncalled, and instead of deadcoding them, I wondered if it's
actually a simple bug and they should be assigned somewhere.
That patch also added a member dchubbub_init to struct hubbub_funcs
so perhaps 2 of them should go there, and hmm there's dcn32_hubp_funcs
for the other one???
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
reply other threads:[~2025-02-03 10:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5_sqHaGBPIqvWk1@gallifrey \
--to=dave@treblig.org \
--cc=Charlene.Liu@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.