From: Patrick Steinhardt <ps@pks.im>
To: 20250126125638.3089-1-soekkle@freenet.de
Cc: git@vger.kernel.org, gitster@pobox.com,
phillip.wood123@gmail.com, sunshine@sunshineco.com,
"Sören Krecker" <soekkle@freenet.de>
Subject: Re: [PATCH v3 4/4] commit.c: Fix type conversation warnings from msvc
Date: Mon, 27 Jan 2025 08:26:25 +0100 [thread overview]
Message-ID: <Z5c1ITUkNqB7CeHW@pks.im> (raw)
In-Reply-To: <20250126130038.3277-1-soekkle@freenet.de>
On Sun, Jan 26, 2025 at 02:00:38PM +0100, Sören Krecker wrote:
> diff --git a/commit.c b/commit.c
> index 540660359d..c9cc56bd9f 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -1530,7 +1530,7 @@ int commit_tree(const char *msg, size_t msg_len, const struct object_id *tree,
> return result;
> }
>
> -static int find_invalid_utf8(const char *buf, int len)
> +static int find_invalid_utf8(const char *buf, size_t len)
> {
> int offset = 0;
Shouldn't the type of `offset` be adjusted, as well?
Patrick
next prev parent reply other threads:[~2025-01-27 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-26 13:00 [PATCH v3 4/4] commit.c: Fix type conversation warnings from msvc Sören Krecker
2025-01-27 7:26 ` Patrick Steinhardt [this message]
2025-01-29 16:53 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5c1ITUkNqB7CeHW@pks.im \
--to=ps@pks.im \
--cc=20250126125638.3089-1-soekkle@freenet.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood123@gmail.com \
--cc=soekkle@freenet.de \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.