All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-renesas-soc@vger.kernel.org,
	"Carsten Spieß" <mail@carsten-spiess.de>,
	"Jean Delvare" <jdelvare@suse.com>,
	linux-hwmon@vger.kernel.org
Subject: Re: [PATCH RESEND] hwmon: (isl28022) Use per-client debugfs entry
Date: Mon, 27 Jan 2025 08:03:32 +0100	[thread overview]
Message-ID: <Z5cvxJoXVP5QqbEH@ninjato> (raw)
In-Reply-To: <abe834aa-4989-4480-9f68-3187e0d113ec@roeck-us.net>

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

Hi Guenter,

> > Your patch is definitely one solution, but give me a day to think more
> > about it...
> 
> Sure.

So, the results of my thinking further and looking at some other debugfs
handling resulted in: I think your patch is fine :)

> In this context, it would be great if client->debugfs was cleared if creating
> the debugfs directory failed. While debugfs functions check if the dentry
> pointer is valid, that is not the case for other kernel functions. Knowing
> that the pointer is either NULL or valid would simplify drivers (such as the
> PMBus code) which need to make that check.

Sure, we can do that. Can you add this to your patch and send it to the
lists? If possible I would like to apply it this merge-window.

Thanks for your efforts!

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-01-27  7:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 16:03 [PATCH RESEND] hwmon: (isl28022) Use per-client debugfs entry Wolfram Sang
2025-01-25 17:42 ` Guenter Roeck
2025-01-25 19:56   ` Guenter Roeck
2025-01-26 11:46     ` Wolfram Sang
2025-01-26 13:14       ` Guenter Roeck
2025-01-27  7:03         ` Wolfram Sang [this message]
2025-01-27 14:55           ` Guenter Roeck
2025-01-29 16:21 ` Guenter Roeck
2025-01-30  8:55   ` Wolfram Sang
2025-01-31  5:24     ` Guenter Roeck
2025-01-31  5:38       ` Wolfram Sang
2025-01-31  6:13         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z5cvxJoXVP5QqbEH@ninjato \
    --to=wsa+renesas@sang-engineering.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mail@carsten-spiess.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.