From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D755148838
	for <linux-kernel@vger.kernel.org>; Mon, 27 Jan 2025 15:51:13 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1737993074; cv=none; b=bDCjixpEc9DkmwD5qadXX2nnU1oyoTjif57csJ/b1Jmg/egj8YGAvLovBk12/Coe+Q3bOoq+fNGLCd+M+DDXDBk6308jQnOaicrrcQmX9OObzAXOweyBeUJkuC9fQrg5tajLIznhUuVepSed7yG9gwQv4iLi9bhsFQPnl6VE/N4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1737993074; c=relaxed/simple;
	bh=t5QKaiVamxsTCxZ5CnkxwlImTG/l0X4moys/Hqa4G/o=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=uLmYKb10PIQOOSNp+NJxMjJ6ZjuP3oG6qlVD96rPgERq2CBQOGPOPArd3EOn231Ix0SN6dvRRX1QykDPKswn9I+HS3wIO20C6/sJWP8EA+L7F+84KyvFrNIeV0K90RKQv3/KdGvt04JeocTO7F98akhrYyKyRltlpp0jvKpwwkI=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZQztIEAx; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZQztIEAx"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F3CDC4CED2;
	Mon, 27 Jan 2025 15:51:11 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1737993073;
	bh=t5QKaiVamxsTCxZ5CnkxwlImTG/l0X4moys/Hqa4G/o=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=ZQztIEAxNFFOPP3d4RboHXR2BuLzACX2rrN8obQgZgF099qvabkwPSCRr6qNSUQwG
	 pJKtuQtBa7YuawbAsa1ymikxNHhLSRQM8CR28/bOtEKyxpQAZ4cRcHOYHwHj5WoZQt
	 y1XsW6XZe1wKZvfv10csNbEPRGhioJE5oNLMDp7Rlutto5KLj2QSIrScQ1a7CLm5VN
	 en+oPYAnmXhdSlZskuy79jC8UCHxnutbPpS5yrU2HQ8fwGfA7CBtiZGjuLShIVyUid
	 QJW38khgSS2QhBtDl6aIE06jW085lRQN3bgmmY3B/n7L2yAUF0Hwx2QC1SYGVYS9dP
	 p/nNzSuAWNL2w==
Date: Mon, 27 Jan 2025 16:51:02 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Nathan Chancellor <nathan@kernel.org>, linux-kernel@vger.kernel.org,
	the arch/x86 maintainers <x86@kernel.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Peter Zijlstra <peterz@infradead.org>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [GIT PULL] x86/boot enhancements for v6.14
Message-ID: <Z5erZirOgJVBAJZ9@gmail.com>
References: <Z49Mm2FJD9Qptc5e@gmail.com>
 <Z5ARucnUgqjwBnrp@gmail.com>
 <CAHk-=wj7k9nvJn6cpa3-5Ciwn2RGyE605BMkjWE4MqnvC9E92A@mail.gmail.com>
 <CAMj1kXFOY2eEhTvy5F4MqpuE-HsGObxNJ8egXK=CYfRrH9bwSQ@mail.gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMj1kXFOY2eEhTvy5F4MqpuE-HsGObxNJ8egXK=CYfRrH9bwSQ@mail.gmail.com>


* Ard Biesheuvel <ardb@kernel.org> wrote:

> This is another example of a pattern that is simply broken and 
> guaranteed to fail when booting this kernel as a SEV-SNP guest. So I 
> hope we agree that these issues should be detected at build time, and 
> it is only the quality of the diagnostic message that you are 
> objecting to?

And I believe the fact that they are fatal messages is a problem - we 
should initially just emit (informative) warnings.

Note that in the above case 'SEV-SNP guest' is basically support for a 
niche usecase built into the kernel image, and in the vast majority of 
cases the kernel will boot and work just fine. We should not fail the 
build for breakage in a niche usecase, at least initially.

Thanks,

	Ingo