Re: [PATCH v2 3/7] iomap: refactor iter and advance continuation logic

[Christoph Hellwig <hch@infradead.org>]

On Wed, Jan 22, 2025 at 08:34:30AM -0500, Brian Foster wrote:
> +	s64 ret;
> +	bool stale = iter->iomap.flags & IOMAP_F_STALE;

Nit: I find code more redable if variables that initialized at
declaration time (especially when derived from arguments) are
before plain variable declarations.  Not a big thing here with just
two of them, but variable counts keep growing over time.

>  
> -	if (iter->iomap.length && ops->iomap_end) {
> +	if (!iter->iomap.length) {
> +		trace_iomap_iter(iter, ops, _RET_IP_);
> +		goto begin;
> +	}

This might be a chance to split trace_iomap_iter into two trace points
for the initial and following iterations?  Or maybe we shouldn't bother.

Otherwise this looks great:

Reviewed-by: Christoph Hellwig <hch@lst.de>