All of lore.kernel.org
 help / color / mirror / Atom feed
From: Slawomir Stepien <sst@poczta.fm>
To: "Jörg Sommer" <joerg.sommer@navimatix.de>
Cc: openembedded-core@lists.openembedded.org, bruce.ashfield@gmail.com
Subject: Re: [OE-core] [PATCH RESEND] kernel-yocto: fix merge_config.sh flag set when KBUILD_DEFCONFIG is used
Date: Tue, 28 Jan 2025 08:31:55 +0100	[thread overview]
Message-ID: <Z5iH6xr_ffrhXkiK@nr200> (raw)
In-Reply-To: <tymbfhiwtonqtgdulmtqdhaswoxq43asvxtizp2zeocaytipdi@5k6e2fmt22p7>

On sty 26, 2025 16:51, Jörg Sommer wrote:
> Slawomir Stepien via lists.openembedded.org schrieb am So 26. Jan, 13:43 (+0100):
> > Based on the documentation of KCONFIG_MODE[1], when we use "in-tree"
> > defconfig (the KBUILD_DEFCONFIG is set), then the alldefconfig mode
> > should be used with merge_config.sh.
> > 
> > This commit fixes the logic behind setting the flag by checking if the
> > provided defconfig file exists in the linux source tree.
> > 
> > [1] https://docs.yoctoproject.org/ref-manual/variables.html#term-KCONFIG_MODE
> > 
> > Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> > ---
> >  meta/classes-recipe/kernel-yocto.bbclass | 18 +++++++++++++++---
> >  1 file changed, 15 insertions(+), 3 deletions(-)
> > 
> > diff --git a/meta/classes-recipe/kernel-yocto.bbclass b/meta/classes-recipe/kernel-yocto.bbclass
> > index c45abf6ddc..ffda41ffc9 100644
> > --- a/meta/classes-recipe/kernel-yocto.bbclass
> > +++ b/meta/classes-recipe/kernel-yocto.bbclass
> > @@ -113,6 +113,14 @@ def get_dirs_with_fragments(d):
> >  
> >      return " ".join(extrafiles)
> >  
> > +kbuild_defconfig_exists() {
> > +	if [ -f "${S}/arch/${ARCH}/configs/${KBUILD_DEFCONFIG}" ]; then
> > +		return 0
> > +	fi
> > +
> > +	return 1
> 
> Hi,

Hi Jörg,

Thanks for all these good comments. After Bruce's comment, I will not push further this approach.

> (...)

-- 
Slawomir Stepien


  reply	other threads:[~2025-01-28  7:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-26 13:20 [PATCH RESEND] kernel-yocto: fix merge_config.sh flag set when KBUILD_DEFCONFIG is used Slawomir Stepien
2025-01-26 15:51 ` [OE-core] " Jörg Sommer
2025-01-28  7:31   ` Slawomir Stepien [this message]
2025-01-26 21:42 ` Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z5iH6xr_ffrhXkiK@nr200 \
    --to=sst@poczta.fm \
    --cc=bruce.ashfield@gmail.com \
    --cc=joerg.sommer@navimatix.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.