From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Swathi K S <swathi.ks@samsung.com>
Cc: krzk@kernel.org, robh@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
conor+dt@kernel.org, richardcochran@gmail.com,
mcoquelin.stm32@gmail.com, andrew@lunn.ch,
alim.akhtar@samsung.com, linux-fsd@tesla.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, alexandre.torgue@foss.st.com,
peppe.cavallaro@st.com, joabreu@synopsys.com,
rcsekar@samsung.com, ssiddha@tesla.com, jayati.sahu@samsung.com,
pankaj.dubey@samsung.com, ravi.patel@samsung.com,
gost.dev@samsung.com
Subject: Re: [PATCH v5 2/4] net: stmmac: dwc-qos: Add FSD EQoS support
Date: Tue, 28 Jan 2025 14:59:58 +0000 [thread overview]
Message-ID: <Z5jw7pUXEoGjLtgP@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250128102558.22459-3-swathi.ks@samsung.com>
On Tue, Jan 28, 2025 at 03:55:56PM +0530, Swathi K S wrote:
> +struct fsd_eqos_plat_data {
> + struct clk_bulk_data *clks;
> + int num_clks;
> + struct device *dev;
You only write to this, so it serves no purpose in this patch. Please
remove.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-01-28 15:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250128102707epcas5p154db286b06da942e18ffe315e4767707@epcas5p1.samsung.com>
2025-01-28 10:25 ` [PATCH v5 0/4] net: stmmac: dwc-qos: Add FSD EQoS support Swathi K S
2025-01-28 10:25 ` [PATCH v5 1/4] dt-bindings: net: Add FSD EQoS device tree bindings Swathi K S
2025-01-28 14:14 ` Krzysztof Kozlowski
2025-01-29 9:18 ` Swathi K S
2025-01-30 6:05 ` Swathi K S
2025-01-28 15:40 ` Rob Herring (Arm)
2025-01-28 15:45 ` Rob Herring
2025-01-29 9:20 ` Swathi K S
2025-01-29 12:59 ` Andrew Lunn
2025-01-28 10:25 ` [PATCH v5 2/4] net: stmmac: dwc-qos: Add FSD EQoS support Swathi K S
2025-01-28 13:48 ` Andrew Lunn
2025-01-29 9:15 ` Swathi K S
2025-01-29 13:01 ` Andrew Lunn
2025-01-28 14:59 ` Russell King (Oracle) [this message]
2025-01-29 9:20 ` Swathi K S
2025-01-28 10:25 ` [PATCH v5 3/4] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC Swathi K S
2025-01-28 10:25 ` [PATCH v5 4/4] arm64: dts: fsd: Add Ethernet support for PERIC " Swathi K S
2025-01-28 14:18 ` Krzysztof Kozlowski
2025-01-29 9:19 ` Swathi K S
2025-01-29 13:07 ` Andrew Lunn
2025-02-04 8:40 ` [PATCH v5 0/4] net: stmmac: dwc-qos: Add FSD EQoS support Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5jw7pUXEoGjLtgP@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gost.dev@samsung.com \
--cc=jayati.sahu@samsung.com \
--cc=joabreu@synopsys.com \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsd@tesla.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pankaj.dubey@samsung.com \
--cc=peppe.cavallaro@st.com \
--cc=ravi.patel@samsung.com \
--cc=rcsekar@samsung.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=ssiddha@tesla.com \
--cc=swathi.ks@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.