From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 786D6C0218D for ; Wed, 29 Jan 2025 15:08:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 04F6089A77; Wed, 29 Jan 2025 15:08:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="DJ3ckH2v"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 76FBE89A77 for ; Wed, 29 Jan 2025 15:07:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738163279; x=1769699279; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=+y84hr38iFWVj0fL4Kox4+sRBwZju1CFMNv6AFjY6xk=; b=DJ3ckH2vm6o9o/EqafDWiK6+d+Y6fZVmKPkr4yt7NOgGAhtzm4N09mUr Y+5wT1O9cgVxLveNd3XIetclLG9/eQ9Sm0xfwwuk5PE34FroqX5+cu/SW aDWJK3mYFy7ntqLEebl3QRl7pKoS+EJaqNAerMMEFkNeQ9JHSm7Js4u/j tJXhRoNOFxuxlAnVeHciWsS0ZyVG0MVzg9Xsdxvyr6TBRfiwRTj19p313 ul5lB6hj6RFLq3Xz5OqzPy7x472MNYASDY83p6sQ+tBxv8djz7LsEZeMK 3QLwITCWD/GUKrpL1KcUylbvizsGavqSWrkO7K5b/spGq/H2IEVoXBZ/v Q==; X-CSE-ConnectionGUID: 7oZsZUB9ToqzWds6Y/6xHQ== X-CSE-MsgGUID: VqCVyu5QQiqPfQQO1hYWPg== X-IronPort-AV: E=McAfee;i="6700,10204,11330"; a="42609840" X-IronPort-AV: E=Sophos;i="6.13,243,1732608000"; d="scan'208";a="42609840" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2025 07:07:58 -0800 X-CSE-ConnectionGUID: nkO7AWjLTwWkDl9HrofDcw== X-CSE-MsgGUID: TGCOo1fZTbSWWamEbL0P0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,243,1732608000"; d="scan'208";a="109597748" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa010.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2025 07:07:56 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1td9fV-00000006Prg-0P2q; Wed, 29 Jan 2025 17:07:53 +0200 Date: Wed, 29 Jan 2025 17:07:52 +0200 From: Andy Shevchenko To: Marek Szyprowski Cc: Mark Brown , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Dmitry Baryshkov , DRI mailing list Subject: Re: [PATCH v3 1/1] regmap: Synchronize cache for the page selector Message-ID: References: <8a7581e4-6422-4d77-8027-02df0d7da489@samsung.com> <42fe4488-0ff2-4b92-ae11-cce1664a7176@samsung.com> <6b4cba29-786c-4999-ac1d-27b3e4cea6f8@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 28, 2025 at 06:43:26PM +0200, Andy Shevchenko wrote: > On Tue, Jan 28, 2025 at 05:08:08PM +0100, Marek Szyprowski wrote: > > On 21.01.2025 14:29, Andy Shevchenko wrote: > > > On Tue, Jan 21, 2025 at 08:33:09AM +0100, Marek Szyprowski wrote: > > >> On 17.01.2025 18:28, Andy Shevchenko wrote: > > >>> On Fri, Jan 17, 2025 at 05:05:42PM +0100, Marek Szyprowski wrote: > > >>> > > >>> Does it fail in the same way? > > >> Yes, the hw revision is reported as zero in this case: LT9611 revision: > > >> 0x00.00.00 > > > Hmm... This is very interesting! It means that the page selector is a bit > > > magical there. Dmitry, can you chime in and perhaps shed some light on this? > > > > > >>>> Does it mean that there is really a bug in the driver? > > >>> Without looking at the datasheet it's hard to say. At least what I found so far > > >>> is one page of the I²C traffic dump on Windows as an example how to use their > > >>> evaluation board and software, but it doesn't unveil the bigger picture. At > > >>> least what I think is going on here is that the programming is not so easy as > > >>> just paging. Something is more complicated there. > > >>> > > >>> But at least (and as Mark said) the most of the regmap based drivers got > > >>> the ranges wrong (so, at least there is one bug in the driver). > > >> I can do more experiments if this helps. Do you need a dump of all > > >> regmap accesses or i2c traffic from this driver? > > > It would be helpful! Traces from the failed and non-failed cases > > > till the firmware revision and chip ID reading would be enough to > > > start with. > > > > I'm sorry for the delay, I was a bit busy with other stuff. > > No problem and thanks for sharing. > > > Here are logs (all values are in hex): > > > > next-20250128 (probe broken): > > root@target:~# dmesg | grep regmap > > [   14.817604] regmap_write reg 80ee <- 1 > > [   14.823036] regmap_read reg 8100 -> 0 > > [   14.827631] regmap_read reg 8101 -> 0 > > [   14.832130] regmap_read reg 8102 -> 0 > > > > > next-20250128 + 1fd60ed1700c reverted (probe okay): > > root@target:~# dmesg | grep regmap > > [   13.565920] regmap_write reg 80ee <- 1 > > [   13.567509] regmap_read reg 8100 -> 17 > > [   13.568219] regmap_read reg 8101 -> 4 > > [   13.568909] regmap_read reg 8102 -> 93 > > Something is missing here. Like we have an identical start and an immediate > failure. If you did it via printk() approach, it's probably wrong as my patch > uses internal regmap function. Most likely you need to enable trace events > for regmap and collect those for let's say 2 seconds: > > echo 1 > ...trace events... > modprobe ... > sleep 2 > echo 0 > ...trace events... > > and dump the buffer to a file. It might have though more than needed > as some other devices might also use regmap at the same time. I don't remember > if the trace events for regmap have a device instance name field which can be > used as a filter. > > Alternatively you may also try to add a printk() into regmap core, but I don't > think it's more practical than trace events. Meanwhile, can you test this patch (on top of non-working case)? diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 2314744201b4..f799a7a80231 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -1553,8 +1553,19 @@ static int _regmap_select_page(struct regmap *map, unsigned int *reg, * virtual copy as well. */ if (page_chg && - in_range(range->selector_reg, range->window_start, range->window_len)) + in_range(range->selector_reg, range->window_start, range->window_len)) { + bool bypass, cache_only; + + bypass = map->cache_bypass; + cache_only = map->cache_only; + map->cache_bypass = false; + map->cache_only = true; + _regmap_update_bits(map, sel_register, mask, val, NULL, false); + + map->cache_bypass = bypass; + map->cache_only = cache_only; + } } *reg = range->window_start + win_offset; If I understood the case, the affected driver doesn't use case and we actually write to the selector register twice which most likely messes up the things. But this is only a theory (since we don't have the traces yet). -- With Best Regards, Andy Shevchenko