From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Support Opensource <support.opensource@diasemi.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Marcus Folkesson <marcus.folkesson@combitech.com>
Subject: Re: [PATCH] watchdog: da9052_wdt: respect TWDMIN
Date: Wed, 29 Jan 2025 16:09:32 +0100 [thread overview]
Message-ID: <Z5pErC3d7AqTq3z9@gmail.com> (raw)
In-Reply-To: <56d8a231-3af7-4e12-a08b-f7faa549c96a@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
Hello,
On Wed, Jan 29, 2025 at 06:48:04AM -0800, Guenter Roeck wrote:
> On 1/29/25 01:24, Marcus Folkesson wrote:
> > From: Marcus Folkesson <marcus.folkesson@combitech.com>
> >
> > We have to wait at least the minimium time for the watchdog window
> > (TWDMIN) before writings to the wdt register after the
> > watchdog is activated.
> > Otherwise the chip will assert TWD_ERROR and power down to reset mode.
> >
>
> This is missing a key explanation:
>
> Why does setting @min_hw_heartbeat_ms in struct watchdog_device
> not work for this driver ?
Thank you Guenter, I wasn't aware of min_hw_heartbeat_ms. I will see
if it helps.
I've also noticed that the same problem occur when, for example, I set
the timeout with wdctl and .stop is called too soon as the application
terminates.
>
> Guenter
>
Best regards,
Marcus Folkesson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-01-29 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 9:24 [PATCH] watchdog: da9052_wdt: respect TWDMIN Marcus Folkesson
2025-01-29 14:48 ` Guenter Roeck
2025-01-29 15:09 ` Marcus Folkesson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5pErC3d7AqTq3z9@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marcus.folkesson@combitech.com \
--cc=support.opensource@diasemi.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.