From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
qemu-ppc@nongnu.org, qemu-trivial@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH] overall: Remove unnecessary g_strdup_printf() calls
Date: Thu, 30 Jan 2025 10:59:01 +0000 [thread overview]
Message-ID: <Z5tbdQis_8YXStI5@redhat.com> (raw)
In-Reply-To: <20250130105743.1355-1-philmd@linaro.org>
On Thu, Jan 30, 2025 at 11:57:43AM +0100, Philippe Mathieu-Daudé wrote:
> Replace g_strdup_printf("%s", value) -> g_strdup(value)
> to avoid unnecessary string formatting.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> crypto/hash-afalg.c | 2 +-
> hw/ppc/spapr_caps.c | 2 +-
> plugins/loader.c | 2 +-
> target/i386/cpu.c | 2 +-
> trace/simple.c | 2 +-
> ui/console.c | 4 +---
> ui/gtk.c | 3 +--
> util/module.c | 2 +-
> 8 files changed, 8 insertions(+), 11 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-01-30 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 10:57 [PATCH] overall: Remove unnecessary g_strdup_printf() calls Philippe Mathieu-Daudé
2025-01-30 10:59 ` Daniel P. Berrangé [this message]
2025-01-30 12:58 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5tbdQis_8YXStI5@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.