From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1tdSGX-0002oP-W5 for mharc-qemu-trivial@gnu.org; Thu, 30 Jan 2025 05:59:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdSGW-0002n3-Cq for qemu-trivial@nongnu.org; Thu, 30 Jan 2025 05:59:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdSGU-0005od-Av for qemu-trivial@nongnu.org; Thu, 30 Jan 2025 05:59:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738234757; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0WXMxZEFMFXcDsB3N3VeC4AecD4//ZTD8grM1m77FZE=; b=MRBh//RkMIBK7B2A3LYmrYews2xXo/acOKfjsGO7WxQE58svJ1MgKnvTDwX3XNTvPjkbSg y4hGQrU6bcYvm3qzHLLK41eIS4ulGxhhityMV2YnrQqn5UNiGS9h5DLHtI3K+WbdOc6YZJ aLEYCVZkw3l5F86fcXGUDQT+4QkHBC4= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-XzDHYaMMMv2a57-UqQwfPg-1; Thu, 30 Jan 2025 05:59:11 -0500 X-MC-Unique: XzDHYaMMMv2a57-UqQwfPg-1 X-Mimecast-MFC-AGG-ID: XzDHYaMMMv2a57-UqQwfPg Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 33D8719560A3; Thu, 30 Jan 2025 10:59:09 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.184]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6910C19560A3; Thu, 30 Jan 2025 10:59:05 +0000 (UTC) Date: Thu, 30 Jan 2025 10:59:01 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Pierrick Bouvier , Stefan Hajnoczi , qemu-ppc@nongnu.org, qemu-trivial@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Subject: Re: [PATCH] overall: Remove unnecessary g_strdup_printf() calls Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20250130105743.1355-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250130105743.1355-1-philmd@linaro.org> User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.3, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2025 10:59:20 -0000 On Thu, Jan 30, 2025 at 11:57:43AM +0100, Philippe Mathieu-Daudé wrote: > Replace g_strdup_printf("%s", value) -> g_strdup(value) > to avoid unnecessary string formatting. > > Signed-off-by: Philippe Mathieu-Daudé > --- > crypto/hash-afalg.c | 2 +- > hw/ppc/spapr_caps.c | 2 +- > plugins/loader.c | 2 +- > target/i386/cpu.c | 2 +- > trace/simple.c | 2 +- > ui/console.c | 4 +--- > ui/gtk.c | 3 +-- > util/module.c | 2 +- > 8 files changed, 8 insertions(+), 11 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|