From: Christoph Hellwig <hch@infradead.org>
To: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, hch@infradead.org,
urezki@gmail.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] mm/vmalloc: Introduce vmap_file()
Date: Thu, 30 Jan 2025 23:09:13 -0800 [thread overview]
Message-ID: <Z5x3GQAzN3S-plD9@infradead.org> (raw)
In-Reply-To: <20250131001806.92349-2-vishal.moola@gmail.com>
On Thu, Jan 30, 2025 at 04:18:05PM -0800, Vishal Moola (Oracle) wrote:
> + rcu_read_lock();
> + xas_for_each(&xas, folio, last) {
This only maps folios currently in the page cache, which makes it
usefull for everything except ramfs-style purely in-memory file systems.
I.e. for the shmem use case in the second patch it fails to swap in
swapped out tmpfs folios.
> +EXPORT_SYMBOL(vmap_file);
EXPORT_SYMBOL_GPL for any advances vmalloc-layer functionality, please.
next prev parent reply other threads:[~2025-01-31 7:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 0:18 [PATCH 0/2] vmalloc: Introduce vmap_file() Vishal Moola (Oracle)
2025-01-31 0:18 ` [PATCH 1/2] mm/vmalloc: " Vishal Moola (Oracle)
2025-01-31 7:09 ` Christoph Hellwig [this message]
2025-02-03 19:23 ` Vishal Moola
2025-01-31 0:18 ` [PATCH 2/2] drm: Use vmap_file() in shmem_pin_map() Vishal Moola (Oracle)
2025-01-31 0:48 ` [PATCH 0/2] vmalloc: Introduce vmap_file() Andrew Morton
2025-02-03 18:53 ` Vishal Moola
2025-04-08 14:04 ` Brendan Jackman
2025-01-31 7:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5x3GQAzN3S-plD9@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=urezki@gmail.com \
--cc=vishal.moola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.