From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C88E61C07C9 for ; Fri, 31 Jan 2025 12:23:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738326195; cv=none; b=asq240jwmIxaSQaPDTsQvpy5KiZEDsHFnJE9qluQ4VHkVhBb4cGlt1Lzfq1jSU0/tvCgvharyMvD8zCcl7G2E4vE7vtrBhdNXIxlguTN5AGsztsLyBlW0Zsx6gztvqTkhPrG/0swUPpOC0/QNg6YyRgD6/u7YlibF2MOkM2yl3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738326195; c=relaxed/simple; bh=2qfaRTO5iG5mOYJ+RvO6+d2r0hfl5IUM+PXTysg9LQQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s7mt9ypLZ/w9ktEArCxEgQP7UrJVj0tB+OZ/l/0YweZmi/ndlnr8Jmumd+MJMA84GUXomk9by39ojih4oDYYcgU/iurBSe1sJwtE+U8kowj3rDpC0cNcB7oGv6gCIiDuJhmq0Sf8i7qRBCX2NdqHg/8uuBlp+YPvv+WCjSnSKDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.net; spf=pass smtp.mailfrom=posteo.net; dkim=pass (2048-bit key) header.d=posteo.net header.i=@posteo.net header.b=ZH/QrR6C; arc=none smtp.client-ip=185.67.36.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.net header.i=@posteo.net header.b="ZH/QrR6C" Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1B329240029 for ; Fri, 31 Jan 2025 13:23:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1738326192; bh=2qfaRTO5iG5mOYJ+RvO6+d2r0hfl5IUM+PXTysg9LQQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:From; b=ZH/QrR6CDzrfRyOcDdDH1yAPCkywXurHgOK68RDcFhhdhoq8xD44Fh+6uUGh+dwWw UBOzkZwnU3ddtLRTeU9gq3Ro9Pye5t/VIvS47EuiR6p52UR5Egh3g+CwT4bretriRL 9P1/U02bGR2CHxLzixwpkWxHjV7Zcn5ENGNT8IMCsYNGV7EkvrLpD208SD1pV3iCbJ YJpiFVWgIAxaRW3ZJfEeJKJ2G+bPdrPU3tXn5FZ2drudvcOkXIkQH7TlekHEnIB4sg LdJzUnEBnSD/51ERodPs5mvutRoWmEeP0pN0ROgbkERvi/mrMIgITeGplhnDse7Plf 4sz+RCqcxm1yg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Ykw5h1ywDz6typ; Fri, 31 Jan 2025 13:23:03 +0100 (CET) Date: Fri, 31 Jan 2025 12:23:03 +0000 From: =?utf-8?Q?J=2E_Neusch=C3=A4fer?= To: Damien Le Moal Cc: j.ne@posteo.net, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Scott Wood , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Niklas Cassel , Herbert Xu , "David S. Miller" , Lee Jones , Vinod Koul , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , =?utf-8?Q?J=2E_Neusch=C3=A4fer?= , Wim Van Sebroeck , Guenter Roeck , Mark Brown , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, linux-pci@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH 2/9] dt-bindings: ata: Convert fsl,pq-sata binding to YAML Message-ID: References: <20250126-ppcyaml-v1-0-50649f51c3dd@posteo.net> <20250126-ppcyaml-v1-2-50649f51c3dd@posteo.net> Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jan 27, 2025 at 08:22:55AM +0900, Damien Le Moal wrote: > On 1/27/25 03:58, J. Neuschäfer via B4 Relay wrote: > > From: "J. Neuschäfer" > > > > Convert the Freescale PowerQUICC SATA controller binding from text form > > to YAML. The list of compatible strings reflects current usage. > > > > Signed-off-by: J. Neuschäfer > > --- > > .../devicetree/bindings/ata/fsl,pq-sata.yaml | 59 ++++++++++++++++++++++ [...] > > +description: | > > + SATA nodes are defined to describe on-chip Serial ATA controllers. > > + Each SATA port should have its own node. > > Very unclear. The SATA nodes define ports or controllers ? Normally, a single > controller can have multiple ports, so the distinction is important. I'll change it to "Each SATA controller ...", see below. > > + cell-index: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [1, 2, 3, 4] > > + description: | > > + 1 for controller @ 0x18000 > > + 2 for controller @ 0x19000 > > + 3 for controller @ 0x1a000 > > + 4 for controller @ 0x1b000 > > Are you sure these are different controllers ? Are they not different ports of > the same controller ? Given that the previous text description define this as > "controller index", I suspect these are the port offsets and you SATA nodes > define ports, and not controllers. They have no shared registers, and each instance has the same register set (at a different base address). The MPC8315E reference manual (for example) documents them as: SATA 1 Controller—Block Base Address 0x1_8000 SATA 2 Controller—Block Base Address 0x1_9000 (table A.24 Serial ATA (SATA) Controller) Section 15.2 Command Operation implies that each SATA controller supports a single port: The SATA controller maintains a queue consisting of up to 16 commands. These commands can be distributed to a single attached device or, if the system contains a port multiplier, over each of the attached devices. So, in conclusion, I'm fairly sure "controller" is the right description. Best regards, J. Neuschäfer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69AE4C0218F for ; Fri, 31 Jan 2025 12:23:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JH3iX/E+63LtSuZiCiS5yA3MXactRHkTafOZnO+7I/g=; b=3t8xhuejt3shjk RarljBCNyWxsDDMFzD+pOI3qWHgHCVH1jp47SjLRD7nsj35d7REg1i1+bL0tYI1xOJgU8q0FvvtX5 8Re2dvrPBndZ31yL9u1LwGihY7/LQEIaBzlNtGrs5Xj4Puap2Fg/j8QWPR9QWI3UkJlEtH0iYWH/e +B7Q89wIs5jwOAmvleyHV7hxLUfX83ERxUViC9okwMwDNR1mapTRV7Wct8Dv3X0YvpVqkZ29UMfOc IG3OfLZJHQexfnoBiphxKZOwomzmXUf6omAjGsxaRgzqpIpEBOmhpUOK5A+JPfdgJcWmuUASixeBh HQm38osBQLnYa0gM/xyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdq3M-0000000Aara-1J0S; Fri, 31 Jan 2025 12:23:20 +0000 Received: from mout02.posteo.de ([185.67.36.66]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdq3J-0000000AarB-43PH for linux-mtd@lists.infradead.org; Fri, 31 Jan 2025 12:23:19 +0000 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id AE403240101 for ; Fri, 31 Jan 2025 13:23:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1738326193; bh=2qfaRTO5iG5mOYJ+RvO6+d2r0hfl5IUM+PXTysg9LQQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:From; b=FsS9KPX3k9YpNJzPDrCitVL7pEQscFI1jh9lobTa3Zb6etDLtErtKy4x4VQD3caIZ lVy3QSMJhZIsPr0Ef77KnJE7XnxmqZcnEydj0ytqGOPyLtFqg3Wus0QyjXZuIONKlO kBA7nltro0sEpF6tSMpDEj3rUexXBoDkVZCpEf3gmnKKbA1VGN3nr1rfh2C1URv/am MfbTqYgijwBeO3QZDy0wuM3OYOS7v2e4/gMGjpooQzerAqzXqIoDmG0bhxXopkpXxX SiV5SwJhoBkXtt0ewcxJJbi0DYQ1GdvFBDKsnHx7aT5/Mffw+/s2Y1lKtPxv27Aquy d88uSSCOnzmWA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Ykw5h1ywDz6typ; Fri, 31 Jan 2025 13:23:03 +0100 (CET) Date: Fri, 31 Jan 2025 12:23:03 +0000 From: =?utf-8?Q?J=2E_Neusch=C3=A4fer?= To: Damien Le Moal Cc: j.ne@posteo.net, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Scott Wood , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Niklas Cassel , Herbert Xu , "David S. Miller" , Lee Jones , Vinod Koul , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , =?utf-8?Q?J=2E_Neusch=C3=A4fer?= , Wim Van Sebroeck , Guenter Roeck , Mark Brown , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, linux-pci@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH 2/9] dt-bindings: ata: Convert fsl,pq-sata binding to YAML Message-ID: References: <20250126-ppcyaml-v1-0-50649f51c3dd@posteo.net> <20250126-ppcyaml-v1-2-50649f51c3dd@posteo.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250131_042318_293070_B776D816 X-CRM114-Status: GOOD ( 17.22 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKYW4gMjcsIDIwMjUgYXQgMDg6MjI6NTVBTSArMDkwMCwgRGFtaWVuIExlIE1vYWwg d3JvdGU6Cj4gT24gMS8yNy8yNSAwMzo1OCwgSi4gTmV1c2Now6RmZXIgdmlhIEI0IFJlbGF5IHdy b3RlOgo+ID4gRnJvbTogIkouIE5ldXNjaMOkZmVyIiA8ai5uZUBwb3N0ZW8ubmV0Pgo+ID4gCj4g PiBDb252ZXJ0IHRoZSBGcmVlc2NhbGUgUG93ZXJRVUlDQyBTQVRBIGNvbnRyb2xsZXIgYmluZGlu ZyBmcm9tIHRleHQgZm9ybQo+ID4gdG8gWUFNTC4gVGhlIGxpc3Qgb2YgY29tcGF0aWJsZSBzdHJp bmdzIHJlZmxlY3RzIGN1cnJlbnQgdXNhZ2UuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IEouIE5l dXNjaMOkZmVyIDxqLm5lQHBvc3Rlby5uZXQ+Cj4gPiAtLS0KPiA+ICAuLi4vZGV2aWNldHJlZS9i aW5kaW5ncy9hdGEvZnNsLHBxLXNhdGEueWFtbCAgICAgICB8IDU5ICsrKysrKysrKysrKysrKysr KysrKysKWy4uLl0KPiA+ICtkZXNjcmlwdGlvbjogfAo+ID4gKyAgU0FUQSBub2RlcyBhcmUgZGVm aW5lZCB0byBkZXNjcmliZSBvbi1jaGlwIFNlcmlhbCBBVEEgY29udHJvbGxlcnMuCj4gPiArICBF YWNoIFNBVEEgcG9ydCBzaG91bGQgaGF2ZSBpdHMgb3duIG5vZGUuCj4gCj4gVmVyeSB1bmNsZWFy LiBUaGUgU0FUQSBub2RlcyBkZWZpbmUgcG9ydHMgb3IgY29udHJvbGxlcnMgPyBOb3JtYWxseSwg YSBzaW5nbGUKPiBjb250cm9sbGVyIGNhbiBoYXZlIG11bHRpcGxlIHBvcnRzLCBzbyB0aGUgZGlz dGluY3Rpb24gaXMgaW1wb3J0YW50LgoKSSdsbCBjaGFuZ2UgaXQgdG8gIkVhY2ggU0FUQSBjb250 cm9sbGVyIC4uLiIsIHNlZSBiZWxvdy4KCgo+ID4gKyAgY2VsbC1pbmRleDoKPiA+ICsgICAgJHJl ZjogL3NjaGVtYXMvdHlwZXMueWFtbCMvZGVmaW5pdGlvbnMvdWludDMyCj4gPiArICAgIGVudW06 IFsxLCAyLCAzLCA0XQo+ID4gKyAgICBkZXNjcmlwdGlvbjogfAo+ID4gKyAgICAgIDEgZm9yIGNv bnRyb2xsZXIgQCAweDE4MDAwCj4gPiArICAgICAgMiBmb3IgY29udHJvbGxlciBAIDB4MTkwMDAK PiA+ICsgICAgICAzIGZvciBjb250cm9sbGVyIEAgMHgxYTAwMAo+ID4gKyAgICAgIDQgZm9yIGNv bnRyb2xsZXIgQCAweDFiMDAwCj4gCj4gQXJlIHlvdSBzdXJlIHRoZXNlIGFyZSBkaWZmZXJlbnQg Y29udHJvbGxlcnMgPyBBcmUgdGhleSBub3QgZGlmZmVyZW50IHBvcnRzIG9mCj4gdGhlIHNhbWUg Y29udHJvbGxlciA/IEdpdmVuIHRoYXQgdGhlIHByZXZpb3VzIHRleHQgZGVzY3JpcHRpb24gZGVm aW5lIHRoaXMgYXMKPiAiY29udHJvbGxlciBpbmRleCIsIEkgc3VzcGVjdCB0aGVzZSBhcmUgdGhl IHBvcnQgb2Zmc2V0cyBhbmQgeW91IFNBVEEgbm9kZXMKPiBkZWZpbmUgcG9ydHMsIGFuZCBub3Qg Y29udHJvbGxlcnMuCgpUaGV5IGhhdmUgbm8gc2hhcmVkIHJlZ2lzdGVycywgYW5kIGVhY2ggaW5z dGFuY2UgaGFzIHRoZSBzYW1lIHJlZ2lzdGVyCnNldCAoYXQgYSBkaWZmZXJlbnQgYmFzZSBhZGRy ZXNzKS4KClRoZSBNUEM4MzE1RSByZWZlcmVuY2UgbWFudWFsIChmb3IgZXhhbXBsZSkgZG9jdW1l bnRzIHRoZW0gYXM6CgoJU0FUQSAxIENvbnRyb2xsZXLigJRCbG9jayBCYXNlIEFkZHJlc3MgMHgx XzgwMDAKCVNBVEEgMiBDb250cm9sbGVy4oCUQmxvY2sgQmFzZSBBZGRyZXNzIDB4MV85MDAwCgoo dGFibGUgQS4yNCBTZXJpYWwgQVRBIChTQVRBKSBDb250cm9sbGVyKQoKU2VjdGlvbiAxNS4yIENv bW1hbmQgT3BlcmF0aW9uIGltcGxpZXMgdGhhdCBlYWNoIFNBVEEgY29udHJvbGxlcgpzdXBwb3J0 cyBhIHNpbmdsZSBwb3J0OgoKCVRoZSBTQVRBIGNvbnRyb2xsZXIgbWFpbnRhaW5zIGEgcXVldWUg Y29uc2lzdGluZyBvZiB1cCB0byAxNgoJY29tbWFuZHMuIFRoZXNlIGNvbW1hbmRzIGNhbiBiZSBk aXN0cmlidXRlZCB0byBhIHNpbmdsZSBhdHRhY2hlZAoJZGV2aWNlIG9yLCBpZiB0aGUgc3lzdGVt IGNvbnRhaW5zIGEgcG9ydCBtdWx0aXBsaWVyLCBvdmVyIGVhY2gKCW9mIHRoZSBhdHRhY2hlZCBk ZXZpY2VzLgoKU28sIGluIGNvbmNsdXNpb24sIEknbSBmYWlybHkgc3VyZSAiY29udHJvbGxlciIg aXMgdGhlIHJpZ2h0IGRlc2NyaXB0aW9uLgoKCkJlc3QgcmVnYXJkcywKSi4gTmV1c2Now6RmZXIK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpM aW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg==