From: Raag Jadav <raag.jadav@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-xe@lists.freedesktop.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Francois Dugast" <francois.dugast@intel.com>,
"Matthew Auld" <matthew.auld@intel.com>,
"Daniele Ceraolo Spurio" <daniele.ceraolospurio@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Subject: Re: [PATCH v4 01/13] drm/xe: Add callback support for driver remove
Date: Wed, 12 Feb 2025 23:19:22 +0200 [thread overview]
Message-ID: <Z60QWgI68CS8TflK@black.fi.intel.com> (raw)
In-Reply-To: <20250212193600.475089-2-lucas.demarchi@intel.com>
On Wed, Feb 12, 2025 at 11:35:48AM -0800, Lucas De Marchi wrote:
> xe device probe uses devm cleanup in most places. However there are a
> few cases where this is not possible: when the driver interacts with
> component add/del. In that case, the resource group would be cleanup
> while the entire device resources are in the process of cleanup. One
> example is the xe_gsc_proxy and display using that to interact with mei
> and audio.
>
> Add a callback-based remove so the exception doesn't make the probe
> use multiple error handling styles.
>
> v2: Change internal API to mimic the devm API. This will make it easier
> to migrate in future when devm can be used.
Which means we'd like to go back to devm action someday, or is that even
possible? Assuming it is, and still worth it, why not try to do that
instead?
Raag
next prev parent reply other threads:[~2025-02-12 21:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 19:35 [PATCH v4 00/13] Cleanup error handling on probe Lucas De Marchi
2025-02-12 19:35 ` [PATCH v4 01/13] drm/xe: Add callback support for driver remove Lucas De Marchi
2025-02-12 20:01 ` Rodrigo Vivi
2025-02-12 20:11 ` Lucas De Marchi
2025-02-14 20:55 ` Lucas De Marchi
2025-02-12 21:19 ` Raag Jadav [this message]
2025-02-12 21:28 ` Lucas De Marchi
2025-02-13 4:41 ` Raag Jadav
2025-02-12 19:35 ` [PATCH v4 02/13] drm/xe: Fix xe_display_fini() calls Lucas De Marchi
2025-02-12 19:35 ` [PATCH v4 03/13] drm/xe: Fix error handling in xe_irq_install() Lucas De Marchi
2025-02-12 19:35 ` [PATCH v4 04/13] drm/xe: Fix xe_tile_init_noalloc() error propagation Lucas De Marchi
2025-02-12 19:35 ` [PATCH v4 05/13] drm/xe: Stop ignoring errors from xe_ttm_stolen_mgr_init() Lucas De Marchi
2025-02-12 19:35 ` [PATCH v4 06/13] drm/xe: Remove leftover pxp comment Lucas De Marchi
2025-02-12 19:35 ` [PATCH v4 07/13] drm/xe: Cleanup unwind of gt initialization Lucas De Marchi
2025-02-12 19:35 ` [PATCH v4 08/13] drm/xe: Cleanup extra calls to xe_hw_fence_irq_finish() Lucas De Marchi
2025-02-12 19:35 ` [PATCH v4 09/13] drm/xe/oa: Move fini to xe_oa Lucas De Marchi
2025-02-12 19:35 ` [PATCH v4 10/13] drm/xe: Move drm_dev_unplug() out of display function Lucas De Marchi
2025-02-12 19:35 ` [PATCH v4 11/13] drm/xe/oa: Handle errors in xe_oa_register() Lucas De Marchi
2025-02-12 19:35 ` [PATCH v4 12/13] drm/xe/pmu: Fail probe if xe_pmu_register() fails Lucas De Marchi
2025-02-12 19:36 ` [PATCH v4 13/13] drm/xe/hwmon: Stop ignoring errors on probe Lucas De Marchi
2025-02-12 23:04 ` ✓ CI.Patch_applied: success for Cleanup error handling on probe (rev4) Patchwork
2025-02-12 23:05 ` ✓ CI.checkpatch: " Patchwork
2025-02-12 23:07 ` ✗ CI.KUnit: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z60QWgI68CS8TflK@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=francois.dugast@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.auld@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.