From: Vinod Koul <vkoul@kernel.org>
To: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
pierre-louis.bossart@linux.dev, bard.liao@intel.com
Subject: Re: [PATCH 2/2] Revert "soundwire: intel_auxdevice: start the bus at default frequency"
Date: Thu, 13 Feb 2025 21:45:33 +0530 [thread overview]
Message-ID: <Z64apTrlAbvUDQLx@vaman> (raw)
In-Reply-To: <20250205074232.87537-3-yung-chuan.liao@linux.intel.com>
On 05-02-25, 15:42, Bard Liao wrote:
> Now, we can support more than 1 soundwire bus clock frequency.
>
> This reverts commit c326356188f1dc2d7a2c55b30dac6a8b76087bc6.
Pls use full patch title and not just the sha
>
> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
> ---
> drivers/soundwire/intel_auxdevice.c | 21 ---------------------
> 1 file changed, 21 deletions(-)
>
> diff --git a/drivers/soundwire/intel_auxdevice.c b/drivers/soundwire/intel_auxdevice.c
> index b34b897400fc..5ea6399e6c9b 100644
> --- a/drivers/soundwire/intel_auxdevice.c
> +++ b/drivers/soundwire/intel_auxdevice.c
> @@ -243,30 +243,9 @@ static int sdw_master_read_intel_prop(struct sdw_bus *bus)
>
> static int intel_prop_read(struct sdw_bus *bus)
> {
> - struct sdw_master_prop *prop;
> -
> /* Initialize with default handler to read all DisCo properties */
> sdw_master_read_prop(bus);
>
> - /*
> - * Only one bus frequency is supported so far, filter
> - * frequencies reported in the DSDT
> - */
> - prop = &bus->prop;
> - if (prop->clk_freq && prop->num_clk_freq > 1) {
> - unsigned int default_bus_frequency;
> -
> - default_bus_frequency =
> - prop->default_frame_rate *
> - prop->default_row *
> - prop->default_col /
> - SDW_DOUBLE_RATE_FACTOR;
> -
> - prop->num_clk_freq = 1;
> - prop->clk_freq[0] = default_bus_frequency;
> - prop->max_clk_freq = default_bus_frequency;
> - }
> -
> /* read Intel-specific properties */
> sdw_master_read_intel_prop(bus);
>
> --
> 2.43.0
--
~Vinod
next prev parent reply other threads:[~2025-02-13 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 7:42 [PATCH 0/2] soundwire: Intel: support more then 1 sdw bus clock frequency Bard Liao
2025-02-05 7:42 ` [PATCH 1/2] soundwire: cadence_master: set frame shape and divider based on actual clk freq Bard Liao
2025-02-05 7:42 ` [PATCH 2/2] Revert "soundwire: intel_auxdevice: start the bus at default frequency" Bard Liao
2025-02-13 16:15 ` Vinod Koul [this message]
2025-02-07 17:03 ` [PATCH 0/2] soundwire: Intel: support more then 1 sdw bus clock frequency Pierre-Louis Bossart
2025-02-13 16:30 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2025-01-07 1:58 [PATCH 0/2] soundwire: set frame shape and divider based on actual clk freq Bard Liao
2025-01-07 1:58 ` [PATCH 2/2] Revert "soundwire: intel_auxdevice: start the bus at default frequency" Bard Liao
2025-01-07 19:22 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z64apTrlAbvUDQLx@vaman \
--to=vkoul@kernel.org \
--cc=bard.liao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=pierre-louis.bossart@linux.dev \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.