From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FA5F245B0B for ; Thu, 13 Feb 2025 20:37:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739479043; cv=none; b=njXbDwr10/M0SluUw4im/zwn8zse4QUDjs6RPNIkB1XX/edvgFO8Ca2CYi+yScCP0ZRBM8VELlEE3mxbb2uTYVZ8OAtdmf9o8kTzNLw/o0+3X0I+Td/qypuQOsxEb2Dd+J0djUKZP6JEjRsfjwhAp/4ePhXSSNIASKPxFD7/iOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739479043; c=relaxed/simple; bh=VN2RuvBjkoJAPPb6ivIEGmI81z5fd0DOiMYmSzn4jFk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mXgsZ1r8wO+L6W6WrWqIc9LEtMvrQDmEIeQMWeTym1rU71hEv/tRAzJDYLDHLbkq6Azvc0ATQJDPY06X/ObgozTy5vPvkT5/3RxB+qWQCUorUH65a2HaqGi/X6yZaCixdbGGuToGvDx/m3MCosDNZVdnPGNmOXKov0QNClDby08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=hhOt+KBE; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="hhOt+KBE" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-6fb3a611afdso7982977b3.0 for ; Thu, 13 Feb 2025 12:37:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1739479039; x=1740083839; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VtL2Aljq7K18Ol8pwG2GMa8SAGuvgfRhHbhoMvrHKnE=; b=hhOt+KBEg2QW8NduLPuray1Ii0hdOmoy0Oj5MZHePIWozygVuAPCROoKE6BRIPXmzQ FcjE7qq4QZm18CP2gXSp/sghgp1SzPeZBF5At1X1l7NWsF4RTOqCpui5ymsW1n/ONZ8v rSHubc67FRtZQTmNlRPrCQjac3qFvB3j8idDYa1w0L76VCoqHiY+TyCxwzjWwnn8OyWS csx/DEoW5qQ/AecU2rnkNbCMj+MjCrxocf1hiWIR32b59sgvY5bPcVbXCJPixXiGcNb6 cvQuE2qBtf8h6REBEF6T13UwCScFaGGNQrEpsXoi50MXzsOvVqUCoolW8Qakeef6eqR+ Gfiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739479039; x=1740083839; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VtL2Aljq7K18Ol8pwG2GMa8SAGuvgfRhHbhoMvrHKnE=; b=fbsTI1rNCj5VrLxXgNVQDcj5GfV7pPfaVPfOLF4NQ0dnQdGM9OGW0aQ6/s0dsMCLKy joZEjhLV20yqG2w0e4nnxN9xhpDe79h15xhThs8XyJWN1+m0KrG6k+btXwIRpna6IyxQ YWg6od3kL5BzjtPZjzUuEFZbUhlWgY60QtOOohCfGCGz8B8U+mK11qAcpW7FKwB1IRkx ilaR1KLc+to6wMOceFRLUSts7P41EaiDfYJNp5MFP0MmWFIgRJqOl8y1+Zbj7oJ/OZe/ SMtVgblZhdXFCLGFWHnbg3k+qMdTbzLV4h7d7DEdzfSug4WL0uUVDecfa2dVgyE3IRSg WsFw== X-Forwarded-Encrypted: i=1; AJvYcCXHPTe0dhJFTnQ6cNQWMHDrv72hY079uh3+tXkETF6wb9JF0NzbSeFVkAsPtMboPkPeH8I=@vger.kernel.org X-Gm-Message-State: AOJu0YwECNwvd430Lc/Y7YHhBDZrKXB9OYVftMhAFPWE8sp9nfjIAWVv sDvagA1FLPfmS3eJzwnKZAhMfsLI/pttqe4QcvgRsd+zi6lmZIxMaXdwkTmjzGU= X-Gm-Gg: ASbGnctZ/tIXa9MPxxVKGmb1J2e5AGt+qV4THq1h9REOsETlxbuDV7pWJLVdV5bafbT NbOo4RA8sl7n+3qzUcERhQqoJGwt1d3eek3SmjLomfrgQsKFxA5tEeXv41y8pdVjfcjsmcvovwG pnnTIME5Q6CoFqvdbT+ymZVtMhwZ/ghyShAwzHGeMoA4RHgg9l9lYmr+NTfg2Fiivql+ytlaXir 8NiIRoE+OWVbdQjgly6St6DI8x1NONEs/q02ZBUef/LprGNK6ZeRxlFn/ATn4rFkKvYU5jMuj3a TJQ= X-Google-Smtp-Source: AGHT+IGMfdT8//izHzzVCxCUXm2NF65zwvxCB97iREjU4n/ssdZBJJcyfbQ0HsHUfaMDbqW4yx+Sxw== X-Received: by 2002:a05:690c:6181:b0:6fb:1f78:d9ee with SMTP id 00721157ae682-6fb32c7ff5emr48326527b3.15.1739479039148; Thu, 13 Feb 2025 12:37:19 -0800 (PST) Received: from ghost ([50.146.0.9]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6fb3619bd74sm4583557b3.75.2025.02.13.12.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2025 12:37:18 -0800 (PST) Date: Thu, 13 Feb 2025 12:37:16 -0800 From: Charlie Jenkins To: Quentin Monnet Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Ian Rogers , Adrian Hunter , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Josh Poimboeuf , Mykola Lysenko , Shuah Khan , Jiri Kosina , Benjamin Tissoires , Steven Rostedt , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-input@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] tools: Remove redundant quiet setup Message-ID: References: <20250210-quiet_tools-v2-0-b2f18cbf72af@rivosinc.com> <20250210-quiet_tools-v2-2-b2f18cbf72af@rivosinc.com> <21f98687-f715-449c-86f0-c095ea499450@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21f98687-f715-449c-86f0-c095ea499450@kernel.org> On Tue, Feb 11, 2025 at 12:00:49AM +0000, Quentin Monnet wrote: > 2025-02-10 10:34 UTC-0800 ~ Charlie Jenkins > > Q is exported from Makefile.include so it is not necessary to manually > > set it. > > > > Signed-off-by: Charlie Jenkins > > --- > > tools/arch/arm64/tools/Makefile | 6 ------ > > tools/bpf/Makefile | 6 ------ > > tools/bpf/bpftool/Documentation/Makefile | 6 ------ > > tools/bpf/bpftool/Makefile | 6 ------ > > tools/bpf/resolve_btfids/Makefile | 2 -- > > tools/bpf/runqslower/Makefile | 5 +---- > > tools/lib/bpf/Makefile | 13 ------------- > > tools/lib/perf/Makefile | 13 ------------- > > tools/lib/thermal/Makefile | 13 ------------- > > tools/objtool/Makefile | 6 ------ > > tools/testing/selftests/bpf/Makefile.docs | 6 ------ > > tools/testing/selftests/hid/Makefile | 2 -- > > tools/thermal/lib/Makefile | 13 ------------- > > tools/tracing/latency/Makefile | 6 ------ > > tools/tracing/rtla/Makefile | 6 ------ > > tools/verification/rv/Makefile | 6 ------ > > 16 files changed, 1 insertion(+), 114 deletions(-) > > > > > [...] > > > > diff --git a/tools/bpf/bpftool/Documentation/Makefile b/tools/bpf/bpftool/Documentation/Makefile > > index 4315652678b9f2e27e48b7815f3b9ddc70a57165..bf843f328812e10dd65a73f355f74e6825ad95b9 100644 > > --- a/tools/bpf/bpftool/Documentation/Makefile > > +++ b/tools/bpf/bpftool/Documentation/Makefile > > @@ -5,12 +5,6 @@ INSTALL ?= install > > RM ?= rm -f > > RMDIR ?= rmdir --ignore-fail-on-non-empty > > > > -ifeq ($(V),1) > > - Q = > > -else > > - Q = @ > > -endif > > - > > prefix ?= /usr/local > > mandir ?= $(prefix)/man > > man8dir = $(mandir)/man8 > > diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile > > index dd9f3ec842017f1dd24054bf3a0986d546811dc4..6ea4823b770cbbe7fd9eb7da79956cc1dae1f204 100644 > > --- a/tools/bpf/bpftool/Makefile > > +++ b/tools/bpf/bpftool/Makefile > > @@ -7,12 +7,6 @@ srctree := $(patsubst %/,%,$(dir $(srctree))) > > srctree := $(patsubst %/,%,$(dir $(srctree))) > > endif > > > > -ifeq ($(V),1) > > - Q = > > -else > > - Q = @ > > -endif > > - > > BPF_DIR = $(srctree)/tools/lib/bpf > > > > ifneq ($(OUTPUT),) > > > This is OK from bpftool's side, the GitHub mirror has a Makefile.include > included from both main and doc Makefiles, and where I can move this > definition. I am glad to hear. Thank you for helping me unify this infrastructure! - Charlie > > Acked-by: Quentin Monnet > > Thanks