Re: [PATCH] vhost-user-snd: Use virtio_get_config_size()

[Matias Ezequiel Vara Larsen <mvaralar@redhat.com>]

On Thu, Feb 13, 2025 at 04:07:47PM +0100, Philippe Mathieu-Daudé wrote:
> On 13/2/25 14:25, Matias Ezequiel Vara Larsen wrote:
> > Use virtio_get_config_size() rather than sizeof(struct
> > virtio_snd_config) for the config_size in the vhost-user-snd frontend.
> > The frontend shall rely on device features for the size of the device
> > configuration space. This fixes an issue introduced by commit ab0c7fb2
> > in which the optional field `control` is added to the virtio_snd_config
> > structure. This breaks vhost-user-device backends that do not implement
> > the `controls` field.
> > 
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2805
> > Suggested-by: Stefano Garzarella <sgarzare@redhat.com>
> > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > ---
> >   hw/virtio/vhost-user-snd.c | 18 +++++++++++++++++-
> >   1 file changed, 17 insertions(+), 1 deletion(-)
> 
> ¡¡Bien ahí!!
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 

Thanks! ;)