From: Johan Hovold <johan@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Liu Ying <victor.liu@nxp.com>
Subject: Re: [PATCH] bus: simple-pm-bus: fix forced runtime PM use
Date: Fri, 14 Feb 2025 14:27:34 +0100 [thread overview]
Message-ID: <Z69ExkCLfv_xLLUm@hovoldconsulting.com> (raw)
In-Reply-To: <CAMuHMdXD1yF65ezOmLz2ShP=gnYNNkUfTLfY8RA0m=C+WwtaVw@mail.gmail.com>
On Fri, Feb 14, 2025 at 02:16:14PM +0100, Geert Uytterhoeven wrote:
> On Fri, 14 Feb 2025 at 13:53, Johan Hovold <johan@kernel.org> wrote:
> > I didn't add a CC stable tag since this currently works, but I still
> > consider it a bug to call these helpers unconditionally when not using
> > runtime PM.
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > [ And during rc1 these callbacks were suddenly called and triggered a
> > NULL-pointer dereference as you know. [1] ]
> > [1] https://lore.kernel.org/lkml/Z6YcjFBWAVVVANf2@hovoldconsulting.com/
>
> Thanks, that was the context I needed to raise review priority ;)
>
> Perhaps Reported-by: and Closes:?
The glitch was only temporary this time and the immediate issue was
addressed by Rafael's partial revert in rc2:
https://lore.kernel.org/lkml/6137505.lOV4Wx5bFT@rjwysocki.net/
(and which has these tags).
Johan
next prev parent reply other threads:[~2025-02-14 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 10:21 [PATCH] bus: simple-pm-bus: fix forced runtime PM use Johan Hovold
2025-02-14 12:36 ` Ulf Hansson
2025-02-14 12:53 ` Johan Hovold
2025-02-14 13:16 ` Geert Uytterhoeven
2025-02-14 13:27 ` Johan Hovold [this message]
2025-02-14 13:31 ` Geert Uytterhoeven
2025-02-14 21:24 ` Rafael J. Wysocki
2025-02-17 3:15 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z69ExkCLfv_xLLUm@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan+linaro@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.