From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>
Subject: Re: [PATCH v2 for-4.20? 1/6] AMD/IOMMU: drop stray MSI enabling
Date: Mon, 3 Feb 2025 17:54:59 +0100 [thread overview]
Message-ID: <Z6D04wwl3SRIRuEJ@macbook.local> (raw)
In-Reply-To: <a5fc316b-bcd6-4570-a997-0cd15273da9f@suse.com>
On Mon, Feb 03, 2025 at 05:24:10PM +0100, Jan Beulich wrote:
> While the 2nd of the commits referenced below should have moved the call
> to amd_iommu_msi_enable() instead of adding another one, the situation
> wasn't quite right even before: It can't have done any good to enable
> MSI when no IRQ was allocated for it, yet.
>
> The other call to amd_iommu_msi_enable(), just out of patch context,
> needs to stay there until S3 resume is re-worked. For the boot path that
> call should be unnecessary, as iommu{,_maskable}_msi_startup() will have
> done it already (by way of invoking iommu_msi_unmask()).
>
> Fixes: 5f569f1ac50e ("AMD/IOMMU: allow enabling with IRQ not yet set up")
> Fixes: d9e49d1afe2e ("AMD/IOMMU: adjust setup of internal interrupt for x2APIC mode")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>
> Tested-by: Jason Andryuk <jason.andryuk@amd.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
next prev parent reply other threads:[~2025-02-03 16:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 16:22 [PATCH for-4.20 0/6] AMD/IOMMU: assorted corrections Jan Beulich
2025-02-03 16:24 ` [PATCH v2 for-4.20? 1/6] AMD/IOMMU: drop stray MSI enabling Jan Beulich
2025-02-03 16:54 ` Roger Pau Monné [this message]
2025-02-03 16:24 ` [PATCH v2 for-4.20 2/6] x86/PCI: init segments earlier Jan Beulich
2025-02-03 16:25 ` [PATCH v2 for-4.20 3/6] radix-tree: purge node allocation override hooks Jan Beulich
2025-02-03 16:29 ` Jan Beulich
2025-02-03 16:36 ` Andrew Cooper
2025-02-03 16:25 ` [PATCH v2 for-4.21 4/6] radix-tree: drop "root" parameters from radix_tree_node_{alloc,free}() Jan Beulich
2025-02-03 16:40 ` Andrew Cooper
2025-02-03 16:26 ` [PATCH v2 for-4.20? 5/6] radix-tree: introduce RADIX_TREE{,_INIT}() Jan Beulich
2025-02-03 16:48 ` Andrew Cooper
2025-02-03 16:58 ` Jan Beulich
2025-02-04 8:36 ` Jan Beulich
2025-02-04 8:45 ` Jan Beulich
2025-02-04 11:19 ` Andrew Cooper
2025-02-03 16:27 ` [PATCH v2 for-4.20? 6/6] PCI: drop pci_segments_init() Jan Beulich
2025-02-03 17:04 ` Andrew Cooper
2025-02-04 7:17 ` Jan Beulich
2025-02-03 17:18 ` Roger Pau Monné
2025-02-04 7:45 ` Jan Beulich
2025-02-04 7:51 ` Jan Beulich
2025-02-04 8:56 ` Roger Pau Monné
2025-02-04 9:53 ` Jan Beulich
2025-02-03 16:38 ` [PATCH for-4.20 0/6] AMD/IOMMU: assorted corrections Oleksii Kurochko
2025-02-03 16:55 ` Andrew Cooper
2025-02-04 7:14 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6D04wwl3SRIRuEJ@macbook.local \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=oleksii.kurochko@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.