From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E46C6C02192 for ; Mon, 3 Feb 2025 19:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1+lYy+8LxxfGooH6mJLlFRQ8iuUoemHJdG40ZRGoO0c=; b=ogqRyD0y9S9DBh dG2ihkXNPRUrnTH1OHqjGOxXxywWzJnEvSMTMuPlT9Rz1UVC5gw4rIFxKYTdfK3UAPc6mQnUzXdRW z2ATKym9EZPfwAMx5D8Zf6QNxFDe+paxfBn6DUizFZzvmfOmGuBiaPE7oYB4hnmU24t2Z3tsoAUTc v46t3peNS0wz+YewYREF2cF2+4mWHDqXAh/nS4BbMEZwYpsXTPJ3HlaZB/Q/x68is4zVc6t52wTZ2 wMGxOoKjBqlX+BHGemuyC70CF2GyhYOT7moGa5VB9CYySJeXZPlkFQziW7L+Zvd/JhxoRG8ve3DA8 879I9DoUQFZLSCSiTHeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tf2ST-0000000GUSi-3C0w; Mon, 03 Feb 2025 19:50:13 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tf2SR-0000000GUSO-25VP for linux-riscv@bombadil.infradead.org; Mon, 03 Feb 2025 19:50:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=yFHGqbxIEoUkwsAnPlyxex2jjkQB0xBfGkX7c+zLGSM=; b=KAa4nN+FmOlM7XkEq/1nxMHNm9 uVwdXEqojYJEt/LnXNf0QgTRpoq0wOdksJ4cqU25bIRlev5To0n11P3kuU5p9MdvejAy0QCkxGdvz VQiPM3WJCqZEuP6r0sK7Lxd+5xRQQJpXckOo2eB2F1DNH8STQ+g2AMh4mgpiwTPhlSFo/yb9j0420 I55PGc/AiqnjwVyUsn8lBD4hGpQ75uRlont9Dpkiqp/CwMmWGHlV1QYL/+sOsXpn/1wyrMWbiy/7c pAWjhGCF0Z3vPKjTn5PNW0WDhKMpFYBxxghRlvqt3ofGeYxcfQmfKxRk4hpN4LT4GY0hu8Slynj3o H/WYeMLA==; Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tf2SN-0000000G9g8-3s1i for linux-riscv@lists.infradead.org; Mon, 03 Feb 2025 19:50:10 +0000 Received: by mail-pl1-x642.google.com with SMTP id d9443c01a7336-2167141dfa1so83926095ad.1 for ; Mon, 03 Feb 2025 11:50:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1738612205; x=1739217005; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=yFHGqbxIEoUkwsAnPlyxex2jjkQB0xBfGkX7c+zLGSM=; b=VJJ29LvTcYJ5JcgA488Uo8Zl21mzEjRRGTvKE1ItAKuPEmVNpKE+F1aRaA5m/N0Y4F /jPvpvTERy2b+uScjv+SmQrardoDHSf/AJ42tiaa8pWEs1Mr0XYu0sObDRnuktzngiQz 2yUqckmtj6D5bF2q/mFjkYNLNNAnN4QmfVekooH/ub9zDjbW2OsN8HgDP9/3YTh9IfWR u0b1/HJuxFuUymZcxnxsRFImM8Thb0c2qKSrLJmTM+8SQwOBZb+2cg0U5c2UxHmxXMEs v7ALR+P/Hi+GFHcOZNx6dghzmWACIo3Xb45bS8pJ1+lDNlriqSmX2tISsIA34Zizk3uA wIhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738612205; x=1739217005; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yFHGqbxIEoUkwsAnPlyxex2jjkQB0xBfGkX7c+zLGSM=; b=Ii55wQdmCX0QWDkxlkJmI+bysNrQeMOf16PYlBXWp0pl/mu+UQVwq/8g9+/Eg+qzrB Oia4M6fFZ7ELGVh7T539hFYal6ec3l5KmaVRtD3IbLjLcrVmzv3zvARepp433IUJCWXD qMXJLiT34XvU4PeFZC4aXScAW80QjvLIDWSYgFfgDgyXfqK0FzOYPLDLzCXq1llNDK69 kM1e3HfqVIcEVcT0G28XVwrpcDikKOEL9RKfLVbCh1R6uy6xU6jFNBXdgj9X8W4e6ydZ 4AJjqVRrvOEHq4xSI3nqWi7aAGNeznDWonJrXiBh0ExMknM7Vy8l2DlYIzgn6Nnp2T4a atrA== X-Forwarded-Encrypted: i=1; AJvYcCVXcateTDGusD9Odqg/oglHAeBZGnNMd0AFlOoYrBBAhQLG5ExVGKWhqoCYiySn+Ke1SqrOgOGJGUSc9w==@lists.infradead.org X-Gm-Message-State: AOJu0YzDGirjtjpHxq1j1B40Zna8/iPp5lnPT/07jLiu0OKpCiKmMIj1 BEi3tWim/Vd8HveNWfQ4BiMEgD7YaGf1JHhGfVBs2gPKyHIsigmht3ODYhZsElE= X-Gm-Gg: ASbGncu4r3QTdGgzlcqijKPAAa+DojXxrhboo8HezJd0FpK0M4ZPvKv8DkjkLm42wYA 4zTSMMTkWluvw+7xf9vWLNvNXKHkSdlrrahThnbZlqFDrlzepY4h7dqlFLc/VyDE9cyRAPPUU+1 0GB3paPPHYGbYrSO+d4j9CstK2fs/Rima2x5ZaN4wVFhqMktitkWpSmbfTQeYzLPicf36+fcmQA Kvw0EqO2TaqgpMiIQ9ciKIMC707tb5e9xSbV2dc8XXZWgPcXOIBb8GFSuxZ25IDbgq+jkZS6cwm BF4zWGBR434= X-Google-Smtp-Source: AGHT+IEchQZJ+49I8J5Gk0AWuiHX7StzWjiS1tUolkAZSGk0Th2flkDcybEtCm4KVdc/Y9uGIZeKPQ== X-Received: by 2002:a17:902:d50a:b0:215:9eac:1857 with SMTP id d9443c01a7336-21f01bfe998mr1628735ad.5.1738612205293; Mon, 03 Feb 2025 11:50:05 -0800 (PST) Received: from ghost ([2601:647:6700:64d0:4f63:f9d5:2cbd:2947]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21de31f8344sm80007255ad.75.2025.02.03.11.50.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 11:50:04 -0800 (PST) Date: Mon, 3 Feb 2025 11:50:02 -0800 From: Charlie Jenkins To: Samuel Holland Cc: Conor Dooley , Aleksandar Rikalo , linux-riscv@lists.infradead.org, Paul Walmsley , Palmer Dabbelt , Albert Ou , Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Yury Norov , Rasmus Villemoes , Andrea Parri , Leonardo Bras , Guo Ren , Eric Chan , linux-kernel@vger.kernel.org, Djordje Todorovic Subject: Re: [PATCH v2] riscv: Use Zalrsc extension to implement atomic functions Message-ID: References: <20241225082412.36727-1-arikalo@gmail.com> <20250202-clammy-skewed-eb0a0fce18f1@spud> <6cac61f1-cf6d-4a43-836c-e83a0b0da096@sifive.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6cac61f1-cf6d-4a43-836c-e83a0b0da096@sifive.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250203_195008_180728_D01C2C80 X-CRM114-Status: GOOD ( 31.19 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBGZWIgMDMsIDIwMjUgYXQgMDE6MzA6NDhQTSAtMDYwMCwgU2FtdWVsIEhvbGxhbmQg d3JvdGU6Cj4gSGkgQ2hhcmxpZSwKPiAKPiBPbiAyMDI1LTAyLTAzIDE6MTIgUE0sIENoYXJsaWUg SmVua2lucyB3cm90ZToKPiA+IE9uIFN1biwgRmViIDAyLCAyMDI1IGF0IDA4OjA4OjUwUE0gKzAw MDAsIENvbm9yIERvb2xleSB3cm90ZToKPiA+PiBPbiBTYXQsIEZlYiAwMSwgMjAyNSBhdCAwMTow NDoyNVBNICswMTAwLCBBbGVrc2FuZGFyIFJpa2FsbyB3cm90ZToKPiA+Pj4gT24gRnJpLCBKYW4g MTAsIDIwMjUgYXQgNDoyM+KAr0FNIENoYXJsaWUgSmVua2lucyA8Y2hhcmxpZUByaXZvc2luYy5j b20+IHdyb3RlOgo+ID4+Pgo+ID4+Pj4+IEZyb206IENoYW8teWluZyBGdSA8Y2Z1QG1pcHMuY29t Pgo+ID4+Pj4+Cj4gPj4+Pj4gVXNlIG9ubHkgTFIvU0MgaW5zdHJ1Y3Rpb25zIHRvIGltcGxlbWVu dCBhdG9taWMgZnVuY3Rpb25zLgo+ID4+Pj4KPiA+Pj4+IEluIHRoZSBwcmV2aW91cyBwYXRjaCB5 b3UgbWVudGlvbiB0aGF0IHRoaXMgaXMgdG8gc3VwcG9ydCBNSVBTIFA4NzAwLiBDYW4KPiA+Pj4+ IHlvdSBleHBhbmQgb24gd2h5IHRoaXMgY2hhbmdlIGlzIHJlcXVpcmVkPyBUaGUgZGF0YXNoZWV0 IGF0IFsxXSBzYXlzOgo+ID4+Pj4KPiA+Pj4+ICJUaGUgUDg3MDAgY29yZSBpcyBjb25maWd1cmVk IHRvIHN1cHBvcnQgdGhlIFJWNjRHQ1piYV9aYmIgKEcgPSBJTUFGRCkKPiA+Pj4+IFN0YW5kYXJk IElTQS4gSXQgaW5jbHVkZXMgdGhlIFJWNjRJIGJhc2UgSVNBLCBNdWx0aXBseSAoTSksIEF0b21p YyAoQSksCj4gPj4+PiBTaW5nbGUtUHJlY2lzaW9uIEZsb2F0aW5nIFBvaW50IChGKSwgRG91Ymxl IChEKSwgQ29tcHJlc3NlZCAoQykgUklTQy1WCj4gPj4+PiBleHRlbnNpb25zLCBhcyB3ZWxsIGFz IHRoZSBhcyB3ZWxsIGFzIHRoZSBiaXQtbWFuaXB1bGF0aW9uIGV4dGVuc2lvbnMKPiA+Pj4+ICha YmEpIGFuZCAoWmJiKSIKPiA+Pj4+Cj4gPj4+PiBUaGUgIkEiIGV4dGVuc2lvbiBpcyBhIHBhcnQg b2YgIkciIHdoaWNoIGlzIG1vc3RseSBhc3N1bWVkIHRvIGV4aXN0IGluCj4gPj4+PiB0aGUga2Vy bmVsLiBBZGRpdGlvbmFsbHksIGhhdmluZyB0aGlzIGJlIGEgY29tcGlsYXRpb24gZmxhZyB3aWxs IGNhdXNlCj4gPj4+PiB0cmFwcyBvbiBnZW5lcmljIGtlcm5lbHMuIFdlIGdlbmVyYWxseSB0cnkg dG8gcHVzaCBldmVyeXRoaW5nIHdlIGNhbgo+ID4+Pj4gaW50byBydW50aW1lIGZlYXR1cmUgZGV0 ZWN0aW9uIHNpbmNlIHRoZXJlIGFyZSBzbyBtYW55IHBvc3NpYmxlIHZhcmlhbnRzCj4gPj4+PiBv ZiByaXNjdi4KPiA+Pj4+Cj4gPj4+PiBFeHByZXNzaW5nIG5vdCBiZWluZyBhYmxlIHRvIHBlcmZv cm0gYSBmZWF0dXJlIGxpa2UgdGhpcyBpcyBub3JtYWxseQo+ID4+Pj4gYmV0dGVyIGV4cHJlc3Nl ZCBhcyBhbiBlcnJhdGEuIFRoZW4gZ2VuZXJpYyBrZXJuZWxzIHdpbGwgYmUgYWJsZSB0bwo+ID4+ Pj4gaW5jbHVkZSB0aGlzLCBhbmQgYW55Ym9keSB3aG8gZG9lc24ndCB3YW50IHRvIGhhdmUgdGhl IGV4dHJhIG5vcHMKPiA+Pj4+IGludHJvZHVjZWQgY2FuIGRpc2FibGUgdGhlIGVycmF0YS4gQSBz aW1pbGFyIGFwcHJvYWNoIHRvIHdoYXQgSSBwb2ludGVkCj4gPj4+PiBvdXQgbGFzdCB0aW1lIHNo b3VsZCB3b3JrIGhlcmUgdG9vIChidXQgd2l0aCBtb3JlIHBsYWNlcyB0byByZXBsYWNlKQo+ID4+ Pj4gWzJdLgo+ID4+Pj4KPiA+Pj4+IFsxXSBodHRwczovL21pcHMuY29tL3dwLWNvbnRlbnQvdXBs b2Fkcy8yMDI0LzExL1A4NzAwX0RhdGFfU2hlZXQucGRmCj4gPj4+PiBbMl0gaHR0cHM6Ly9sb3Jl Lmtlcm5lbC5vcmcvbGttbC9aMi1VTmZ3Y0FRWVpxVkJVQGdob3N0L1QvCj4gPj4+Cj4gPj4+IFNv IGZhciB3ZSBoYXZlbid0IGZvdW5kIGEgd2F5IHRvIGRvIHRoaXMgdXNpbmcgZXJyYXRhLgo+ID4+ Cj4gPj4gWW91IG1lYW4gdXNpbmcgYWx0ZXJuYXRpdmVzPyBOb3QgaW1wbGVtZW50aW5nIEEsIGJ1 dCBpbnN0ZWFkCj4gPj4gaW1wbGVtZW50aW5nIFphbHJzYywgaXMgbm90IGFuIGVycmF0dW0uIEl0 J3MgYSBkZXNpZ24gZGVjaXNpb24uCj4gPiAKPiA+IFdlIGNvdWxkIGRvIHRoZSBzYW1lIHRoaW5n IHdlIGRvIHdpdGggbWlzYWxpZ25lZCBhY2Nlc3MgZGV0ZWN0aW9uIGFuZAo+ID4gcnVuIHNvbWUg aW5zdHJ1Y3Rpb25zIHRvIGRldGVybWluZSBpZiB0aGVzZSBpbnN0cnVjdGlvbnMgYXJlIGJlaW5n Cj4gPiBlbXVsYXRlZC4gIElmIHRoZXkgYXJlIGJlaW5nIGVtdWxhdGVkLCBwYXRjaCBhbGwgb2Yg dGhlIHBsYWNlcyB0byB1c2UKPiA+IHphbHJzYy4KPiAKPiBJcyB0aGUgaW1wbGljYXRpb24gaGVy ZSB0aGF0IHRoZSByaXNjdixpc2EtZXh0ZW5zaW9ucyBsaXN0IHBhc3NlZCB0byB0aGUga2VybmVs Cj4gd2lsbCBjb250YWluICJhIiwgZXZlbiB0aG91Z2ggdGhlIGhhcmR3YXJlIGRvZXMgbm90IHN1 cHBvcnQgaXQsIGJlY2F1c2UgQU1PcyBhcmUKPiBlbXVsYXRlZCBpbiBNLW1vZGU/Cj4gCj4gSWYg dGhhdCBpcyBub3QgdGhlIGNhc2UsIHRoZXJlIGlzIG5vIG5lZWQgZm9yIHJ1bnRpbWUgZGV0ZWN0 aW9uLiBUaGUgYWx0ZXJuYXRpdmUKPiBlbnRyeSBjYW4gY2hlY2sgUklTQ1ZfSVNBX0VYVF9aQUFN TyAod2hpY2ggd291bGQgYmUgaW1wbGllZCBieSBSSVNDVl9JU0FfRVhUX2EpCj4gaW4gdGhlIElT QSBiaXRtYXAgbGlrZSBub3JtYWwuCgpUaGF0IHdvdWxkIGJlIG11Y2ggYmV0dGVyISBJIHdhcyB1 bmRlciB0aGUgYXNzdW1wdGlvbiB0aGF0IHRoZSB1c2VjYXNlCmZvciB0aGlzIHBhdGNoIHdhcyB0 aGF0IHRoZXkgd2VyZSBwYXNzaW5nIGluICJhIiBhbmQgd2FudGluZyB0byBvbmx5IGdldAp6YWxy c2MuIFdlIHNob3VsZCBiZSBhYmxlIHRvIGNoZWNrClJJU0NWX0lTQV9FWFRfWkFBTU8vUklTQ1Zf SVNBX0VYVF9aQUxSU0MgdG8gZ2V0IHRoZSBpbmZvcm1hdGlvbiB3aXRob3V0CnJ1bnRpbWUgZGV0 ZWN0aW9uLgoKLSBDaGFybGllCgo+IAo+IFJlZ2FyZHMsCj4gU2FtdWVsCj4gCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5n IGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 239321D47AD for ; Mon, 3 Feb 2025 19:50:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738612208; cv=none; b=nTcD5naLXAfDH1zXISctdaiDlUlY3ygxgGmtrJMjHVOJCrSpQ1vrcwHMAXcBRnAfTWoD+4BvxK99fOfjsUAe6mHEsPlPvS/G7DOLzUj97KwwMwDiHdc+YVdA555ciECjXuh86tG5XL1JWj9NO/NiCXymmL5U9Dkam+06jOF+0Uo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738612208; c=relaxed/simple; bh=gclRStCHsv5L1K7SyfbAP9R/C91W3CfnMHQl5kZ0UJk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zh7zRo/njZKbOZfW5h2cpjJan+jRMrDS/Viy48FYtJZ8Z91wbjUh2aPWWPMMqN4CyJ9rduIO7/gxuHbzrGiy3iLE2UsRjnhY14lEWVNX5SPFFak07iiOIsVHBMi+f/M+Q0o2zJfXCGbCZdwKA5bsnp3+jxi2LW5BPoTbNNs77bk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=G8Ooq4GD; arc=none smtp.client-ip=209.85.214.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="G8Ooq4GD" Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-216395e151bso58075925ad.0 for ; Mon, 03 Feb 2025 11:50:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1738612205; x=1739217005; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=yFHGqbxIEoUkwsAnPlyxex2jjkQB0xBfGkX7c+zLGSM=; b=G8Ooq4GD1eetRp/+0eKgR+FOuoRk6cbYbFg282xiDsTfP4b56EmhkO+LJtF7De/OT3 ReG6TfpSzdwaoWGFc+XHDPZf+6AD/aRW8ERIU//h/9kfGsBLwp7e4JMNfUU9yT6b/jon GsB1bm1DuTGGg9Hu5Q05APn0nSxNXgr95d50b1VuXVUNqPL8WfPQfU9IAeQZZ9TsJNUL HoDuFEpTOt4araP4d4CjL7kmq7QMJO/3KPdv5OvjvocYUg2ed/Yz0aKHxjwtauP1DhWx TTQTnSUGnkxfAsTkuB61yfJE+DC1ktT3mW/7FK4NJADcfn0EOx7iejd8D4HPAWmrSIQQ Fq+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738612205; x=1739217005; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yFHGqbxIEoUkwsAnPlyxex2jjkQB0xBfGkX7c+zLGSM=; b=eFWYYGSrClJ4qEJCrcIeQJaRgv0CkF93eYFNvDX6RECc2YNUcektPwEWwefhMpnOMm rp4Y1XmKe5Isw5vyF9luAtNBaVPLc4+SQXbcWtcGzmHYXGUJHrPafJS0SDJ1R+MO9n3L +2wdkpALetihQ078byMEjgx+BttSKbv4agfid+y73/SBRyN2MgV3BwOa3wF0mOvPUOkJ GYo/jft1wkgvSnBYlFZVE/9uDTdyIyznLYECsKnJJf2jSbK5i+EZXm1UZjJH5igNQWLy BYbGz9ACCML1xeEjzkEExkaNtNJY73JuA9jZSo4FPzY7lp0ZBRer0arBFDcMzxOgf1j1 9a+A== X-Forwarded-Encrypted: i=1; AJvYcCUWU91cQkFfe5zzsFCIhzv2HEnZ34o7aSbfSgsILN5S3llDCjjPnpolCErIDfQNpXFbeYPbtpwUAHI/hb0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0KP8j3lDZZWRIO0ZlaSF+QCLj4M6MfMfztUk6jjXymIzPAGzX ODjzxZnMQ4LMbJgYwHc/u0zzPg1PDxCrl72O/tqfc0/BFkqSeJNNIx84ntdqI2A= X-Gm-Gg: ASbGncuoqAyiNGtO23sEwConALlbvcorbJ/lU4hM3bT2OZg/XNoM0YelYFsI4zZUoTg olKxO/8FLm3InSgjzq4MyHRZBkwR5W6Cdk3uBGju1lmt91JtJuiv+ABnPrR5BQWwLrhnFShOueg rA4v9VECedYkHhV+GPiUmzxD4cWvAkQF9Ir22zL4vkFVtqYmRaOFhjPqM7RmLXQbekemD08Z5mW D6cidbzzsKoNvcOadub/OhOJwMQnlem2VwVit5G0bShwju/q2oBSSu89k0C5IVux1OXd0N72ABI 6+dvxDWV/QE= X-Google-Smtp-Source: AGHT+IEchQZJ+49I8J5Gk0AWuiHX7StzWjiS1tUolkAZSGk0Th2flkDcybEtCm4KVdc/Y9uGIZeKPQ== X-Received: by 2002:a17:902:d50a:b0:215:9eac:1857 with SMTP id d9443c01a7336-21f01bfe998mr1628735ad.5.1738612205293; Mon, 03 Feb 2025 11:50:05 -0800 (PST) Received: from ghost ([2601:647:6700:64d0:4f63:f9d5:2cbd:2947]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21de31f8344sm80007255ad.75.2025.02.03.11.50.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 11:50:04 -0800 (PST) Date: Mon, 3 Feb 2025 11:50:02 -0800 From: Charlie Jenkins To: Samuel Holland Cc: Conor Dooley , Aleksandar Rikalo , linux-riscv@lists.infradead.org, Paul Walmsley , Palmer Dabbelt , Albert Ou , Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Yury Norov , Rasmus Villemoes , Andrea Parri , Leonardo Bras , Guo Ren , Eric Chan , linux-kernel@vger.kernel.org, Djordje Todorovic Subject: Re: [PATCH v2] riscv: Use Zalrsc extension to implement atomic functions Message-ID: References: <20241225082412.36727-1-arikalo@gmail.com> <20250202-clammy-skewed-eb0a0fce18f1@spud> <6cac61f1-cf6d-4a43-836c-e83a0b0da096@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6cac61f1-cf6d-4a43-836c-e83a0b0da096@sifive.com> On Mon, Feb 03, 2025 at 01:30:48PM -0600, Samuel Holland wrote: > Hi Charlie, > > On 2025-02-03 1:12 PM, Charlie Jenkins wrote: > > On Sun, Feb 02, 2025 at 08:08:50PM +0000, Conor Dooley wrote: > >> On Sat, Feb 01, 2025 at 01:04:25PM +0100, Aleksandar Rikalo wrote: > >>> On Fri, Jan 10, 2025 at 4:23 AM Charlie Jenkins wrote: > >>> > >>>>> From: Chao-ying Fu > >>>>> > >>>>> Use only LR/SC instructions to implement atomic functions. > >>>> > >>>> In the previous patch you mention that this is to support MIPS P8700. Can > >>>> you expand on why this change is required? The datasheet at [1] says: > >>>> > >>>> "The P8700 core is configured to support the RV64GCZba_Zbb (G = IMAFD) > >>>> Standard ISA. It includes the RV64I base ISA, Multiply (M), Atomic (A), > >>>> Single-Precision Floating Point (F), Double (D), Compressed (C) RISC-V > >>>> extensions, as well as the as well as the bit-manipulation extensions > >>>> (Zba) and (Zbb)" > >>>> > >>>> The "A" extension is a part of "G" which is mostly assumed to exist in > >>>> the kernel. Additionally, having this be a compilation flag will cause > >>>> traps on generic kernels. We generally try to push everything we can > >>>> into runtime feature detection since there are so many possible variants > >>>> of riscv. > >>>> > >>>> Expressing not being able to perform a feature like this is normally > >>>> better expressed as an errata. Then generic kernels will be able to > >>>> include this, and anybody who doesn't want to have the extra nops > >>>> introduced can disable the errata. A similar approach to what I pointed > >>>> out last time should work here too (but with more places to replace) > >>>> [2]. > >>>> > >>>> [1] https://mips.com/wp-content/uploads/2024/11/P8700_Data_Sheet.pdf > >>>> [2] https://lore.kernel.org/lkml/Z2-UNfwcAQYZqVBU@ghost/T/ > >>> > >>> So far we haven't found a way to do this using errata. > >> > >> You mean using alternatives? Not implementing A, but instead > >> implementing Zalrsc, is not an erratum. It's a design decision. > > > > We could do the same thing we do with misaligned access detection and > > run some instructions to determine if these instructions are being > > emulated. If they are being emulated, patch all of the places to use > > zalrsc. > > Is the implication here that the riscv,isa-extensions list passed to the kernel > will contain "a", even though the hardware does not support it, because AMOs are > emulated in M-mode? > > If that is not the case, there is no need for runtime detection. The alternative > entry can check RISCV_ISA_EXT_ZAAMO (which would be implied by RISCV_ISA_EXT_a) > in the ISA bitmap like normal. That would be much better! I was under the assumption that the usecase for this patch was that they were passing in "a" and wanting to only get zalrsc. We should be able to check RISCV_ISA_EXT_ZAAMO/RISCV_ISA_EXT_ZALRSC to get the information without runtime detection. - Charlie > > Regards, > Samuel >