From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org
Subject: Re: [PATCH net-next] net: warn if NAPI instance wasn't shut down
Date: Mon, 3 Feb 2025 17:48:36 -0800 [thread overview]
Message-ID: <Z6Fx9ElQJz1ql7zF@LQ3V64L9R2> (raw)
In-Reply-To: <20250203215816.1294081-1-kuba@kernel.org>
On Mon, Feb 03, 2025 at 01:58:16PM -0800, Jakub Kicinski wrote:
> Drivers should always disable a NAPI instance before removing it.
> If they don't the instance may be queued for polling.
> Since commit 86e25f40aa1e ("net: napi: Add napi_config")
> we also remove the NAPI from the busy polling hash table
> in napi_disable(), so not disabling would leave a stale
> entry there.
>
> Use of busy polling is relatively uncommon so bugs may be lurking
> in the drivers. Add an explicit warning.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> net/core/dev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Let's find out how many bugs are lurking:
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2025-02-04 1:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 21:58 [PATCH net-next] net: warn if NAPI instance wasn't shut down Jakub Kicinski
2025-02-04 1:48 ` Joe Damato [this message]
2025-02-04 5:24 ` Eric Dumazet
2025-02-05 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6Fx9ElQJz1ql7zF@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.