From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4B81215196; Tue, 4 Feb 2025 16:26:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738686364; cv=none; b=etaWw7IPUbkwZClwXfVwsXUowcWSz1PwfIaskCs7CDkaKMkobLMwU6b9p5ODkII4SjSSFeNW57SotWtj+aKvTabX2u53R6eg8BEJ6XlRNbM0pyRfSHfS5jWUC9DZjMkdi4XnE9tSB7YX3FWVFhMS0F8wt+3XjReCTpwR8CMNI9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738686364; c=relaxed/simple; bh=L54LXQnOXWaBaK5VCO3A3bjxwgajDXv30wjGTPt+098=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qrCdwDVEA4XGat2GPSvNaUtUqwyE6GEhwYCs8dJ2ppdKlTAYDLMNGNjB4ccECpjtWNME649rPyoYv/kXteMGC5DqSD4sJGeH8h0zgJGJLY83fvsD0hmeqPZIaTiMHqZZZVhw3mMATgcQHRbJe1rdS7Do0zo4zjKoSgSvsnEk+NA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=B2pPWBAh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="B2pPWBAh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DA35C4CEDF; Tue, 4 Feb 2025 16:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738686363; bh=L54LXQnOXWaBaK5VCO3A3bjxwgajDXv30wjGTPt+098=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B2pPWBAh1vII7IozOG5m4s4KE4imJgEszqsdtJdsekdCwiDT/t2ls283r81dquCQy gB1rTpS+CFvmUFelHBeZoYpCEh89ao9CHqq3XOIYDoPOEqj3+CuEcEERLhpzkoyjWB HUWB5UH+krcTGZNezD1SBnuhzPkUJZ+Gu/SSKlXOzUKJLizTPVox1e2h5VKIKl83Ty IJFA93WwuupUf57V/AjeGQSPMM9b2fbMA/1a3qU06TSqWQToSwJG8RdikVMJweUYcl KPRnZC0kmQh2NWWMqLbmehulmnBU4qVT4rtOJHvwmyvOlvTAIkWKDB79cpO+H5cnJ9 XStY6fB0R/a8Q== Date: Tue, 4 Feb 2025 16:26:01 +0000 From: Jaegeuk Kim To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 0/2 v8] add ioctl/sysfs to donate file-backed pages Message-ID: References: <20250131222914.1634961-1-jaegeuk@kernel.org> Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 02/03, Christoph Hellwig wrote: > On Fri, Jan 31, 2025 at 10:27:55PM +0000, Jaegeuk Kim wrote: > > Note, let me keep improving this patch set, while trying to get some feedbacks > > from MM and API folks from [1]. > > Please actually drive it instead of only interacting once after > I told you to. The feedback is clearly that it is a MM thing, so please > drive it forward instead of going back to the hacky file system version. I keep saying working in parallel for production. And, no worries, I won't merge this to -next until I get the feedback from the MM folks. I was waiting for a couple of weeks before bothering them, so will ping there. > > > > > If users clearly know which file-backed pages to reclaim in system view, they > > can use this ioctl() to register in advance and reclaim all at once later. > > > > I'd like to propose this API in F2FS only, since > > 1) the use-case is quite limited in Android at the moment. Once it's generall > > accepted with more use-cases, happy to propose a generic API such as fadvise. > > Please chime in, if there's any needs. > > > > 2) it's file-backed pages which requires to maintain the list of inode objects. > > I'm not sure this fits in MM tho, also happy to listen to any feedback. > > > > [1] https://lore.kernel.org/lkml/Z4qmF2n2pzuHqad_@google.com/ > > > > Change log from v7: > > - change the sysfs entry to reclaim pages in all f2fs mounts > > > > Change log from v6: > > - change sysfs entry name to reclaim_caches_kb > > > > Jaegeuk Kim (2): > > f2fs: register inodes which is able to donate pages > > f2fs: add a sysfs entry to request donate file-backed pages > > > > Jaegeuk Kim (2): > > f2fs: register inodes which is able to donate pages > > f2fs: add a sysfs entry to request donate file-backed pages > > > > Documentation/ABI/testing/sysfs-fs-f2fs | 7 ++ > > fs/f2fs/debug.c | 3 + > > fs/f2fs/f2fs.h | 14 +++- > > fs/f2fs/file.c | 60 +++++++++++++++++ > > fs/f2fs/inode.c | 14 ++++ > > fs/f2fs/shrinker.c | 90 +++++++++++++++++++++++++ > > fs/f2fs/super.c | 1 + > > fs/f2fs/sysfs.c | 63 +++++++++++++++++ > > include/uapi/linux/f2fs.h | 7 ++ > > 9 files changed, 258 insertions(+), 1 deletion(-) > > > > -- > > 2.48.1.362.g079036d154-goog > > > > > ---end quoted text--- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1119AC02194 for ; Tue, 4 Feb 2025 16:26:18 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tfLkf-0000m0-Bf; Tue, 04 Feb 2025 16:26:16 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tfLke-0000ls-1F for linux-f2fs-devel@lists.sourceforge.net; Tue, 04 Feb 2025 16:26:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ba6Xpky8Fyf3+tO4aMJ/oeHU/41orspz9L/3yBudjhI=; b=k2ud4bb/NaUYKAzKw/M1BG29LI i1BXFQEL/qKSnUoiO7QSAAhmfKwcw3C0+NaP8I2FxUajgKl1onAkgYnPp/XlEnJpAcrCwkG6qd9dK 5Dgn8K7oPNAI8pbLZhhJl8IrxeoaBhPpLMAR3rbds/PhFqZtp8H0VrvguBhCjENZekoc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ba6Xpky8Fyf3+tO4aMJ/oeHU/41orspz9L/3yBudjhI=; b=GlNFN7jWtZSNjopc7RBi9HC7Zn /bBPefeeEx5+Q7pwNdwG2lTxWkwkXGm8m63N1dBSqtw+vR2I49ebSnAwA5miANHMzxeHQK+dqr//4 +xm8AJ9mHKXd3BOWYrb8abCHf01pvwGQIfVzn1t0OJsHvSy36ddUQoUg3554r2cC4icY=; Received: from nyc.source.kernel.org ([147.75.193.91]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1tfLkc-0006U7-NP for linux-f2fs-devel@lists.sourceforge.net; Tue, 04 Feb 2025 16:26:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D3ADDA429BB; Tue, 4 Feb 2025 16:24:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DA35C4CEDF; Tue, 4 Feb 2025 16:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738686363; bh=L54LXQnOXWaBaK5VCO3A3bjxwgajDXv30wjGTPt+098=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B2pPWBAh1vII7IozOG5m4s4KE4imJgEszqsdtJdsekdCwiDT/t2ls283r81dquCQy gB1rTpS+CFvmUFelHBeZoYpCEh89ao9CHqq3XOIYDoPOEqj3+CuEcEERLhpzkoyjWB HUWB5UH+krcTGZNezD1SBnuhzPkUJZ+Gu/SSKlXOzUKJLizTPVox1e2h5VKIKl83Ty IJFA93WwuupUf57V/AjeGQSPMM9b2fbMA/1a3qU06TSqWQToSwJG8RdikVMJweUYcl KPRnZC0kmQh2NWWMqLbmehulmnBU4qVT4rtOJHvwmyvOlvTAIkWKDB79cpO+H5cnJ9 XStY6fB0R/a8Q== Date: Tue, 4 Feb 2025 16:26:01 +0000 To: Christoph Hellwig Message-ID: References: <20250131222914.1634961-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1tfLkc-0006U7-NP Subject: Re: [f2fs-dev] [PATCH 0/2 v8] add ioctl/sysfs to donate file-backed pages X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jaegeuk Kim via Linux-f2fs-devel Reply-To: Jaegeuk Kim Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 02/03, Christoph Hellwig wrote: > On Fri, Jan 31, 2025 at 10:27:55PM +0000, Jaegeuk Kim wrote: > > Note, let me keep improving this patch set, while trying to get some feedbacks > > from MM and API folks from [1]. > > Please actually drive it instead of only interacting once after > I told you to. The feedback is clearly that it is a MM thing, so please > drive it forward instead of going back to the hacky file system version. I keep saying working in parallel for production. And, no worries, I won't merge this to -next until I get the feedback from the MM folks. I was waiting for a couple of weeks before bothering them, so will ping there. > > > > > If users clearly know which file-backed pages to reclaim in system view, they > > can use this ioctl() to register in advance and reclaim all at once later. > > > > I'd like to propose this API in F2FS only, since > > 1) the use-case is quite limited in Android at the moment. Once it's generall > > accepted with more use-cases, happy to propose a generic API such as fadvise. > > Please chime in, if there's any needs. > > > > 2) it's file-backed pages which requires to maintain the list of inode objects. > > I'm not sure this fits in MM tho, also happy to listen to any feedback. > > > > [1] https://lore.kernel.org/lkml/Z4qmF2n2pzuHqad_@google.com/ > > > > Change log from v7: > > - change the sysfs entry to reclaim pages in all f2fs mounts > > > > Change log from v6: > > - change sysfs entry name to reclaim_caches_kb > > > > Jaegeuk Kim (2): > > f2fs: register inodes which is able to donate pages > > f2fs: add a sysfs entry to request donate file-backed pages > > > > Jaegeuk Kim (2): > > f2fs: register inodes which is able to donate pages > > f2fs: add a sysfs entry to request donate file-backed pages > > > > Documentation/ABI/testing/sysfs-fs-f2fs | 7 ++ > > fs/f2fs/debug.c | 3 + > > fs/f2fs/f2fs.h | 14 +++- > > fs/f2fs/file.c | 60 +++++++++++++++++ > > fs/f2fs/inode.c | 14 ++++ > > fs/f2fs/shrinker.c | 90 +++++++++++++++++++++++++ > > fs/f2fs/super.c | 1 + > > fs/f2fs/sysfs.c | 63 +++++++++++++++++ > > include/uapi/linux/f2fs.h | 7 ++ > > 9 files changed, 258 insertions(+), 1 deletion(-) > > > > -- > > 2.48.1.362.g079036d154-goog > > > > > ---end quoted text--- _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel