All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Zejun Zhao <jelly.zhao.42@gmail.com>
Cc: git@vger.kernel.org, johannes.schindelin@gmx.de
Subject: Re: [PATCH] contrib/vscode: respect configurable options of IntelliSense
Date: Wed, 5 Feb 2025 08:08:39 +0100	[thread overview]
Message-ID: <Z6MOdywCXc48qARV@pks.im> (raw)
In-Reply-To: <20250204125721.11357-1-jelly.zhao.42@gmail.com>

On Tue, Feb 04, 2025 at 12:57:21PM +0000, Zejun Zhao wrote:
> The initialization script of VSCode development environment uses removed configurable options of IntelliSense, e.g. C_Cpp.intelliSenseEngineFallback and therefore triggers some warnings.
> 
> Fix this by strictly respecting the latest configuration manual of VSCode IntelliSense.

Formatting of the commit message is off, as we wrap lines at 72
characters. I cannot really say much about the patch itself. One thing
that might help reviewers who aren't familiar with VSCode would be a
link to for example release notes that announce the dremoval of the
option you're removing.

A bit off-topic: did you by any chance try out our Meson build system?
VSCode has a plugin for Meson that you can install, and then you can
import the Git project into VSCode directly without using
"contrib/vscode".

Patrick

  reply	other threads:[~2025-02-05  7:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04 12:57 [PATCH] contrib/vscode: respect configurable options of IntelliSense Zejun Zhao
2025-02-05  7:08 ` Patrick Steinhardt [this message]
2025-03-16  2:37 ` Johannes Schindelin
2025-03-17 22:17   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6MOdywCXc48qARV@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=jelly.zhao.42@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.