From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Lyude Paul" <lyude@redhat.com>,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Alexander Lobakin" <aleksander.lobakin@intel.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Mark Brown" <broonie@kernel.org>,
"Maíra Canal" <mairacanal@riseup.net>,
"Robin Murphy" <robin.murphy@arm.com>,
"Simona Vetter" <simona.vetter@ffwll.ch>,
"Zijun Hu" <quic_zijuhu@quicinc.com>,
linux-usb@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v2 1/5] driver core: add a faux bus for use when a simple device/bus is needed
Date: Wed, 5 Feb 2025 09:57:32 +0200 [thread overview]
Message-ID: <Z6MZ7JdP6tynvYRr@smile.fi.intel.com> (raw)
In-Reply-To: <2025020518-outcome-harbor-6281@gregkh>
On Wed, Feb 05, 2025 at 06:53:09AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 04, 2025 at 06:10:36PM -0500, Lyude Paul wrote:
> > On Tue, 2025-02-04 at 12:09 +0100, Greg Kroah-Hartman wrote:
...
> > Should we add faux_get_drvdata()/faux_set_drvdata() since we've got a
> > probe/remove function? Doesn't really look like the platform driver equivalent
> > does mcuh, but I assume just having an inline function for this would make
> > things a little less confusing for users.
>
> You already have a reference counted object returned to you, why do you
> need to increment/decrement it again? All of the users I've found in
> the kernel so far didn't need that, do you have a specific example where
> it would be useful?
It's about getter and setter for the .driver_data field, I don't see how
reference counting can help with this.
> I'll be glad to add it, I just didn't think anyone would ever call it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-02-05 7:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 11:09 [PATCH v2 0/5] Driver core: Add faux bus devices Greg Kroah-Hartman
2025-02-04 11:09 ` [PATCH v2 1/5] driver core: add a faux bus for use when a simple device/bus is needed Greg Kroah-Hartman
2025-02-04 11:44 ` Danilo Krummrich
2025-02-04 11:52 ` Greg Kroah-Hartman
2025-02-04 12:04 ` Danilo Krummrich
2025-02-04 12:55 ` Greg Kroah-Hartman
2025-02-04 13:57 ` Danilo Krummrich
2025-02-04 12:46 ` Jonathan Cameron
2025-02-04 15:31 ` Alan Stern
2025-02-06 7:44 ` Greg Kroah-Hartman
2025-02-04 16:46 ` Rob Herring
2025-02-04 16:51 ` Rob Herring
2025-02-06 7:43 ` Greg Kroah-Hartman
2025-02-04 22:18 ` Lyude Paul
2025-02-06 10:50 ` Greg Kroah-Hartman
2025-02-04 22:51 ` Lyude Paul
2025-02-05 5:51 ` Greg Kroah-Hartman
2025-02-04 23:10 ` Lyude Paul
2025-02-05 5:53 ` Greg Kroah-Hartman
2025-02-05 7:57 ` Andy Shevchenko [this message]
2025-02-05 8:58 ` Greg Kroah-Hartman
2025-02-06 15:34 ` Zijun Hu
2025-02-06 16:19 ` Greg Kroah-Hartman
2025-02-04 11:09 ` [PATCH v2 2/5] regulator: dummy: convert to use the faux bus Greg Kroah-Hartman
2025-02-04 12:35 ` Mark Brown
2025-02-04 12:47 ` Jonathan Cameron
2025-02-04 11:09 ` [PATCH v2 3/5] USB: phy: convert usb_phy_generic logic to use a faux device Greg Kroah-Hartman
2025-02-05 10:19 ` Peter Chen
2025-02-05 12:27 ` Greg Kroah-Hartman
2025-02-05 13:41 ` Greg Kroah-Hartman
2025-02-06 1:54 ` Peter Chen
2025-02-06 5:46 ` Greg Kroah-Hartman
2025-02-04 11:09 ` [PATCH v2 4/5] x86/microcode: move away from using a fake platform device Greg Kroah-Hartman
2025-02-04 11:09 ` [PATCH v2 5/5] wifi: cfg80211: " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6MZ7JdP6tynvYRr@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=aleksander.lobakin@intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=lyude@redhat.com \
--cc=mairacanal@riseup.net \
--cc=quic_zijuhu@quicinc.com \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona.vetter@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.