* [PATCH] hwmon: sg2042: add back module description/author tags
@ 2025-02-05 12:14 Arnd Bergmann
2025-02-05 12:28 ` Inochi Amaoto
2025-02-07 2:50 ` Guenter Roeck
0 siblings, 2 replies; 5+ messages in thread
From: Arnd Bergmann @ 2025-02-05 12:14 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Wolfram Sang
Cc: Arnd Bergmann, Uwe Kleine-König, Inochi Amaoto, linux-hwmon,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
A previous code reorganization inadvertently dropped the two tags,
which leads to a "make W=1" warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hwmon/sg2042-mcu.o
Add these back.
Fixes: cd4db38c4368 ("hwmon: (sg2042) Use per-client debugfs entry")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/hwmon/sg2042-mcu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hwmon/sg2042-mcu.c b/drivers/hwmon/sg2042-mcu.c
index 74c35945d169..105131c4acf7 100644
--- a/drivers/hwmon/sg2042-mcu.c
+++ b/drivers/hwmon/sg2042-mcu.c
@@ -355,4 +355,6 @@ static struct i2c_driver sg2042_mcu_driver = {
};
module_i2c_driver(sg2042_mcu_driver);
+MODULE_AUTHOR("Inochi Amaoto <inochiama@outlook.com>");
+MODULE_DESCRIPTION("MCU I2C driver for SG2042 soc platform");
MODULE_LICENSE("GPL");
--
2.39.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: sg2042: add back module description/author tags
2025-02-05 12:14 [PATCH] hwmon: sg2042: add back module description/author tags Arnd Bergmann
@ 2025-02-05 12:28 ` Inochi Amaoto
2025-02-05 12:34 ` Wolfram Sang
2025-02-07 2:50 ` Guenter Roeck
1 sibling, 1 reply; 5+ messages in thread
From: Inochi Amaoto @ 2025-02-05 12:28 UTC (permalink / raw)
To: Arnd Bergmann, Jean Delvare, Guenter Roeck, Wolfram Sang
Cc: Arnd Bergmann, Uwe Kleine-König, Inochi Amaoto, linux-hwmon,
linux-kernel
On Wed, Feb 05, 2025 at 01:14:08PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A previous code reorganization inadvertently dropped the two tags,
> which leads to a "make W=1" warning:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hwmon/sg2042-mcu.o
>
> Add these back.
>
> Fixes: cd4db38c4368 ("hwmon: (sg2042) Use per-client debugfs entry")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Inochi Amaoto <inochiama@gmail.com>
> ---
> drivers/hwmon/sg2042-mcu.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hwmon/sg2042-mcu.c b/drivers/hwmon/sg2042-mcu.c
> index 74c35945d169..105131c4acf7 100644
> --- a/drivers/hwmon/sg2042-mcu.c
> +++ b/drivers/hwmon/sg2042-mcu.c
> @@ -355,4 +355,6 @@ static struct i2c_driver sg2042_mcu_driver = {
> };
> module_i2c_driver(sg2042_mcu_driver);
>
> +MODULE_AUTHOR("Inochi Amaoto <inochiama@outlook.com>");
> +MODULE_DESCRIPTION("MCU I2C driver for SG2042 soc platform");
> MODULE_LICENSE("GPL");
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: sg2042: add back module description/author tags
2025-02-05 12:28 ` Inochi Amaoto
@ 2025-02-05 12:34 ` Wolfram Sang
2025-02-05 12:39 ` Inochi Amaoto
0 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2025-02-05 12:34 UTC (permalink / raw)
To: Inochi Amaoto
Cc: Arnd Bergmann, Jean Delvare, Guenter Roeck, Arnd Bergmann,
Uwe Kleine-König, Inochi Amaoto, linux-hwmon, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 801 bytes --]
On Wed, Feb 05, 2025 at 08:28:56PM +0800, Inochi Amaoto wrote:
> On Wed, Feb 05, 2025 at 01:14:08PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > A previous code reorganization inadvertently dropped the two tags,
> > which leads to a "make W=1" warning:
:( Very sloppy, I am sorry!
> > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hwmon/sg2042-mcu.o
> >
> > Add these back.
> >
> > Fixes: cd4db38c4368 ("hwmon: (sg2042) Use per-client debugfs entry")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Inochi Amaoto <inochiama@gmail.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Just wondering: Inochi Amaoto's email above is using gmail, below is
using outlook. Is the old one still valid?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: sg2042: add back module description/author tags
2025-02-05 12:34 ` Wolfram Sang
@ 2025-02-05 12:39 ` Inochi Amaoto
0 siblings, 0 replies; 5+ messages in thread
From: Inochi Amaoto @ 2025-02-05 12:39 UTC (permalink / raw)
To: Wolfram Sang, Inochi Amaoto, Arnd Bergmann, Jean Delvare,
Guenter Roeck, Arnd Bergmann, Uwe Kleine-König,
Inochi Amaoto, linux-hwmon, linux-kernel
On Wed, Feb 05, 2025 at 01:34:57PM +0100, Wolfram Sang wrote:
> On Wed, Feb 05, 2025 at 08:28:56PM +0800, Inochi Amaoto wrote:
> > On Wed, Feb 05, 2025 at 01:14:08PM +0100, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > A previous code reorganization inadvertently dropped the two tags,
> > > which leads to a "make W=1" warning:
>
> :( Very sloppy, I am sorry!
>
> > > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hwmon/sg2042-mcu.o
> > >
> > > Add these back.
> > >
> > > Fixes: cd4db38c4368 ("hwmon: (sg2042) Use per-client debugfs entry")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Reviewed-by: Inochi Amaoto <inochiama@gmail.com>
>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Just wondering: Inochi Amaoto's email above is using gmail, below is
> using outlook. Is the old one still valid?
>
Since the MS requires 2FA for email client, I uses gmail as an
alternative to send patches and reply. I may use outlook to send
in the furture if I find a way to login, or just update the
maintainance information if no way.
Regards,
Inochi.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: sg2042: add back module description/author tags
2025-02-05 12:14 [PATCH] hwmon: sg2042: add back module description/author tags Arnd Bergmann
2025-02-05 12:28 ` Inochi Amaoto
@ 2025-02-07 2:50 ` Guenter Roeck
1 sibling, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2025-02-07 2:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jean Delvare, Wolfram Sang, Arnd Bergmann, Uwe Kleine-König,
Inochi Amaoto, linux-hwmon, linux-kernel
On Wed, Feb 05, 2025 at 01:14:08PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A previous code reorganization inadvertently dropped the two tags,
> which leads to a "make W=1" warning:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hwmon/sg2042-mcu.o
>
> Add these back.
>
> Fixes: cd4db38c4368 ("hwmon: (sg2042) Use per-client debugfs entry")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Inochi Amaoto <inochiama@gmail.com>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-07 2:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-05 12:14 [PATCH] hwmon: sg2042: add back module description/author tags Arnd Bergmann
2025-02-05 12:28 ` Inochi Amaoto
2025-02-05 12:34 ` Wolfram Sang
2025-02-05 12:39 ` Inochi Amaoto
2025-02-07 2:50 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.