[PATCH] hwmon: sg2042: add back module description/author tags

[PATCH] hwmon: sg2042: add back module description/author tags

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

A previous code reorganization inadvertently dropped the two tags,
which leads to a "make W=1" warning:

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hwmon/sg2042-mcu.o

Add these back.

Fixes: cd4db38c4368 ("hwmon: (sg2042) Use per-client debugfs entry")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/hwmon/sg2042-mcu.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hwmon/sg2042-mcu.c b/drivers/hwmon/sg2042-mcu.c
index 74c35945d169..105131c4acf7 100644
--- a/drivers/hwmon/sg2042-mcu.c
+++ b/drivers/hwmon/sg2042-mcu.c
@@ -355,4 +355,6 @@ static struct i2c_driver sg2042_mcu_driver = {
 };
 module_i2c_driver(sg2042_mcu_driver);
 
+MODULE_AUTHOR("Inochi Amaoto <inochiama@outlook.com>");
+MODULE_DESCRIPTION("MCU I2C driver for SG2042 soc platform");
 MODULE_LICENSE("GPL");
-- 
2.39.5

Re: [PATCH] hwmon: sg2042: add back module description/author tags

[Inochi Amaoto]

On Wed, Feb 05, 2025 at 01:14:08PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> A previous code reorganization inadvertently dropped the two tags,
> which leads to a "make W=1" warning:
> 
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hwmon/sg2042-mcu.o
> 
> Add these back.
> 
> Fixes: cd4db38c4368 ("hwmon: (sg2042) Use per-client debugfs entry")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Inochi Amaoto <inochiama@gmail.com>

> ---
>  drivers/hwmon/sg2042-mcu.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hwmon/sg2042-mcu.c b/drivers/hwmon/sg2042-mcu.c
> index 74c35945d169..105131c4acf7 100644
> --- a/drivers/hwmon/sg2042-mcu.c
> +++ b/drivers/hwmon/sg2042-mcu.c
> @@ -355,4 +355,6 @@ static struct i2c_driver sg2042_mcu_driver = {
>  };
>  module_i2c_driver(sg2042_mcu_driver);
>  
> +MODULE_AUTHOR("Inochi Amaoto <inochiama@outlook.com>");
> +MODULE_DESCRIPTION("MCU I2C driver for SG2042 soc platform");
>  MODULE_LICENSE("GPL");
> -- 
> 2.39.5
> 

Re: [PATCH] hwmon: sg2042: add back module description/author tags

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

On Wed, Feb 05, 2025 at 08:28:56PM +0800, Inochi Amaoto wrote:
> On Wed, Feb 05, 2025 at 01:14:08PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > A previous code reorganization inadvertently dropped the two tags,
> > which leads to a "make W=1" warning:

:( Very sloppy, I am sorry!

> > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hwmon/sg2042-mcu.o
> > 
> > Add these back.
> > 
> > Fixes: cd4db38c4368 ("hwmon: (sg2042) Use per-client debugfs entry")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Reviewed-by: Inochi Amaoto <inochiama@gmail.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Just wondering: Inochi Amaoto's email above is using gmail, below is
using outlook. Is the old one still valid?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] hwmon: sg2042: add back module description/author tags

[Inochi Amaoto]

On Wed, Feb 05, 2025 at 01:34:57PM +0100, Wolfram Sang wrote:
> On Wed, Feb 05, 2025 at 08:28:56PM +0800, Inochi Amaoto wrote:
> > On Wed, Feb 05, 2025 at 01:14:08PM +0100, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > > 
> > > A previous code reorganization inadvertently dropped the two tags,
> > > which leads to a "make W=1" warning:
> 
> :( Very sloppy, I am sorry!
> 
> > > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hwmon/sg2042-mcu.o
> > > 
> > > Add these back.
> > > 
> > > Fixes: cd4db38c4368 ("hwmon: (sg2042) Use per-client debugfs entry")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > 
> > Reviewed-by: Inochi Amaoto <inochiama@gmail.com>
> 
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Just wondering: Inochi Amaoto's email above is using gmail, below is
> using outlook. Is the old one still valid?
> 

Since the MS requires 2FA for email client, I uses gmail as an
alternative to send patches and reply. I may use outlook to send
in the furture if I find a way to login, or just update the
maintainance information if no way.

Regards,
Inochi.

Re: [PATCH] hwmon: sg2042: add back module description/author tags

[Guenter Roeck]

On Wed, Feb 05, 2025 at 01:14:08PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> A previous code reorganization inadvertently dropped the two tags,
> which leads to a "make W=1" warning:
> 
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hwmon/sg2042-mcu.o
> 
> Add these back.
> 
> Fixes: cd4db38c4368 ("hwmon: (sg2042) Use per-client debugfs entry")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Inochi Amaoto <inochiama@gmail.com>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Applied.

Thanks,
Guenter