From: Danilo Krummrich <dakr@kernel.org>
To: Tamir Duberstein <tamird@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] rust: alloc: satisfy `aligned_alloc` requirements
Date: Wed, 5 Feb 2025 20:13:03 +0100 [thread overview]
Message-ID: <Z6O4P_BmiR2czXDf@cassiopeiae> (raw)
In-Reply-To: <20250202-aligned-alloc-v2-1-5af0b5fdd46f@gmail.com>
On Sun, Feb 02, 2025 at 06:27:16AM -0500, Tamir Duberstein wrote:
> The implementation added in commit dd09538fb409 ("rust: alloc: implement
> `Cmalloc` in module allocator_test") did not honor the documented
> requirements of `aligned_alloc`. These requirements may not be enforced
> on all systems, but they are on macOS. Ensure that alignment is at least
> `sizeof(void *)` and round size up to the nearest multiple of that
> value.
>
> Fixes: dd09538fb409 ("rust: alloc: implement `Cmalloc` in module allocator_test")
>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
> ---
> Changes in v2:
> - Shorten some variable names. (Danilo Krummrich)
> - Replace shadowing alignment variable with a second call to
> Layout::align. (Danilo Krummrich)
> - Link to v1: https://lore.kernel.org/r/20250201-aligned-alloc-v1-1-c99a73f3cbd4@gmail.com
> ---
> rust/kernel/alloc/allocator_test.rs | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
Acked-by: Danilo Krummrich <dakr@kernel.org>
next prev parent reply other threads:[~2025-02-05 19:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-02 11:27 [PATCH v2] rust: alloc: satisfy `aligned_alloc` requirements Tamir Duberstein
2025-02-05 19:13 ` Danilo Krummrich [this message]
2025-02-06 17:56 ` Miguel Ojeda
2025-02-06 18:04 ` Danilo Krummrich
2025-02-06 18:10 ` Tamir Duberstein
2025-02-06 18:23 ` Miguel Ojeda
2025-02-06 18:51 ` Tamir Duberstein
2025-02-06 18:20 ` Miguel Ojeda
2025-02-06 18:57 ` Danilo Krummrich
2025-02-06 19:04 ` Tamir Duberstein
2025-02-06 19:37 ` Miguel Ojeda
2025-02-06 19:46 ` Danilo Krummrich
2025-02-08 19:19 ` Alejandro Colomar
2025-02-08 20:09 ` Paul Eggert
2025-02-08 20:31 ` Alejandro Colomar
2025-02-08 20:21 ` DJ Delorie
2025-02-08 23:11 ` Miguel Ojeda
2025-02-08 23:35 ` Alejandro Colomar
2025-02-08 23:50 ` Miguel Ojeda
2025-02-10 3:01 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6O4P_BmiR2czXDf@cassiopeiae \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.