From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alexey Kashavkin <akashavkin@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 2/2] parser_bison: turn redudant ip option type field match into boolean
Date: Thu, 6 Feb 2025 12:55:12 +0100 [thread overview]
Message-ID: <Z6SjIEKagIkqvo57@calendula> (raw)
In-Reply-To: <D068290E-A9A3-4CD3-9C75-413626D540D6@gmail.com>
Hi,
On Wed, Feb 05, 2025 at 03:29:10PM +0300, Alexey Kashavkin wrote:
> I suggest adding the following note about the addr field.
>
> diff --git a/doc/payload-expression.txt b/doc/payload-expression.txt
> index 7bc24a8a..9a7ac396 100644
> --- a/doc/payload-expression.txt
> +++ b/doc/payload-expression.txt
> @@ -820,6 +820,8 @@ Strict Source Route |
> type, length, ptr, addr
> |============================
>
> +Note: Only the first IP address is specified in the addr field.
It should be not too complicated to extend this to match on any
address.
> +
> .finding TCP options
> --------------------
> filter input tcp option sack-perm exists counter
>
>
next prev parent reply other threads:[~2025-02-06 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 10:47 [PATCH nft 1/2] ipopt: use ipv4 address datatype for address field in ip options Pablo Neira Ayuso
2025-01-31 10:47 ` [PATCH nft 2/2] parser_bison: turn redudant ip option type field match into boolean Pablo Neira Ayuso
2025-02-05 12:29 ` Alexey Kashavkin
2025-02-06 11:55 ` Pablo Neira Ayuso [this message]
2025-02-06 12:02 ` Alexey Kashavkin
2025-02-06 12:44 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6SjIEKagIkqvo57@calendula \
--to=pablo@netfilter.org \
--cc=akashavkin@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.