All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Oleksii Kurochko <oleksii.kurochko@gmail.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Michal Orzel <michal.orzel@amd.com>
Subject: Re: [PATCH v3 for-4.21 4/4] PCI: drop pci_segments_init()
Date: Thu, 6 Feb 2025 16:08:56 +0100	[thread overview]
Message-ID: <Z6TQiP7142UON90W@macbook.local> (raw)
In-Reply-To: <b7b148fc-ee74-4f02-9dab-f80b1707e44e@suse.com>

On Tue, Feb 04, 2025 at 02:04:35PM +0100, Jan Beulich wrote:
> Have callers invoke pci_add_segment() directly instead: With radix tree
> initialization moved out of the function, its name isn't quite
> describing anymore what it actually does.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

IMO I would rather not add the segment here, and just make sure that
all callers that add segments have proper error reporting when it
fails.  Maybe alloc_pseg() should gain a printk on failure?

Thanks, Roger.


  reply	other threads:[~2025-02-06 15:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04 13:00 [PATCH v3 for-4.20 0/4] AMD/IOMMU: assorted corrections (leftover) Jan Beulich
2025-02-04 13:02 ` [PATCH v3 for-4.20 1/4] radix-tree: purge node allocation override hooks Jan Beulich
2025-02-04 13:03 ` [PATCH v3 for-4.20 2/4] radix-tree: introduce RADIX_TREE{,_INIT}() Jan Beulich
2025-02-04 13:10   ` Andrew Cooper
2025-02-04 13:19     ` Jan Beulich
2025-02-04 13:56       ` Andrew Cooper
2025-02-04 14:02         ` Jan Beulich
2025-02-04 13:03 ` [PATCH v3 for-4.21 3/4] radix-tree: drop "root" parameters from radix_tree_node_{alloc,free}() Jan Beulich
2025-02-04 13:04 ` [PATCH v3 for-4.21 4/4] PCI: drop pci_segments_init() Jan Beulich
2025-02-06 15:08   ` Roger Pau Monné [this message]
2025-02-10 10:01     ` Jan Beulich
2025-02-10 11:02       ` Roger Pau Monné
2025-02-06 12:35 ` [PATCH v3 for-4.20 0/4] AMD/IOMMU: assorted corrections (leftover) Jan Beulich
2025-02-06 13:14   ` Oleksii Kurochko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6TQiP7142UON90W@macbook.local \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=bertrand.marquis@arm.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=oleksii.kurochko@gmail.com \
    --cc=sstabellini@kernel.org \
    --cc=volodymyr_babchuk@epam.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.