All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Prasad Pandit <ppandit@redhat.com>
Cc: qemu-devel@nongnu.org, farosas@suse.de, berrange@redhat.com,
	Prasad Pandit <pjp@fedoraproject.org>
Subject: Re: [PATCH v5 5/5] tests/qtest/migration: consolidate set capabilities
Date: Thu, 6 Feb 2025 17:44:45 -0500	[thread overview]
Message-ID: <Z6U7XQO-Mjgb92eb@x1.local> (raw)
In-Reply-To: <20250205122712.229151-6-ppandit@redhat.com>

On Wed, Feb 05, 2025 at 05:57:12PM +0530, Prasad Pandit wrote:
> From: Prasad Pandit <pjp@fedoraproject.org>
> 
> Migration capabilities are set in multiple '.start_hook'
> functions for various tests. Instead, consolidate setting
> capabilities in 'set_migration_capabilities()' function
> which is called from various 'test_*_common()' functions.
> While simplifying the capabilities setting, it helps
> to declutter the test sources.
> 
> Suggested-by: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Prasad Pandit <pjp@fedoraproject.org>

Would you mind reorder the two test patches, to avoid removing the lines
added by previous patch?

Thanks,

-- 
Peter Xu



  reply	other threads:[~2025-02-06 22:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-05 12:27 [PATCH v5 0/5] Allow to enable multifd and postcopy migration together Prasad Pandit
2025-02-05 12:27 ` [PATCH v5 1/5] migration/multifd: move macros to multifd header Prasad Pandit
2025-02-06 22:41   ` Peter Xu
2025-02-05 12:27 ` [PATCH v5 2/5] migration: refactor ram_save_target_page functions Prasad Pandit
2025-02-06 22:43   ` Peter Xu
2025-02-07 12:19     ` Fabiano Rosas
2025-02-05 12:27 ` [PATCH v5 3/5] migration: enable multifd and postcopy together Prasad Pandit
2025-02-06 23:16   ` Peter Xu
2025-02-07 10:32     ` Prasad Pandit
2025-02-07 15:45       ` Peter Xu
2025-02-08 10:36         ` Prasad Pandit
2025-02-10 16:59           ` Peter Xu
2025-02-11  9:04             ` Prasad Pandit
2025-02-11 15:20               ` Peter Xu
2025-02-12 13:27                 ` Prasad Pandit
2025-02-12 14:37                   ` Peter Xu
2025-02-12 17:36                     ` Prasad Pandit
2025-02-12 17:52                       ` Peter Xu
2025-02-05 12:27 ` [PATCH v5 4/5] tests/qtest/migration: add postcopy tests with multifd Prasad Pandit
2025-02-05 12:27 ` [PATCH v5 5/5] tests/qtest/migration: consolidate set capabilities Prasad Pandit
2025-02-06 22:44   ` Peter Xu [this message]
2025-02-07  8:59     ` Prasad Pandit
2025-02-07 22:01   ` Fabiano Rosas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6U7XQO-Mjgb92eb@x1.local \
    --to=peterx@redhat.com \
    --cc=berrange@redhat.com \
    --cc=farosas@suse.de \
    --cc=pjp@fedoraproject.org \
    --cc=ppandit@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.