From: "J. Neuschäfer via buildroot" <buildroot@buildroot.org>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: buildroot@buildroot.org, j.neuschaefer@gmx.net
Subject: Re: [Buildroot] [PATCH] snooze: new package
Date: Fri, 7 Feb 2025 02:17:48 +0100 [thread overview]
Message-ID: <Z6VfPMQrB_i1hCaS@probook> (raw)
In-Reply-To: <da1a07c5-c7bf-42dd-bbce-efbef6bce080@korsgaard.com>
On Wed, Feb 05, 2025 at 04:00:07PM +0100, Peter Korsgaard wrote:
> On 7/4/24 21:49, J. Neuschäfer via buildroot wrote:
>
> Hello, and sorry for the slow response.
>
> > +++ b/package/snooze/0001-fix-snooze-n-format-string.patch
> > @@ -0,0 +1,38 @@
> > +From 5f9e616b29fe272fffbb31e4b7ea8ff61f781601 Mon Sep 17 00:00:00 2001
> > +From: Leah Neukirchen <leah@vuxu.org>
> > +Date: Wed, 29 May 2024 19:42:27 +0200
> > +Subject: [PATCH] fix "snooze -n" format string
> > +
> > +Fixes #22.
> > +
>
> Patches need signed-off-by tags as flagged by ./utils/check-package. I have
> added yours from above.
>
> > +++ b/package/snooze/snooze.mk
> > @@ -0,0 +1,29 @@
> > +################################################################################
> > +#
> > +# snooze
> > +#
> > +################################################################################
> > +
> > +SNOOZE_VERSION = 0.5
> > +SNOOZE_SITE = $(call github,leahneukirchen,snooze,v$(SNOOZE_VERSION))
> > +SNOOZE_LICENSE = CC0-1.0
> > +
> > +# Unfortunately, snooze doesn't have a dedicated file for the license, but it
> > +# is mentioned in the README and in the manpage.
> > +SNOOZE_LICENSE_FILES = README.md
> > +
> > +SNOOZE_MAKE_OPTS = \
> > + PREFIX=/ \
>
> The default is /usr/local. Any specific reason to make it / instead of /usr?
> I have made it /usr for consistency.
>
> > + DESTDIR=$(TARGET_DIR) \
>
> DESTDIR is used at installation time and not build time, so I moved it to
> _INSTALL_TARGET_CMDS similar to how it is done for autotools packages.
>
>
> > + CC=$(TARGET_CC) \
> > + LD=$(TARGET_LD)
>
> The Makefile does not use LD, so I have dropped that. Instead we need to
> pass TARGET_CFLAGS and TARGET_LDFLAGS, so I have added those.
>
>
> Finally you forgot to add the package to your DEVELOPERS entry.
>
> Committed with these fixes, thanks.
It seems I forgot quite a few things...
Thank you very much!
J. Neuschäfer
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2025-02-07 1:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 19:49 [Buildroot] [PATCH] snooze: new package J. Neuschäfer via buildroot
2025-02-05 15:00 ` Peter Korsgaard
2025-02-07 1:17 ` J. Neuschäfer via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6VfPMQrB_i1hCaS@probook \
--to=buildroot@buildroot.org \
--cc=j.neuschaefer@gmx.net \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.