From: Hangbin Liu <liuhangbin@gmail.com>
To: Jay Vosburgh <jv@jvosburgh.net>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Simon Horman <horms@kernel.org>, Jianbo Liu <jianbol@nvidia.com>,
Boris Pismenny <borisp@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 net 1/2] bonding: fix incorrect MAC address setting to receive NS messages
Date: Fri, 7 Feb 2025 07:31:26 +0000 [thread overview]
Message-ID: <Z6W2zhPkcbT2RmWn@fedora> (raw)
In-Reply-To: <624905.1738891174@famine>
On Thu, Feb 06, 2025 at 05:19:34PM -0800, Jay Vosburgh wrote:
> I think this now deserves some commentary in the code. Not
> because this function itself is unclear, but because there's the
> similarly-named slave_set_ns_maddr() (singular, not plural as in this
> patch) that will behave in a subtly different manner after this patch is
> applied.
Yes, slave_set_ns_maddr() also need to be changed. The names are similar.
I will add some comments for the functions.
Thanks
Hangbin
next prev parent reply other threads:[~2025-02-07 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 9:45 [PATCHv2 net 0/2] bonding: fix incorrect mac address setting Hangbin Liu
2025-02-06 9:45 ` [PATCHv2 net 1/2] bonding: fix incorrect MAC address setting to receive NS messages Hangbin Liu
2025-02-07 1:19 ` Jay Vosburgh
2025-02-07 7:31 ` Hangbin Liu [this message]
2025-02-06 9:46 ` [PATCHv2 net 2/2] selftests: bonding: fix incorrect mac address Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6W2zhPkcbT2RmWn@fedora \
--to=liuhangbin@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jianbol@nvidia.com \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.