From: Sean Christopherson <seanjc@google.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: qemu-devel@nongnu.org,
Stefano Stabellini <sstabellini@kernel.org>,
Anthony PERARD <anthony@xenproject.org>,
Paul Durrant <paul@xen.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
xen-devel@lists.xenproject.org, qemu-block@nongnu.org,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] i386/xen: Move KVM_XEN_HVM_CONFIG ioctl to kvm_xen_init_vcpu()
Date: Fri, 7 Feb 2025 07:37:40 -0800 [thread overview]
Message-ID: <Z6YoxFOaMdNiD_uv@google.com> (raw)
In-Reply-To: <20250207143724.30792-1-dwmw2@infradead.org>
On Fri, Feb 07, 2025, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> At the time kvm_xen_init() is called, hyperv_enabled() doesn't yet work, so
> the correct MSR index to use for the hypercall page isn't known.
>
> Rather than setting it to the default and then shifting it later for the
> Hyper-V case with a confusing second call to kvm_init_xen(), just do it
> once in kvm_xen_init_vcpu().
Is it possible the funky double-init is deliberate, to ensure that Xen is
configured in KVM during VM setup? I looked through KVM and didn't see any
obvious dependencies, but that doesn't mean a whole lot.
next prev parent reply other threads:[~2025-02-07 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 14:37 [PATCH 1/2] i386/xen: Move KVM_XEN_HVM_CONFIG ioctl to kvm_xen_init_vcpu() David Woodhouse
2025-02-07 14:37 ` [PATCH 2/2] hw/xen: Add "mode" parameter to xen-block devices David Woodhouse
2025-03-07 10:38 ` Anthony PERARD
2025-02-07 15:37 ` Sean Christopherson [this message]
2025-02-07 21:06 ` [PATCH 1/2] i386/xen: Move KVM_XEN_HVM_CONFIG ioctl to kvm_xen_init_vcpu() David Woodhouse
2025-03-29 7:28 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6YoxFOaMdNiD_uv@google.com \
--to=seanjc@google.com \
--cc=anthony@xenproject.org \
--cc=dwmw2@infradead.org \
--cc=edgar.iglesias@gmail.com \
--cc=hreitz@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=mtosatti@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.