From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1tgiWP-0004Is-3d for mharc-qemu-rust@gnu.org; Sat, 08 Feb 2025 05:57:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgiWJ-0004Hg-6w; Sat, 08 Feb 2025 05:57:07 -0500 Received: from mgamail.intel.com ([192.198.163.8]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgiWH-0001ru-PP; Sat, 08 Feb 2025 05:57:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739012225; x=1770548225; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DSsZrANcTJeTDe2XG2rANTgEcuJ6JlCUl4fqqBiaA08=; b=k5tCkcdSWQasr4yeKOft6tnKsg8cn2aI4fROX+7pzP8vnw7oJR0qZRMz xr6vSUdYuzAuGrPhxpIXXLX/x0H0gZOBsojAVCXXwHHzSO62jqnVPhLBK 2bEeCwyKOJaBh7q7f44rBZL3xmpJo86QzxC/ms/WEhqR9EIM1FM83CFE3 myi1rSOS/TodnxH0gMDa9TtGDF1grZWy6UU0BB2lYADFLaS0QP1eB8/sR wJoo/VD9qqGWE6hLwXq1edLN1SNET0//Zj2b3WvWy6vhQjBJGa9ib4FVe wKbqR4eSmsNmufTbUZQTeB9/uCg2eEBApM1V3XawoviAbyLIgp9VXYs2U w==; X-CSE-ConnectionGUID: zDRuAsGVSTW9MtFY7BdZzw== X-CSE-MsgGUID: 3JY5+3nqQcGFLBDVey942g== X-IronPort-AV: E=McAfee;i="6700,10204,11338"; a="57186324" X-IronPort-AV: E=Sophos;i="6.13,269,1732608000"; d="scan'208";a="57186324" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2025 02:56:58 -0800 X-CSE-ConnectionGUID: MwZcsMT1QgC9bDvc9055Vg== X-CSE-MsgGUID: ORrFD1u6TGy8VLnnPYicew== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="148955570" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.39]) by orviesa001.jf.intel.com with ESMTP; 08 Feb 2025 02:56:56 -0800 Date: Sat, 8 Feb 2025 19:16:25 +0800 From: Zhao Liu To: Paolo Bonzini Cc: Manos Pitsidianakis , Junjie Mao , Alex =?iso-8859-1?Q?Benn=E9e?= , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Richard Henderson , Peter Maydell , Daniel P =?iso-8859-1?Q?=2E_Berrang=E9?= , qemu-devel , qemu-rust@nongnu.org Subject: Re: [PATCH 04/10] rust: add bindings for gpio_{in|out} initialization Message-ID: References: <20250125125137.1223277-1-zhao1.liu@intel.com> <20250125125137.1223277-5-zhao1.liu@intel.com> <5a19e7d2-9d69-45fe-812f-84145229876f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=192.198.163.8; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-rust@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: QEMU Rust-related patches and discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Feb 2025 10:57:09 -0000 > Use the "let" so that it's caught at compile time. Thanks! Fixed. > There's a difference with origianl C version: > > > > In C side, qdev_get_gpio_in() family could accept a NULL handler, but > > there's no such case in current QEMU: > > > > * qdev_get_gpio_in > > * qdev_init_gpio_in_named > > * qdev_init_gpio_in_named_with_opaque > > > > And from code logic view, creating an input GPIO line but doing nothing > > on input, sounds also unusual. > > > > Wouldn't it then crash in qemu_set_irq? > Yes! Thank you for the education. Regards, Zhao