Re: [PATCH v2 2/2] gpu: nova-core: add initial documentation

[Danilo Krummrich <dakr@kernel.org>]

On Wed, Feb 05, 2025 at 07:44:19PM +0000, Zhi Wang wrote:
> On 05/02/2025 18.10, Danilo Krummrich wrote:
> > On Wed, Feb 05, 2025 at 03:56:46PM +0200, Zhi Wang wrote:
> >> On Tue,  4 Feb 2025 20:03:12 +0100
> >> Danilo Krummrich <dakr@kernel.org> wrote:
> >>> diff --git a/Documentation/gpu/nova/guidelines.rst b/Documentation/gpu/nova/guidelines.rst
> >>> new file mode 100644
> >>> index 000000000000..28a959f51c2c
> >>> --- /dev/null
> >>> +++ b/Documentation/gpu/nova/guidelines.rst
> >>> @@ -0,0 +1,73 @@
> >>> +.. SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> >>> +
> >>
> >> I think this will develop into a maintainer handbook in the future which
> >> reflects maintainer's requirements, thoughts, tips...maybe we can make it
> >> explicit? I think it is rules of book that we agree to follow.
> >>
> >> A similar one can be found here.
> >> https://lore.kernel.org/kvm/20230411171651.1067966-1-seanjc@google.com/
> > 
> > Yes, that's the idea. Is there anything additional you'd like to see added for
> > this initial commit?
> >
> 
> I am mostly thinking of testing of vGPU, we can conclude that more 
> clearly when we have basic stuff working. IMO, maybe some brief 
> introduction about maintainer branches, requirements of patch comments, 
> e.g. prefix of patch titles to different components, expectation of the 
> patch comment body beside those already in submitting_patches.rst. I 
> think those would be helpful.

I agree, but I don't think we need those things right from the get-go. Let's add
those things subsequently.