Re: [PATCH 1/6] crypto/tlscredsx509: Rename 'creds' -> 'x509_creds'

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Feb 10, 2025 at 05:21:30PM +0100, Philippe Mathieu-Daudé wrote:
> In preparation of naming the QCryptoTLSCreds 'creds' in the
> next commit, rename QCryptoTLSCredsX509 creds as 'x509_creds'.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  crypto/tlscredsx509.c | 66 +++++++++++++++++++++----------------------
>  1 file changed, 33 insertions(+), 33 deletions(-)
> 
> diff --git a/crypto/tlscredsx509.c b/crypto/tlscredsx509.c
> index 24ec5849222..eb197e145f3 100644
> --- a/crypto/tlscredsx509.c
> +++ b/crypto/tlscredsx509.c
> @@ -531,7 +531,7 @@ qcrypto_tls_creds_x509_sanity_check(QCryptoTLSCredsX509 *creds,
>  
>  
>  static int
> -qcrypto_tls_creds_x509_load(QCryptoTLSCredsX509 *creds,
> +qcrypto_tls_creds_x509_load(QCryptoTLSCredsX509 *x509_creds,

I can't say I like this naming.

If we want a variable for the parent class to not clash, imho,
just make the next patch use 'pcreds' (as short for "parent creds")

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|