From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2252325C6E6 for ; Mon, 10 Feb 2025 19:49:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739216970; cv=none; b=EAUNAT64fqLn9qnSlXYQ8nUCCnDUF8MQWRyM/ygB2PfAiS3yP/4uQv+uVsG8lf1VMJ9sqwthW5T/PeXcpeM6WGJgESRligQqF66OjS3zUROhtY5EssT151kP1VbA1mu4Fln0FVtotBJFdFGbsSlea4UpGHb1DIJbKoBkqxL7Rbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739216970; c=relaxed/simple; bh=f+UmLSmLtSGO/3ybQPpkX2cWkUy4Dc/MC+1IyQAQvNU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PMgrGkpJgIibCwUE2MiP1d7Yip3ROVildCKdGPPV2ElIgg53aE9gasx8VE3+QQASB7zfOCVoccGYNJ9CfEGJXQho7Xtahb1AgncC61WQcTCfA6xzJmUGjCo0uxqO8Y/VZbxiqOQlWYebdYceVSaXuZP3t4o2vgHzHzVi1UlEo98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=DnzRmHBv; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="DnzRmHBv" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-21f5268cf50so47728275ad.1 for ; Mon, 10 Feb 2025 11:49:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1739216968; x=1739821768; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=fTt2O+89+OX1qceRzkPwIzbuTN/WSFucT4iz8Aiof2Q=; b=DnzRmHBviHY+Pg3i9zE/TELFmyasC5ii+sEIu+yXj6DnYRnmnLDDMj88RCOuXSlpIC WMc5St5bRQVqHhWtqtkADyYmYs53JiFS4lyCDchBObnOwCyE+pOU5i0RIDuKocjlxF9u kIpGmQjpDt+JhbQTjagcNYuy9J/bDh7SCehSg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739216968; x=1739821768; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fTt2O+89+OX1qceRzkPwIzbuTN/WSFucT4iz8Aiof2Q=; b=oNwW4A5J/wgM10bSiwP69GKmQYC5ZXKJ+gGDWICm0mb68SBEaPRYLYwmipnIxHEsFY iIdyHoqPpxglLf0abpbDemRIutM0HvX1drMt/fTXi6y7JkrHr94LEQ6GtBJhJHfYPzVw 29Df+HVZQPmWHPP339140GOAGeb5lqhtIR0nKZ/lVwRnMTYUbb7HdhVxNuTuXXkYye8Z p9BVF9yJx18EvBg6U7JoIwaxa2SGB06mqbNjbtAcgpVTzpn/cvrYYKOGwqxtMtYmxK6v bgYrUtQPBBdOila1gQKKH/k15sYqYM45Q7kpRE0Av6q8WTlOHN8IyBFBVOxvWcU1aGEt dzsg== X-Forwarded-Encrypted: i=1; AJvYcCUCEWP+VCG5mzY686XFH2t3pDAuH+t6SwAdhpO+vhahAOX+1hfTWLRZ90RKUsknYQ2sXkcO3C4=@vger.kernel.org X-Gm-Message-State: AOJu0YwPHWbukV3kf7dH4JiDMckX5kJg68XQ0rzhC+qiTd9DHUJQmok5 ghhpzPk1uQucVzMiIeFqmGuqzyTHIkmzFHQWR0YyvS7C9UzH1LI/RgKEJ+nBnTg= X-Gm-Gg: ASbGncsVMpjPQHvMoqyAchEyaM2Zlj4u8mzRjMAHQHjyd2BhA029SJpIGtjwS+VTxtE 4HERwsdTp7QgWF8jwT34mlzFEhE3vNHPMmbZMICCOUoami4+0L5CYcsozBsWmvXiJia+jnuvGYA fwNueUo6WkqXx1y/X6jf45G4jRbCI/MHk3kOyENvgpbp32kqhk8SESZ8v3uRr0RE1uUi5AgNkGH t7DEx9g02+1Jw4dzhTJqDbvIDf/NrNvMisHbkVVyRYO+vcI8X4G9N49msYReUV7AlGgeOx4YoH2 tgIZcY+9V6AnI5Z+s/N6O/0bNYwexwE1UVO+AdPu/OtKsO6Sy/rQy75LLw== X-Google-Smtp-Source: AGHT+IHMJTHT8nKASCoftPW5WagcofTFuEZVGDHpfUu+3/RTdlhPh3dGTiFUWppYL39rlkLByj5LEQ== X-Received: by 2002:a05:6a20:258d:b0:1e1:a6a6:848 with SMTP id adf61e73a8af0-1ee49e8ccecmr1955504637.25.1739216968391; Mon, 10 Feb 2025 11:49:28 -0800 (PST) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ad53e71fb23sm4569990a12.45.2025.02.10.11.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 11:49:28 -0800 (PST) Date: Mon, 10 Feb 2025 11:49:25 -0800 From: Joe Damato To: Kurt Kanzenbach Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sebastian Andrzej Siewior , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: Re: [PATCH 0/3] igb: XDP/ZC follow up Message-ID: Mail-Followup-To: Joe Damato , Kurt Kanzenbach , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sebastian Andrzej Siewior , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org References: <20250210-igb_irq-v1-0-bde078cdb9df@linutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250210-igb_irq-v1-0-bde078cdb9df@linutronix.de> On Mon, Feb 10, 2025 at 10:19:34AM +0100, Kurt Kanzenbach wrote: > This is a follow up for the igb XDP/ZC implementation. The first two > patches link the IRQs and queues to NAPI instances. This is required to > bring back the XDP/ZC busy polling support. The last patch removes > undesired IRQs (injected via igb watchdog) while busy polling with > napi_defer_hard_irqs and gro_flush_timeout set. > > Signed-off-by: Kurt Kanzenbach > --- > Kurt Kanzenbach (3): > igb: Link IRQs to NAPI instances > igb: Link queues to NAPI instances > igb: Get rid of spurious interrupts > > drivers/net/ethernet/intel/igb/igb.h | 5 ++- > drivers/net/ethernet/intel/igb/igb_main.c | 67 ++++++++++++++++++++++++++----- > drivers/net/ethernet/intel/igb/igb_xsk.c | 3 ++ > 3 files changed, 65 insertions(+), 10 deletions(-) > --- > base-commit: acdefab0dcbc3833b5a734ab80d792bb778517a0 > change-id: 20250206-igb_irq-f5a4d4deb207 Overall wanted to note that Stanislav is working on some locking changes to remove the RTNL dependency [1]. My previous attempt at adding this API to virtio_net is on hold until the locking stuff Stanislav is doing is done. I am not sure if the maintainers will also ask to hold your series back, as well. [1]: https://lore.kernel.org/netdev/20250204230057.1270362-1-sdf@fomichev.me/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DD3CC02198 for ; Mon, 10 Feb 2025 19:49:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 4217741347; Mon, 10 Feb 2025 19:49:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id OrE22F1RKRim; Mon, 10 Feb 2025 19:49:31 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 344FD4132B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1739216971; bh=fTt2O+89+OX1qceRzkPwIzbuTN/WSFucT4iz8Aiof2Q=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=5rSREgSz/0NPzCGrihRGDhUrlbACwnQssPwV35LItq64l4CltgzzhWsXou9wedSPL Uv5kh2eh4Y3uSc6RAYBr180stg6pn3kckDftmTaeXePhql0eYVHHUl2e3hkapR9knI V1HTYJDb2uYcBEBqtAvwT5+Zmm0B39I3rL9EF8Q1/zHMzX7FYilnKAVzIwXwxzsqSZ OCsHv8phzZOgLk07k6b3ZRmnch7lr1lYrBeAh1A5ley/KLTF8HOODOf4KgfdDbHbKU lZeRSxnDQ4RSadjeCp9U1uNvX7AQnvbMvb1d7wLxj5j3kNGW60j+OsBvuwlFDjdDz6 4oGyI7dm1RUXQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 344FD4132B; Mon, 10 Feb 2025 19:49:31 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id 22FC26C for ; Mon, 10 Feb 2025 19:49:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1E1FC60B6D for ; Mon, 10 Feb 2025 19:49:30 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id gKPoiFWE3uX0 for ; Mon, 10 Feb 2025 19:49:29 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::62a; helo=mail-pl1-x62a.google.com; envelope-from=jdamato@fastly.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 39FC660B6A DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 39FC660B6A Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by smtp3.osuosl.org (Postfix) with ESMTPS id 39FC660B6A for ; Mon, 10 Feb 2025 19:49:28 +0000 (UTC) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-21f50895565so50709335ad.2 for ; Mon, 10 Feb 2025 11:49:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739216968; x=1739821768; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fTt2O+89+OX1qceRzkPwIzbuTN/WSFucT4iz8Aiof2Q=; b=Is+7ykbwRZXdZdSWvImVnbRHkFj0uB4teNL+7kMQ+HxWqxaQWpPwshCcwY2OwusrkO K29XKzEZAv7LljRsSFuGMvI8N8+GN7y67dBwzAzBPkhiUrRFgYjZKLXq9apvUUovL/Zh THW6BlrGxrj1obVfqQUpQ6rhl49P+B2vfB2sfoCsgeI3ZG9AWt5WW9zXz6CRPy/pHZyq NYRehZ6OeSCgh6bRkhIXRJ0RGl3//EphzFmcitUDEMtXw9rVXRPF+GPgi8ZKl+rBGkFm qiVTQEWa3DyT1iuwArXLPy4TZVBpXwCpT0w6onXdCoIXLlJf83KRtVkcAuULQhYASFqz 5IwQ== X-Forwarded-Encrypted: i=1; AJvYcCW2y1OQiaPCVRj7xXPa4JF1IzwN2A8X3cZ3RhUi6KizEbZWm33TeN2+d0AZEzS+UZzqg2N32cCqGUTaLSoFrHw=@lists.osuosl.org X-Gm-Message-State: AOJu0Yw4tWoqlgdLtwsZhvk81IbtA7+5jl4FQXPT5/f28yptbWrNrUSH HUkUJ1NNcMm1MQsymOMfNtrEljUOQPNWwW/RXX3ai3CAK0mEwWpYN/ufcvCKWS0= X-Gm-Gg: ASbGncuzjMIv/UQLDxyLZsBG+iQT/U0dEt7FDjp+35bU04xPKzwqi8hOuK++WA5zHWC 6kjVwnv1FPr7KLaNdAIvWP3lUJdlah55C5eOmg2Rj3D+fuCUzXyF3uF/cyIiO3qG430t8sR0bkF VEj4r7aOBL94LihYkbV4FFXn3b+TXemI4qEEnLnTWECpxpYu1NliOBOSUwABS4ZMOj3UQcIBiYA vHXXKqsYqKGL/1eGDWICFTOLnVH+Jp5dQNO1cxTCA9/CHny5BLbLlE3zzBO3DeRnvB2mvwvn7Dt 5ezahYxd76JZ1CAdCi/WmEJhcuDiZ6XHcTaknC1SHhQ2xMsd5Ua6a+dr3A== X-Google-Smtp-Source: AGHT+IHMJTHT8nKASCoftPW5WagcofTFuEZVGDHpfUu+3/RTdlhPh3dGTiFUWppYL39rlkLByj5LEQ== X-Received: by 2002:a05:6a20:258d:b0:1e1:a6a6:848 with SMTP id adf61e73a8af0-1ee49e8ccecmr1955504637.25.1739216968391; Mon, 10 Feb 2025 11:49:28 -0800 (PST) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ad53e71fb23sm4569990a12.45.2025.02.10.11.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 11:49:28 -0800 (PST) Date: Mon, 10 Feb 2025 11:49:25 -0800 From: Joe Damato To: Kurt Kanzenbach Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sebastian Andrzej Siewior , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Message-ID: Mail-Followup-To: Joe Damato , Kurt Kanzenbach , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sebastian Andrzej Siewior , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org References: <20250210-igb_irq-v1-0-bde078cdb9df@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250210-igb_irq-v1-0-bde078cdb9df@linutronix.de> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1739216968; x=1739821768; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=fTt2O+89+OX1qceRzkPwIzbuTN/WSFucT4iz8Aiof2Q=; b=pdU1Hd5elnSfi7c/OA1PkM/tbJI9WHrGhQE8mh+18X3U2hLfN4lfsZAm/NPTcOA8kT ca9sAnlb4tPGXsk/54OO0pWlbRt2KTe9xf8fYs8r9AJjF2FZrAEGZA2bAZBN9mSDkQMK wOtB+AG5ZtyediJ+N31ShlCPLM7Flff3n2CD8= X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=reject dis=none) header.from=fastly.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=fastly.com header.i=@fastly.com header.a=rsa-sha256 header.s=google header.b=pdU1Hd5e Subject: Re: [Intel-wired-lan] [PATCH 0/3] igb: XDP/ZC follow up X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Feb 10, 2025 at 10:19:34AM +0100, Kurt Kanzenbach wrote: > This is a follow up for the igb XDP/ZC implementation. The first two > patches link the IRQs and queues to NAPI instances. This is required to > bring back the XDP/ZC busy polling support. The last patch removes > undesired IRQs (injected via igb watchdog) while busy polling with > napi_defer_hard_irqs and gro_flush_timeout set. > > Signed-off-by: Kurt Kanzenbach > --- > Kurt Kanzenbach (3): > igb: Link IRQs to NAPI instances > igb: Link queues to NAPI instances > igb: Get rid of spurious interrupts > > drivers/net/ethernet/intel/igb/igb.h | 5 ++- > drivers/net/ethernet/intel/igb/igb_main.c | 67 ++++++++++++++++++++++++++----- > drivers/net/ethernet/intel/igb/igb_xsk.c | 3 ++ > 3 files changed, 65 insertions(+), 10 deletions(-) > --- > base-commit: acdefab0dcbc3833b5a734ab80d792bb778517a0 > change-id: 20250206-igb_irq-f5a4d4deb207 Overall wanted to note that Stanislav is working on some locking changes to remove the RTNL dependency [1]. My previous attempt at adding this API to virtio_net is on hold until the locking stuff Stanislav is doing is done. I am not sure if the maintainers will also ask to hold your series back, as well. [1]: https://lore.kernel.org/netdev/20250204230057.1270362-1-sdf@fomichev.me/