From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>,
Ian Stokes <ian.stokes@intel.com>,
Patrick Robb <probb@iol.unh.edu>,
Paul Szczepanek <Paul.Szczepanek@arm.com>
Subject: Re: [PATCH v3] build: replace support for icc with icx
Date: Tue, 11 Feb 2025 10:08:44 +0000 [thread overview]
Message-ID: <Z6shrO5njIJtB_3p@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8xqY=XxNy-fN7VTX-MOdtTCAOVGGW5HGPayfARqMsrFFQ@mail.gmail.com>
On Tue, Feb 11, 2025 at 10:50:23AM +0100, David Marchand wrote:
> On Mon, Feb 10, 2025 at 6:19 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> > diff --git a/dts/framework/testbed_model/posix_session.py b/dts/framework/testbed_model/posix_session.py
> > index 981600e24c..eab08a90ce 100644
> > --- a/dts/framework/testbed_model/posix_session.py
> > +++ b/dts/framework/testbed_model/posix_session.py
> > @@ -391,8 +391,6 @@ def get_compiler_version(self, compiler_name: str) -> str:
> > ).stdout.split("\n")[0]
> > case "msvc":
> > return self.send_command("cl", SETTINGS.timeout).stdout
> > - case "icc":
> > - return self.send_command(f"{compiler_name} -V", SETTINGS.timeout).stdout
> > case _:
> > raise ValueError(f"Unknown compiler {compiler_name}")
> >
>
> I think we can drop icc = auto() in dts/framework/config/test_run.py too.
> Wdyt?
>
> I can fix when applying.
>
+1
Please fix on apply.
Thanks.
next prev parent reply other threads:[~2025-02-11 10:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 16:18 [PATCH] build: remove support for icc compiler Bruce Richardson
2025-02-05 16:33 ` Stephen Hemminger
2025-02-05 17:03 ` David Marchand
2025-02-05 17:32 ` Bruce Richardson
2025-02-05 17:46 ` Bruce Richardson
2025-02-05 18:29 ` [PATCH v2 0/2] replace icc support with icx Bruce Richardson
2025-02-05 18:29 ` [PATCH v2 1/2] drivers: fix build warnings when using icx Bruce Richardson
2025-02-10 10:55 ` Stokes, Ian
2025-02-05 18:29 ` [PATCH v2 2/2] build: replace support for icc with icx Bruce Richardson
2025-02-06 15:19 ` David Marchand
2025-02-10 10:55 ` Stokes, Ian
2025-02-10 17:18 ` [PATCH v3] " Bruce Richardson
2025-02-11 9:50 ` David Marchand
2025-02-11 10:08 ` Bruce Richardson [this message]
2025-02-11 10:51 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6shrO5njIJtB_3p@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=Paul.Szczepanek@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=probb@iol.unh.edu \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.