From: Alyssa Rosenzweig <alyssa@rosenzweig.io>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Sven Peter <sven@svenpeter.dev>, Janne Grunau <j@jannau.net>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Hector Martin <marcan@marcan.st>
Subject: Re: [PATCH 2/5] iommu/dart: Skip reset for locked DARTs
Date: Tue, 11 Feb 2025 13:44:51 -0500 [thread overview]
Message-ID: <Z6uao2OnBcg9zkrc@blossom> (raw)
In-Reply-To: <98af5c02-5006-4272-aaf0-a0e30c312059@arm.com>
> > struct apple_dart *dart = platform_get_drvdata(pdev);
> > - apple_dart_hw_reset(dart);
> > + if (!dart->locked)
> > + apple_dart_hw_reset(dart);
>
> Not much point saving anything on suspend either, in that case.
Quite right. Fixed in v2, thanks!
next prev parent reply other threads:[~2025-02-11 18:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 19:39 [PATCH 0/5] iommu: apple-dart: Support locked DARTs Alyssa Rosenzweig
2025-02-10 19:39 ` [PATCH 1/5] iommu/dart: Track if the DART is locked Alyssa Rosenzweig
2025-02-10 19:39 ` [PATCH 2/5] iommu/dart: Skip reset for locked DARTs Alyssa Rosenzweig
2025-02-11 18:34 ` Robin Murphy
2025-02-11 18:44 ` Alyssa Rosenzweig [this message]
2025-02-10 19:39 ` [PATCH 3/5] iommu/dart: Set DMA domain " Alyssa Rosenzweig
2025-02-11 18:25 ` Robin Murphy
2025-02-11 18:40 ` Alyssa Rosenzweig
2025-02-11 20:37 ` Robin Murphy
2025-02-10 19:39 ` [PATCH 4/5] iommu/dart: Reject identity " Alyssa Rosenzweig
2025-02-11 6:07 ` Nick Chan
2025-02-11 12:17 ` Alyssa Rosenzweig
2025-02-10 19:39 ` [PATCH 5/5] iommu/dart: Assert !locked when configuring Alyssa Rosenzweig
2025-02-11 18:41 ` Robin Murphy
2025-02-11 19:20 ` Alyssa Rosenzweig
2025-02-11 19:21 ` Janne Grunau
2025-02-11 21:13 ` Robin Murphy
2025-02-10 19:48 ` [PATCH 0/5] iommu: apple-dart: Support locked DARTs Neal Gompa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6uao2OnBcg9zkrc@blossom \
--to=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=iommu@lists.linux.dev \
--cc=j@jannau.net \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robin.murphy@arm.com \
--cc=sven@svenpeter.dev \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.