From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 128AAC0219B for ; Wed, 12 Feb 2025 00:39:21 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1ti0md-0002Kp-Sz; Wed, 12 Feb 2025 00:39:19 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ti0mc-0002Ki-Rw for linux-f2fs-devel@lists.sourceforge.net; Wed, 12 Feb 2025 00:39:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6FhL1yYW/cEPR1gQn2L79Vi7r6sah+Dzt3T9Wladpwo=; b=K8ZF3Q46DfkjwkjV7D+N1qBy4k mDzerPWTb1v+VmSPFePuOLeO3V1MauFlYImyUsAESh7dPs/IbrKQzkpEnkW9cy/H5oVHGLxpMp+dh GUAG/aNG6X8OeWhxrNxNVXwrMCoQHfxSs8ffk+Ba5GaOr6ecJsD25ISlseOVb9NB7Ls4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6FhL1yYW/cEPR1gQn2L79Vi7r6sah+Dzt3T9Wladpwo=; b=JNJLRu8xq8opl8LFHuGtQndcAH Wghj6DJxKxcgYBVF38DxoGMUJcQ/OAWQnCvniuBgmAiNjQ9OmHw40iKP1NjxSfubGBLe3NQjaM4yw d6AMJv9A6hJl42wuxhFIMxFYYsiMR4UOXNtayuod2KOfH94xSZmTte8/mU1fLt0F70Sw=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1ti0mb-0003AT-IV for linux-f2fs-devel@lists.sourceforge.net; Wed, 12 Feb 2025 00:39:18 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A0B3A5C5661; Wed, 12 Feb 2025 00:38:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B854C4CEDD; Wed, 12 Feb 2025 00:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739320746; bh=4UzwP9mzXKuiCXOs+Y9SzPdYG/HGt/RpUx2drHDa7J4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ebeRGoMYbTZd2SfuijG7tuIxqoBpjfvwIZJnfD/90W8lULSGbjjBUobyzxBQYhoOO h+qoJw8YLwP8RvzGyl3HgUFTfSpmFM9otwil+uqnndpim1jG0S3tFveQcvzR7JGApV o2iXRA10BU3x9wo5XjPlDh1t782hkJmymH28h4ey/b1NLNGtgL+htxyWC7IOhcivjy ECmioTToU65ecSINjnchVemGqfXjrs2i61bdkDy1CVorYfbKHRFBepM/ZBtxu45fyj LsOmEnysEAOp851zcnqx2A7TV8r45lKhcqDrdpPn5KuBYRV3vsx//uq5tMSiwZxFHU UDfYoQpp5j/xw== Date: Wed, 12 Feb 2025 00:39:04 +0000 To: Matthew Wilcox Message-ID: References: <20250117164350.2419840-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1ti0mb-0003AT-IV Subject: Re: [f2fs-dev] [PATCH 0/2 v6] add ioctl/sysfs to donate file-backed pages X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jaegeuk Kim via Linux-f2fs-devel Reply-To: Jaegeuk Kim Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 02/10, Jaegeuk Kim wrote: > On 02/10, Matthew Wilcox wrote: > > On Mon, Feb 10, 2025 at 05:00:47PM +0000, Jaegeuk Kim wrote: > > > On 02/04, Jaegeuk Kim wrote: > > > > On 01/17, Jaegeuk Kim wrote: > > > > > On 01/17, Matthew Wilcox wrote: > > > > > > On Fri, Jan 17, 2025 at 06:48:55PM +0000, Jaegeuk Kim wrote: > > > > > > > > I don't understand how this is different from MADV_COLD. Please > > > > > > > > explain. > > > > > > > > > > > > > > MADV_COLD is a vma range, while this is a file range. So, it's more close to > > > > > > > fadvise(POSIX_FADV_DONTNEED) which tries to reclaim the file-backed pages > > > > > > > at the time when it's called. The idea is to keep the hints only, and try to > > > > > > > reclaim all later when admin expects system memory pressure soon. > > > > > > > > > > > > So you're saying you want POSIX_FADV_COLD? > > > > > > > > > > Yeah, the intention looks similar like marking it cold and paging out later. > > > > > > > > Kindly ping, for the feedback on the direction. If there's demand for something > > > > generalized api, I'm happy to explore. > > > > > > If there's no objection, let me push the change in f2fs and keep an eye on > > > who more will need this in general. > > > > I don't know why you're asking for direction. I gave my direction: use > > fadvise(). > > Funny, that single question didn't mean like this at all. Will take a look > how the patch looks like. Ok, it seems we can get this hint via POSIX_FADV_NOREUSE. I'll take that instead of adding a new API. Thanks. > > > > > Putting this directly in f2fs is a horrible idea. NAK. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E5AF1C695; Wed, 12 Feb 2025 00:39:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739320747; cv=none; b=mrdQOC36iCTaEgssoVS9M/w3lLcdCwxB9PC3EEFsnMvXrnqhlNi8huu/2roW/okQ0tqlUAencxo8e4edtuX/98IzFLi4QYIuqw37O1/vFiDehnm1kKjPa6uCkxACQ2uHWkD76xFRU2UY8HQYBg16ShLQoRwPkmco8d/4qKO2oAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739320747; c=relaxed/simple; bh=4UzwP9mzXKuiCXOs+Y9SzPdYG/HGt/RpUx2drHDa7J4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IlOxzBUjrPUYYQ8aFxbHlD6+gkBuCTI8y2vwXeGL13VFx2U07OPEAhsPNF58zkknjdVa18dQDGhp++IIY8rkja+URIZm+1cdzQq6tXQJpxWWK6iNuMm99f/ylq3pM6FDrwf+WwYEExpgiDur242pY2qLUraw8VFsXb/u2DAqZ5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ebeRGoMY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ebeRGoMY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B854C4CEDD; Wed, 12 Feb 2025 00:39:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739320746; bh=4UzwP9mzXKuiCXOs+Y9SzPdYG/HGt/RpUx2drHDa7J4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ebeRGoMYbTZd2SfuijG7tuIxqoBpjfvwIZJnfD/90W8lULSGbjjBUobyzxBQYhoOO h+qoJw8YLwP8RvzGyl3HgUFTfSpmFM9otwil+uqnndpim1jG0S3tFveQcvzR7JGApV o2iXRA10BU3x9wo5XjPlDh1t782hkJmymH28h4ey/b1NLNGtgL+htxyWC7IOhcivjy ECmioTToU65ecSINjnchVemGqfXjrs2i61bdkDy1CVorYfbKHRFBepM/ZBtxu45fyj LsOmEnysEAOp851zcnqx2A7TV8r45lKhcqDrdpPn5KuBYRV3vsx//uq5tMSiwZxFHU UDfYoQpp5j/xw== Date: Wed, 12 Feb 2025 00:39:04 +0000 From: Jaegeuk Kim To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 0/2 v6] add ioctl/sysfs to donate file-backed pages Message-ID: References: <20250117164350.2419840-1-jaegeuk@kernel.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 02/10, Jaegeuk Kim wrote: > On 02/10, Matthew Wilcox wrote: > > On Mon, Feb 10, 2025 at 05:00:47PM +0000, Jaegeuk Kim wrote: > > > On 02/04, Jaegeuk Kim wrote: > > > > On 01/17, Jaegeuk Kim wrote: > > > > > On 01/17, Matthew Wilcox wrote: > > > > > > On Fri, Jan 17, 2025 at 06:48:55PM +0000, Jaegeuk Kim wrote: > > > > > > > > I don't understand how this is different from MADV_COLD. Please > > > > > > > > explain. > > > > > > > > > > > > > > MADV_COLD is a vma range, while this is a file range. So, it's more close to > > > > > > > fadvise(POSIX_FADV_DONTNEED) which tries to reclaim the file-backed pages > > > > > > > at the time when it's called. The idea is to keep the hints only, and try to > > > > > > > reclaim all later when admin expects system memory pressure soon. > > > > > > > > > > > > So you're saying you want POSIX_FADV_COLD? > > > > > > > > > > Yeah, the intention looks similar like marking it cold and paging out later. > > > > > > > > Kindly ping, for the feedback on the direction. If there's demand for something > > > > generalized api, I'm happy to explore. > > > > > > If there's no objection, let me push the change in f2fs and keep an eye on > > > who more will need this in general. > > > > I don't know why you're asking for direction. I gave my direction: use > > fadvise(). > > Funny, that single question didn't mean like this at all. Will take a look > how the patch looks like. Ok, it seems we can get this hint via POSIX_FADV_NOREUSE. I'll take that instead of adding a new API. Thanks. > > > > > Putting this directly in f2fs is a horrible idea. NAK.