From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 613E4F9D6 for ; Wed, 12 Feb 2025 00:50:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739321449; cv=none; b=ck2V7VMTAIEATc8TqDLiG6NjX+o81WqjhFzMpyeVsh7aGusHjG+mYHaNadmc8mBn6ZKivTRMyWropRzkcx7wlucTAoCjuZHgdxEqo8cke0u34WgE39gfYUkrpWOzDsX5fKMvgjwbrCDmnV4fw+xma8Fzp+i4ucmYFbpn8ZmspuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739321449; c=relaxed/simple; bh=n7CqHuFFZQ8afu+pSBOd4jMSThSswJ5fMlHS0DKB38U=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=oaDXv9WnZpFH+Pry/K8HqVTDsBI0FhwQkVPGVbTqDZeo3AyyQKVFn0Ig5+qOHUXLl0Lk3gU4ismzPizCdWnQVoLeeOwI17U3LYG9YsBJ3qVhBiTUUJ3+ds0AB2aT6nAU3niAEUTtJhP2bAqtGrM+yb9sS0dzBozO3RMYy0Yol9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=QPJCiV0x; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QPJCiV0x" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-21f73260b22so72812745ad.1 for ; Tue, 11 Feb 2025 16:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1739321448; x=1739926248; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7Q04QbfQicFM4y75hWxHLLd0YYIdGidwmS0pxxw3Lsc=; b=QPJCiV0xDPapSJ7g+OxDZCRRULlwPgYWajOlCi0Ds5Ipk+ro6e8MstysvHU5i2PkjG Nj7jN/xKSgfXLej7ui5StmoMqLsp6/kv0CpQNMyZLoTVANkUL099iCenOpuaJdcSfg2t ntZ1ce92zuTxO2NKeylabcrg40CxMN35TtKlUS8gP/sbbW9uvIkoZfLuIHFyMbPGyqnb Rvk4Y1OXeSb0XKYCioHQWFw4VOYpcKwrkmTRO5xw/b1oupHg5DPvPMi0vBKo5i6am+a9 I1xbURVbycMud7ONdA+P6OJANyZ5sXFwkzUMTcR920W0Mfly95uiskNr4uk1QUHdQqrc igXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739321448; x=1739926248; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7Q04QbfQicFM4y75hWxHLLd0YYIdGidwmS0pxxw3Lsc=; b=hm13h4cZO3NAEwkapxqSjgrOXgU74P+dHOauBKpVWVT9QleeL28ewQ+1rTM21wzrg3 1uwdbmj3yKwffjxTk4YMl1wiRLI2CTAfSjpUAXoNoDlwkTNSghZjlDIp+yDhQH5iOoWz 2O5bBtjQdY2j6JzYA0+WJUqCDyivT7r0oLEO0ISIZkIyUElE+L4AF515OVE0UE78dMI1 PHIXLXqxd0gDG+jirARvPSeatPNpjX8GBEJ29Ot6CB5u0Ezk0YvuAmZzxN8kKbhzpc1s dLuzloW8MbhBH6lDk7Php0jZwx6KhHZcUS46cGq+69FfsPf/VTtAB+AvsIUgRobEro4X qURA== X-Forwarded-Encrypted: i=1; AJvYcCX83wizKSE+Y7VqO8VwiQKUY0h8MbuNsH4q+ox9rpFohwj5JodoGDROw6fEYlaT16atrCE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxdy26kvOIwEfdffnk6n5H8c5oPxE8gg2c4YLHqPIdOXrc+cBOJ QdQBeAb+S9zip12xlVTbr5IPk7+cm8Ea/KrBeqll8Wg+xr40nbu8iz2jkyJiDDfM6knSatCaOJW TzQ== X-Google-Smtp-Source: AGHT+IHIfpcFcenWfDWwwbzufWY+DREdE282nCSmNYgV1FntJ/Yo5mvEkgosXQd56+1kM3WiXT9iDdhEUCE= X-Received: from pler19.prod.google.com ([2002:a17:902:e3d3:b0:21f:179:601a]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:11cc:b0:216:2bd7:1c27 with SMTP id d9443c01a7336-220bdfee64emr12985535ad.33.1739321447751; Tue, 11 Feb 2025 16:50:47 -0800 (PST) Date: Tue, 11 Feb 2025 16:50:46 -0800 In-Reply-To: <20250211025828.3072076-17-binbin.wu@linux.intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250211025828.3072076-1-binbin.wu@linux.intel.com> <20250211025828.3072076-17-binbin.wu@linux.intel.com> Message-ID: Subject: Re: [PATCH v2 16/17] KVM: TDX: Handle EXCEPTION_NMI and EXTERNAL_INTERRUPT From: Sean Christopherson To: Binbin Wu Cc: pbonzini@redhat.com, kvm@vger.kernel.org, rick.p.edgecombe@intel.com, kai.huang@intel.com, adrian.hunter@intel.com, reinette.chatre@intel.com, xiaoyao.li@intel.com, tony.lindgren@intel.com, isaku.yamahata@intel.com, yan.y.zhao@intel.com, chao.gao@intel.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Tue, Feb 11, 2025, Binbin Wu wrote: > + kvm_pr_unimpl("unexpected exception 0x%x(exit_reason 0x%x qual 0x%lx)\n", > + intr_info, vmx_get_exit_reason(vcpu).full, vmx_get_exit_qual(vcpu)); This should be vcpu_unimpl(). But I vote to omit it entirely. Ratelimited printks are notoriously unhelpful, and KVM is already providing a useful exit to userspace.