From: Namhyung Kim <namhyung@kernel.org>
To: "Krzysztof Łopatowski" <krzysztof.m.lopatowski@gmail.com>
Cc: Ian Rogers <irogers@google.com>,
acme@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: Improve startup time by reducing unnecessary stat() calls
Date: Tue, 11 Feb 2025 18:10:42 -0800 [thread overview]
Message-ID: <Z6wDInRZ7VVVcaHb@google.com> (raw)
In-Reply-To: <CAOQCU64Fhoek2YEJjhtAsTqPa1Jt1X9z3_C4+pL+R-6hs-EdDg@mail.gmail.com>
Hello,
On Thu, Feb 06, 2025 at 10:45:02PM +0100, Krzysztof Łopatowski wrote:
> Hi Ian,
> Thank you for taking the time to look into this.
>
> > I did a series and a new io_dir set of primitives.
> > The last version of which is:
> > https://lore.kernel.org/lkml/20231207050433.1426834-1-irogers@google.com/
> > I mention this as I think that series may be a better route than this
> > change as it solves a little bit more of the performance issue.
>
> I'd much prefer to have your solution merged, as it covers more instances
> of the same directory exploration pattern and provides an explicit
> approach to memory allocation.
>
> > I stopped pursuing the series as the maintainers were complaining
> > about unpopular libcs/platforms missing system call definitions
> > (getdents) and the series breaking on those platforms.
>
> Yeah, I agree. I also don't think doing an #undef because of muslc is a
> good approach. Would you and Namhyung be open to bypassing libc and
> calling SYS_getdents64 directly instead?
Yep, I'm ok with that.
Thanks,
Namhyung
next prev parent reply other threads:[~2025-02-12 2:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 11:33 [PATCH] perf: Improve startup time by reducing unnecessary stat() calls Krzysztof Łopatowski
2025-02-06 17:54 ` Ian Rogers
2025-02-06 21:45 ` Krzysztof Łopatowski
2025-02-12 2:10 ` Namhyung Kim [this message]
2025-02-07 1:04 ` Howard Chu
2025-02-07 8:31 ` Krzysztof Łopatowski
2025-02-20 18:26 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6wDInRZ7VVVcaHb@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=irogers@google.com \
--cc=krzysztof.m.lopatowski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.