From: Wei Liu <wei.liu@kernel.org>
To: mhklinux@outlook.com
Cc: haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
deller@gmx.de, weh@microsoft.com,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org
Subject: Re: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device
Date: Wed, 12 Feb 2025 02:27:27 +0000 [thread overview]
Message-ID: <Z6wHDw8BssJyQHiM@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20250209235252.2987-1-mhklinux@outlook.com>
On Sun, Feb 09, 2025 at 03:52:52PM -0800, mhkelley58@gmail.com wrote:
> From: Michael Kelley <mhklinux@outlook.com>
>
> When a Hyper-V framebuffer device is removed, or the driver is unbound
> from a device, any allocated and/or mapped memory must be released. In
> particular, MMIO address space that was mapped to the framebuffer must
> be unmapped. Current code unmaps the wrong address, resulting in an
> error like:
>
> [ 4093.980597] iounmap: bad address 00000000c936c05c
>
> followed by a stack dump.
>
> Commit d21987d709e8 ("video: hyperv: hyperv_fb: Support deferred IO for
> Hyper-V frame buffer driver") changed the kind of address stored in
> info->screen_base, and the iounmap() call in hvfb_putmem() was not
> updated accordingly.
>
> Fix this by updating hvfb_putmem() to unmap the correct address.
>
> Fixes: d21987d709e8 ("video: hyperv: hyperv_fb: Support deferred IO for Hyper-V frame buffer driver")
> Signed-off-by: Michael Kelley <mhklinux@outlook.com>
Applied to hyperv-fixes. Thanks.
prev parent reply other threads:[~2025-02-12 2:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 23:52 [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device mhkelley58
2025-02-10 12:40 ` Saurabh Singh Sengar
2025-02-10 14:28 ` Michael Kelley
2025-02-10 14:58 ` Saurabh Singh Sengar
2025-02-10 16:52 ` Saurabh Singh Sengar
2025-02-11 3:51 ` Michael Kelley
2025-02-13 1:35 ` Michael Kelley
2025-02-13 3:06 ` Saurabh Singh Sengar
2025-02-13 3:43 ` Michael Kelley
2025-02-12 2:27 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6wHDw8BssJyQHiM@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=decui@microsoft.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=haiyangz@microsoft.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=weh@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.