From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH v2 6/8] hwmon: (pmbus/core) Optimize debugfs block data attribute initialization
Date: Wed, 12 Feb 2025 03:53:46 +0000 [thread overview]
Message-ID: <Z6wbSon4kP68tJ6r@google.com> (raw)
In-Reply-To: <20250211155240.2077464-7-linux@roeck-us.net>
On Tue, Feb 11, 2025 at 07:52:38AM -0800, Guenter Roeck wrote:
> Define debugfs attributes which need block data access in a data
> structure and loop through it instead of creating debugfs files
> one by one. This reduces code size and simplifies adding additional
> attributes if needed.
>
> While this is currently only used for manufacturer specific attributes,
> the access code is generic and also works for other block attributes,
> so rename operation functions from _mfg to _block.
>
> While at it, rename the "revison" file to "pmbus_revision" to make its
> meaning more obvious and to create a clear distinction against the
> "mfg_revision" file.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
next prev parent reply other threads:[~2025-02-12 3:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 15:52 [PATCH v2 0/8] hwmon: (pmbus/core) Various fixes and improvements Guenter Roeck
2025-02-11 15:52 ` [PATCH v2 1/8] hwmon: (pmbus/core) Fix various coding style issues Guenter Roeck
2025-02-11 15:52 ` [PATCH v2 2/8] hwmon: (pmbus/core) Use local debugfs variable in debugfs initialization Guenter Roeck
2025-02-11 15:52 ` [PATCH v2 3/8] hwmon: (pmbus/core) Use the new i2c_client debugfs directory Guenter Roeck
2025-02-11 15:52 ` [PATCH v2 4/8] hwmon: (pmbus/core) Make debugfs code unconditional Guenter Roeck
2025-02-11 15:52 ` [PATCH v2 5/8] hwmon: (pmbus/core) Declare regulator notification function as void Guenter Roeck
2025-02-11 15:52 ` [PATCH v2 6/8] hwmon: (pmbus/core) Optimize debugfs block data attribute initialization Guenter Roeck
2025-02-12 3:53 ` Tzung-Bi Shih [this message]
2025-02-11 15:52 ` [PATCH v2 7/8] hwmon: (pmbus/core) Optimize debugfs status " Guenter Roeck
2025-02-12 3:54 ` Tzung-Bi Shih
2025-02-11 15:52 ` [PATCH v2 8/8] hwmon: (pmbus/core) Report content of CAPABILITY register in debugfs Guenter Roeck
2025-02-12 3:55 ` Tzung-Bi Shih
2025-02-12 3:59 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6wbSon4kP68tJ6r@google.com \
--to=tzungbi@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.