Re: [PULL 00/32] Misc HW patches for 2025-02-10

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Feb 11, 2025 at 07:53:32PM +0100, Philippe Mathieu-Daudé wrote:
> On 11/2/25 19:48, Philippe Mathieu-Daudé wrote:
> > On 11/2/25 19:26, Stefan Hajnoczi wrote:
> > > On Mon, Feb 10, 2025 at 3:43 PM Philippe Mathieu-Daudé
> > > <philmd@linaro.org> wrote:
> > > > 
> > > > The following changes since commit
> > > > 54e91d1523b412b4cff7cb36c898fa9dc133e886:
> > > > 
> > > >    Merge tag 'pull-qapi-2025-02-10-v2' of
> > > > https://repo.or.cz/qemu/ armbru into staging (2025-02-10
> > > > 10:47:31 -0500)
> > > > 
> > > > are available in the Git repository at:
> > > > 
> > > >    https://github.com/philmd/qemu.git tags/hw-misc-20250210
> > > > 
> > > > for you to fetch changes up to 1078a376932cc1d1c501ee3643fef329da6a189a:
> > > > 
> > > >    hw/net/smc91c111: Ignore attempt to pop from empty RX fifo
> > > > (2025-02-10 21:30:44 +0100)
> > > > 
> > > > ----------------------------------------------------------------
> > > > Misc HW patches
> > > > 
> > > > - Use qemu_hexdump_line() in TPM backend (Philippe)
> > > > - Make various Xilinx devices endianness configurable (Philippe)
> > > > - Remove magic number in APIC (Phil)
> > > > - Disable thread-level cache topology (Zhao)
> > > > - Xen QOM style cleanups (Bernhard)
> > > > - Introduce TYPE_DYNAMIC_SYS_BUS_DEVICE (Philippe)
> > > > - Invert logic of machine no_sdcard flag (Philippe)
> > > > - Housekeeping in MicroBlaze functional tests (Philippe)
> > > 
> > > Please take a look at this CI failure:
> > > https://gitlab.com/qemu-project/qemu/-/jobs/9106591368
> > 
> > Hmm I can not reproduce locally this error:
> > 
> >    Exception: Asset cache is invalid and downloads disabled
> 
> OK, I could reproduce by blowing my cache away.
> 
> The problem seems in the "tests/functional: Have microblaze tests
> inherit common parent class" patch, which does:
> 
> -class MicroblazeelMachine(QemuSystemTest):
> +class MicroblazeLittleEndianMachine(MicroblazeMachine):
> 
> I presume, since MicroblazeLittleEndianMachine is no more a direct
> child of QemuSystemTest, then the ASSET_IMAGE_* aren't automatically
> downloaded.

Yes, my code assumes all assets are on the leaf test classes. I'll
look at a fix since it is easy enough to check parent classes too.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|