From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: dimitri.fedrau@liebherr.com
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dimitri Fedrau <dima.fedrau@gmail.com>
Subject: Re: [PATCH net-next v4 1/3] dt-bindings: net: ethernet-phy: add property tx-amplitude-100base-tx-percent
Date: Wed, 12 Feb 2025 13:38:13 +0000 [thread overview]
Message-ID: <Z6ykRRBXo4tac6XQ@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250211-dp83822-tx-swing-v4-1-1e8ebd71ad54@liebherr.com>
On Tue, Feb 11, 2025 at 09:33:47AM +0100, Dimitri Fedrau via B4 Relay wrote:
> @@ -232,6 +232,12 @@ properties:
> PHY's that have configurable TX internal delays. If this property is
> present then the PHY applies the TX delay.
>
> + tx-amplitude-100base-tx-percent:
> + description:
> + Transmit amplitude gain applied for 100BASE-TX. When omitted, the PHYs
> + default will be left as is.
> + default: 100
> +
This should mention what the reference is - so 100% is 100% of what (it
would be the 802.3 specified 100BASE-TX level, but it should make that
clear.)
I'm having a hard time trying to find its specification in 802.3, so
maybe a reference to where it can be found would be useful, otherwise
it's unclear what one gets for "100%".
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-02-12 13:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 8:33 [PATCH net-next v4 0/3] net: phy: dp83822: Add support for changing the transmit amplitude voltage Dimitri Fedrau
2025-02-11 8:33 ` Dimitri Fedrau via B4 Relay
2025-02-11 8:33 ` [PATCH net-next v4 1/3] dt-bindings: net: ethernet-phy: add property tx-amplitude-100base-tx-percent Dimitri Fedrau
2025-02-11 8:33 ` Dimitri Fedrau via B4 Relay
2025-02-11 16:57 ` Conor Dooley
2025-02-12 13:04 ` Andrew Lunn
2025-02-12 19:22 ` Dimitri Fedrau
2025-02-12 13:38 ` Russell King (Oracle) [this message]
2025-02-12 19:34 ` Dimitri Fedrau
2025-02-11 8:33 ` [PATCH net-next v4 2/3] net: phy: Add helper for getting tx amplitude gain Dimitri Fedrau
2025-02-11 8:33 ` Dimitri Fedrau via B4 Relay
2025-02-12 13:15 ` Andrew Lunn
2025-02-12 19:36 ` Dimitri Fedrau
2025-02-11 8:33 ` [PATCH net-next v4 3/3] net: phy: dp83822: Add support for changing the transmit amplitude voltage Dimitri Fedrau
2025-02-11 8:33 ` Dimitri Fedrau via B4 Relay
2025-02-12 13:18 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6ykRRBXo4tac6XQ@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=afd@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dima.fedrau@gmail.com \
--cc=dimitri.fedrau@liebherr.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.