From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7DF3C02198 for ; Wed, 12 Feb 2025 16:47:47 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tiFtq-0001ea-AO; Wed, 12 Feb 2025 16:47:46 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tiFto-0001eT-T7 for linux-f2fs-devel@lists.sourceforge.net; Wed, 12 Feb 2025 16:47:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eEe1kZKfKlf9Yf9M+1rNPR675pPsmmZoxHAnxXs4f2I=; b=mwnyN0gPFMnDFmECz7CLihlwWz 9LhRwktIkGKIoJ9NA8zbszChc4If7udSGusY7G8z9HWuKGOtJma5fk6kgNtBK94Mm+1FybuVWsx74 G3dlOSN96Enw1S5SFmNIc8GDaStraYCd+2PrcSkxt36Nffn6O2Q2CBqtJoyQr/DsyYGU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eEe1kZKfKlf9Yf9M+1rNPR675pPsmmZoxHAnxXs4f2I=; b=EdFJHJDQrSnt04xbLCwsN6xt99 D6QNSp8P36BGwvrcloFBroDjOfZKZ1jsEhYRrXklmngYyaZPbLBQst0BjLlpdITeKKEzBjIckuiy0 55FP+E+zQRcd4A3mpfTJ/93xnAsUhvZilO36ueblKu9GefmjGJWRMr4jE/o9mYKfZEO8=; Received: from nyc.source.kernel.org ([147.75.193.91]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1tiFto-0006he-3O for linux-f2fs-devel@lists.sourceforge.net; Wed, 12 Feb 2025 16:47:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 0CA3EA40CE5; Wed, 12 Feb 2025 16:45:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD895C4CEDF; Wed, 12 Feb 2025 16:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739378853; bh=l49aKGECHlQJL+5gadj9OfHegUDAV/GXDkNvlccDNUs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ct/YiBkVj/1vprGdL50t6+tZ3aG+ajLJswfKlgU/6eAGNwlyaDIyRSYBf/INefrZ1 7JpaxOf5/XOZGMmA7XrVJhPuc8ADt/r/W+ONiwSiZYVpKS2UUKvuP8LExJYrV/i+Cz 1EErM067bDYnFD8+ddMlm7UFaKiU9UTWnxGxgqmOSVc6hVTr/Bh1r7h+HmqTbID41Y sYDQD2DNG9NwACjfkyyzC4xYDufLXJZ0rl55jFIN3Q+xBBSWINodFmr++kj0cTn0KO mo/Z8qRGKRBbF7Ot+FMipeblXWVrmDj6fj9oCuXf4qO45Sm01DpmVH7m+h5hhmhdYO cwJXaM1AQQ1HQ== Date: Wed, 12 Feb 2025 16:47:31 +0000 To: Chao Yu Message-ID: References: <20250212072742.977248-1-chao@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250212072742.977248-1-chao@kernel.org> X-Headers-End: 1tiFto-0006he-3O Subject: Re: [f2fs-dev] [PATCH v4] f2fs: add check for deleted inode X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jaegeuk Kim via Linux-f2fs-devel Reply-To: Jaegeuk Kim Cc: syzbot+b01a36acd7007e273a83@syzkaller.appspotmail.com, linux-kernel@vger.kernel.org, Leo Stone , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 02/12, Chao Yu wrote: > From: Leo Stone > > The syzbot reproducer mounts a f2fs image, then tries to unlink an > existing file. However, the unlinked file already has a link count of 0 > when it is read for the first time in do_read_inode(). > > Add a check to sanity_check_inode() for i_nlink == 0. > > [Chao Yu: rebase the code and fix orphan inode recovery issue] > Reported-by: syzbot+b01a36acd7007e273a83@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=b01a36acd7007e273a83 > Fixes: 39a53e0ce0df ("f2fs: add superblock and major in-memory structure") > Signed-off-by: Leo Stone > Signed-off-by: Chao Yu > --- > fs/f2fs/checkpoint.c | 4 ++++ > fs/f2fs/f2fs.h | 1 + > fs/f2fs/inode.c | 6 ++++++ > 3 files changed, 11 insertions(+) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index bd890738b94d..ada2c548645c 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -751,6 +751,8 @@ int f2fs_recover_orphan_inodes(struct f2fs_sb_info *sbi) > if (is_sbi_flag_set(sbi, SBI_IS_WRITABLE)) > f2fs_info(sbi, "orphan cleanup on readonly fs"); > > + set_sbi_flag(sbi, SBI_ORPHAN_RECOVERY); What about using SBI_POR_DOING? > + > start_blk = __start_cp_addr(sbi) + 1 + __cp_payload(sbi); > orphan_blocks = __start_sum_addr(sbi) - 1 - __cp_payload(sbi); > > @@ -778,9 +780,11 @@ int f2fs_recover_orphan_inodes(struct f2fs_sb_info *sbi) > } > f2fs_put_page(page, 1); > } > + > /* clear Orphan Flag */ > clear_ckpt_flags(sbi, CP_ORPHAN_PRESENT_FLAG); > out: > + clear_sbi_flag(sbi, SBI_ORPHAN_RECOVERY); > set_sbi_flag(sbi, SBI_IS_RECOVERED); > > return err; > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 05879c6dc4d6..1c75081c0c14 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -1322,6 +1322,7 @@ enum { > SBI_IS_CLOSE, /* specify unmounting */ > SBI_NEED_FSCK, /* need fsck.f2fs to fix */ > SBI_POR_DOING, /* recovery is doing or not */ > + SBI_ORPHAN_RECOVERY, /* orphan inodes recovery is doing */ > SBI_NEED_SB_WRITE, /* need to recover superblock */ > SBI_NEED_CP, /* need to checkpoint */ > SBI_IS_SHUTDOWN, /* shutdown by ioctl */ > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index d6ad7810df69..02f1b69d03d8 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -386,6 +386,12 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page) > } > } > > + if (inode->i_nlink == 0 && !is_sbi_flag_set(sbi, SBI_ORPHAN_RECOVERY)) { > + f2fs_warn(sbi, "%s: inode (ino=%lx) has a link count of 0", > + __func__, inode->i_ino); > + return false; > + } > + > return true; > } > > -- > 2.48.1.502.g6dc24dfdaf-goog _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 398D424C68E for ; Wed, 12 Feb 2025 16:47:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739378853; cv=none; b=N26PjK2jfp6OZ8wqjkYIIn0vD/zw28LpfyJYuijatLuWq1O4PDQQLRCPuN7UllcMCv0VzhmOCOXd/6R3Nj+12XTA8IbKT4k4pQZJeFZnLxl+fO4q8Rzn6C027boWMwAbLckh2rxOzeUO3nsyQJZMLwR+nTIbaZA9DFc316+LndM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739378853; c=relaxed/simple; bh=l49aKGECHlQJL+5gadj9OfHegUDAV/GXDkNvlccDNUs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kqebyYTpPuOu8FrQfNyex0UDBHB1TDt83ffWuSXnv6m8W/qwddSGe7ROE9qEW0JMQP0zjz85vIn3pCeEyYZMea4Io2NtrqnPHcEXo3h7Zj+jgJbzEIqBBiDkvXIuGBOgxShBe5DM9ZzhyQQYCnv+YOUvYugejgDpIZdq4oGGLK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ct/YiBkV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ct/YiBkV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD895C4CEDF; Wed, 12 Feb 2025 16:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739378853; bh=l49aKGECHlQJL+5gadj9OfHegUDAV/GXDkNvlccDNUs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ct/YiBkVj/1vprGdL50t6+tZ3aG+ajLJswfKlgU/6eAGNwlyaDIyRSYBf/INefrZ1 7JpaxOf5/XOZGMmA7XrVJhPuc8ADt/r/W+ONiwSiZYVpKS2UUKvuP8LExJYrV/i+Cz 1EErM067bDYnFD8+ddMlm7UFaKiU9UTWnxGxgqmOSVc6hVTr/Bh1r7h+HmqTbID41Y sYDQD2DNG9NwACjfkyyzC4xYDufLXJZ0rl55jFIN3Q+xBBSWINodFmr++kj0cTn0KO mo/Z8qRGKRBbF7Ot+FMipeblXWVrmDj6fj9oCuXf4qO45Sm01DpmVH7m+h5hhmhdYO cwJXaM1AQQ1HQ== Date: Wed, 12 Feb 2025 16:47:31 +0000 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Leo Stone , syzbot+b01a36acd7007e273a83@syzkaller.appspotmail.com Subject: Re: [PATCH v4] f2fs: add check for deleted inode Message-ID: References: <20250212072742.977248-1-chao@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250212072742.977248-1-chao@kernel.org> On 02/12, Chao Yu wrote: > From: Leo Stone > > The syzbot reproducer mounts a f2fs image, then tries to unlink an > existing file. However, the unlinked file already has a link count of 0 > when it is read for the first time in do_read_inode(). > > Add a check to sanity_check_inode() for i_nlink == 0. > > [Chao Yu: rebase the code and fix orphan inode recovery issue] > Reported-by: syzbot+b01a36acd7007e273a83@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=b01a36acd7007e273a83 > Fixes: 39a53e0ce0df ("f2fs: add superblock and major in-memory structure") > Signed-off-by: Leo Stone > Signed-off-by: Chao Yu > --- > fs/f2fs/checkpoint.c | 4 ++++ > fs/f2fs/f2fs.h | 1 + > fs/f2fs/inode.c | 6 ++++++ > 3 files changed, 11 insertions(+) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index bd890738b94d..ada2c548645c 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -751,6 +751,8 @@ int f2fs_recover_orphan_inodes(struct f2fs_sb_info *sbi) > if (is_sbi_flag_set(sbi, SBI_IS_WRITABLE)) > f2fs_info(sbi, "orphan cleanup on readonly fs"); > > + set_sbi_flag(sbi, SBI_ORPHAN_RECOVERY); What about using SBI_POR_DOING? > + > start_blk = __start_cp_addr(sbi) + 1 + __cp_payload(sbi); > orphan_blocks = __start_sum_addr(sbi) - 1 - __cp_payload(sbi); > > @@ -778,9 +780,11 @@ int f2fs_recover_orphan_inodes(struct f2fs_sb_info *sbi) > } > f2fs_put_page(page, 1); > } > + > /* clear Orphan Flag */ > clear_ckpt_flags(sbi, CP_ORPHAN_PRESENT_FLAG); > out: > + clear_sbi_flag(sbi, SBI_ORPHAN_RECOVERY); > set_sbi_flag(sbi, SBI_IS_RECOVERED); > > return err; > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 05879c6dc4d6..1c75081c0c14 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -1322,6 +1322,7 @@ enum { > SBI_IS_CLOSE, /* specify unmounting */ > SBI_NEED_FSCK, /* need fsck.f2fs to fix */ > SBI_POR_DOING, /* recovery is doing or not */ > + SBI_ORPHAN_RECOVERY, /* orphan inodes recovery is doing */ > SBI_NEED_SB_WRITE, /* need to recover superblock */ > SBI_NEED_CP, /* need to checkpoint */ > SBI_IS_SHUTDOWN, /* shutdown by ioctl */ > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index d6ad7810df69..02f1b69d03d8 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -386,6 +386,12 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page) > } > } > > + if (inode->i_nlink == 0 && !is_sbi_flag_set(sbi, SBI_ORPHAN_RECOVERY)) { > + f2fs_warn(sbi, "%s: inode (ino=%lx) has a link count of 0", > + __func__, inode->i_ino); > + return false; > + } > + > return true; > } > > -- > 2.48.1.502.g6dc24dfdaf-goog