Re: [PATCH v8 03/12] iommufd: Pass @pasid through the device attach/replace path

[Nicolin Chen <nicolinc@nvidia.com>]

On Wed, Feb 26, 2025 at 03:40:23AM -0800, Yi Liu wrote:
>  int iommufd_hw_pagetable_attach(struct iommufd_hw_pagetable *hwpt,
> -				struct iommufd_device *idev)
> +				struct iommufd_device *idev,
> +				ioasid_t pasid)

I think these two could fit in one line.

> @@ -187,7 +187,8 @@ iommufd_hwpt_paging_alloc(struct iommufd_ctx *ictx, struct iommufd_ioas *ioas,
>  	 * sequence. Once those drivers are fixed this should be removed.
>  	 */
>  	if (immediate_attach) {
> -		rc = iommufd_hw_pagetable_attach(hwpt, idev);
> +		/* Sinc this is just a trick, so passing IOMMU_NO_PASID is enough */

"Since"

>  int iommufd_hw_pagetable_attach(struct iommufd_hw_pagetable *hwpt,
> -				struct iommufd_device *idev);
> +				struct iommufd_device *idev,
> +				ioasid_t pasid);

Here too.

Otherwise,
Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>